From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBD4EA0547; Tue, 31 May 2022 14:57:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6164A40143; Tue, 31 May 2022 14:57:29 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 79B94400EF for <dev@dpdk.org>; Tue, 31 May 2022 14:57:28 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D98885C048A; Tue, 31 May 2022 08:57:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 31 May 2022 08:57:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1654001847; x= 1654088247; bh=ngl2nKKa6D4axUMMcr/F4sHENYFnaW1KDaT368z16qI=; b=Q vDATDzMVXDTbaw0M0E7xHP4MAVlfgbq6X1Yo0UDyOo/H/19BWuUyxhkN1DVVlw26 mCCwZNSj9Eh19442l0oiFe3+x3BAnig4uRfJ2ILvz++51AIlKtNPFK9DFGAr4Zd6 hnLD86xVvQqNvnNmOkMfCtKS0wrKhjUMQMBOEIaJPwA4dBBbZrDbLhIO+fPfvAnc vQB45PQYMd7uOz8LYU5sdNd/WkgglyLcTnG60Zmy6quinUy4tBIKQsOqkFAHrUnm ffSEBqq9lYbFajlcU6vo7YqiZLUI9Aczc2BEJV+nbc9m2DBLL9mq+Xjq0jdPs/S4 lM5fcms78rl0Ll1I7vaJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1654001847; x= 1654088247; bh=ngl2nKKa6D4axUMMcr/F4sHENYFnaW1KDaT368z16qI=; b=b Ts7990VtFnuK7cEqlxFV7qfuqnRgxOsTuKI5/lzSKuoASg52m1CADpdxqywfin6V a8UFUOCwtnvwNM2t/bzPiiyLH6dYwom8cTmLTdjSmASW9dPOH9jneQnJ3n4PBVu7 hlzBsfAqk332R7LAISWVvVDEJwRdwA745dhts2NOs4vH6nK/KxRGvaqVG5OzXPhf sJj6ftSpVjuLW2HYTbgyBBCOpTlCIzHaZj5FJ/8ffwjqQohZrz1Dm0JWheT28zKv wxu55YpvJ971AgjoRw9QoufBfQBH5RkSn42YPATa1TYwuc5Azl2hjWWKuVVaYaER eJ8DKaHbkeocSy63Ts8ew== X-ME-Sender: <xms:txCWYlDNcOBJ_u0fYkUeaq_TvSHZ5dvMmgs8zQjcn_ywSTMMI0AyxQ> <xme:txCWYjhnM9aaozDdXYQ34m4RmQ2LL8i9pj2O6BMQ2yjMrTrFhd8NufA8tlAXngtwR bP4xMJVpfRRUZ7yNA> X-ME-Received: <xmr:txCWYgmbnxE9gXzP9klfh4Nv3zUHu04LJEWcbDlEmxUSsNKPjm82bX_SUOkDPpS0lcofKF5Q7Qhaq3yqJFiY> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrkeekgdehkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:txCWYvyEbuXWj-KdqJiwFRZCJqNO2RypEZDfQ_u33dJAKzEmRZ6Ohg> <xmx:txCWYqTLHFhe2efh5gd2HIKrmyR_bsgyoMnnVST3vmh48vHVM8fLcw> <xmx:txCWYiapTteafUmGoWeDs5UcUj_XOXf3yqwyB7T0qWsanajQ6fJSMw> <xmx:txCWYofNWI45poRG1fsSGgja9txOo0LdNfKEH55IoiNLEP34ccyj6w> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 31 May 2022 08:57:26 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Jack Min <jackmin@nvidia.com> Cc: Ori Kam <orika@nvidia.com>, Ferruh Yigit <ferruh.yigit@intel.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, dev@dpdk.org Subject: Re: [RFC 2/2] ethdev: queue-based flow aged report Date: Tue, 31 May 2022 14:57:23 +0200 Message-ID: <4188686.ejJDZkT8p0@thomas> In-Reply-To: <9f20256d-002d-e5d5-d4aa-a4c84deab79f@nvidia.com> References: <cover.1649308627.git.jackmin@nvidia.com> <2183304.iZASKD2KPV@thomas> <9f20256d-002d-e5d5-d4aa-a4c84deab79f@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 31/05/2022 13:06, Jack Min: > On 5/31/22 00:42, Thomas Monjalon wrote: > > 07/04/2022 07:30, Xiaoyu Min: > >> + * If queue-based flow rule management is used and port configured with > >> + * flag RTE_FLOW_PORT_FLAG_STRICT_QUEUE, RTE_ETH_EVENT_FLOW_AGED event > >> + * is triggered with ret_param set to the corresponding flow queue when > >> + * a flow queue detects new aged-out flows. > > > > Are you sure it is a good idea to use ret_param for such data? > > Well, it seems the only way to add queue information without add/change > APIs. > > > ret_param of an event is supposed to be used by the driver > > to get a confirmation from the application. > > > > If the application needs extra info of an event, > > it is better to do a separate query like rte_flow_get_aged_flows(). > > Ok, since the *ret_param* is supposed to be used by driver, then the > above approach is not a good idea. > > So we need a new API, something like rte_flow_get_aged_event_queues(), > which will return > > all flow queues which has the aged flows, right? Yes, a new function seems required.