From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: Tal Shnaiderman <talshn@mellanox.com>, dev@dpdk.org, dev@dpdk.org
Subject: Re: [dpdk-dev] rte_vfio_container_dma_map/unmap functions
Date: Sun, 19 Apr 2020 15:09:09 +0200 [thread overview]
Message-ID: <4193388.A7TYtsqqnE@thomas> (raw)
In-Reply-To: <651f25bd-29e2-2058-70e8-59829e0b53bb@intel.com>
17/04/2020 16:09, Burakov, Anatoly:
> On 17-Apr-20 3:05 PM, Burakov, Anatoly wrote:
> > On 22-Mar-20 5:20 PM, Tal Shnaiderman wrote:
> >> Hi Anatoly,
> >>
> >> I’m working on the implementation of bus/pci driver for Windows,
> >> pci_common.c uses the titled functions however they are relevant only
> >> for Linux OS.
> >>
> >> I’m wondering if the implementation of those functions should be moved
> >> to a Linux specific area since FreeBSD (and now Windows) are forced to
> >> implemented those in the current state.
>
> Unfortunately, we don't have a generic API for these, but since we
> export a single API on all platforms, either all platforms have to
> implement these functions, or none of them do. There's simply no way to
> avoid implementing stubs for these functions, short of coming up with a
> generic API that would replace these. Given that this API is heavily
> Linux specific, i don't see that happening.
Because it is Linux specific, we should not force FreeBSD and Windows
having stubs. Can we move VFIO calls in Linux-specific files?
I think rte_vfio.h should be moved in lib/librte_eal/linux/include.
next prev parent reply other threads:[~2020-04-19 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 17:20 Tal Shnaiderman
2020-04-17 14:05 ` Burakov, Anatoly
2020-04-17 14:09 ` Burakov, Anatoly
2020-04-19 13:09 ` Thomas Monjalon [this message]
2020-04-19 13:10 ` Thomas Monjalon
2020-04-20 14:07 ` Burakov, Anatoly
2020-04-20 17:39 ` Thomas Monjalon
2020-04-21 9:50 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4193388.A7TYtsqqnE@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=talshn@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).