From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 8F563595B for ; Tue, 18 Nov 2014 14:33:47 +0100 (CET) Received: by mail-wg0-f46.google.com with SMTP id x13so27839707wgg.5 for ; Tue, 18 Nov 2014 05:44:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=3dXvTZ0J0KoESR3iqw3SDejbJRqVMrx4W0qDeyDCzag=; b=KeYNZAo9c/eIOBNxoEEbuxAVDQDcxczrLy2o19yfqyFK9V/Bi9SHbSaoHNV1aq58cu FSiu2tkHRyfAfsIuSnPUeBp/X9gPL0cOxVrGdxGJ7CJHfA9KcFfMEJdMFIeYZsCqSgzH wqDET/A4ft/WiwFZgxRsBJI04UucjdNB7za/lVEm+Zj0bAlGKUNPWbujKyPBxN38QDOf DVrJiTHxTKXpHC5+i5YXLHp0Nc1ri+1EbDmJ4XRp119QoddwcnSVAGMnyMOpDy351TPO 1g9SjgNQIbrJ1fn7h4QkloM9P86e/iJrr28tLS/NlrF3fka2i96mZHEU5XUi+8xTHd99 E0kg== X-Gm-Message-State: ALoCoQnIVeAsJtf9uCaZpOihTDFk7IVlV/Kfni6QTBH2VmC2FZejlrXeEF4dtG1SL7Cw5Wq0zqAP X-Received: by 10.180.90.45 with SMTP id bt13mr38999069wib.75.1416318248686; Tue, 18 Nov 2014 05:44:08 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id mu4sm19609611wib.2.2014.11.18.05.43.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Nov 2014 05:43:57 -0800 (PST) From: Thomas Monjalon To: dev@dpdk.org Date: Tue, 18 Nov 2014 14:43:37 +0100 Message-ID: <4195462.uvHhYJc7eD@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <20141118133307.GA32375@hmsreliant.think-freely.org> References: <1416160760-16087-1-git-send-email-e_zhumabekov@sts.kz> <546AD178.9070109@sts.kz> <20141118133307.GA32375@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 3/5] hash: add fallback to software CRC32 implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2014 13:33:47 -0000 2014-11-18 08:33, Neil Horman: > On Tue, Nov 18, 2014 at 10:56:24AM +0600, Yerden Zhumabekov wrote: > > Sorry, maybe I made a mistake here. > > > > Accoring to lib/librte_eal/common/eal_common_cpuflags.c code, it seemed > > to me that constructor attribute is not supported by intel compiler. So > > in that case here I decided to leave the code for autodetection. Am I > > correct? > > I don't think thats correct. The Intel Compiler claims support for most GCC > features, except where explicitly stated in the release notes, and I don't find > any documentation clearly excepting the constructor attribute from that list. > That said, since the intel compiler isn't open, I don't have access to it and > cannot confirm either way, though if its the case, the DPDK has a major issue, > as __attribute__((constructor)) is used extensively throughout the code The comment of rte_cpu_check_supported() is: "with ICC, the check is generated by the compiler" So in my understanding, the constructor attribute is not set because this function isn't needed for ICC. I'd like to see an explanation of how CPU flags are set by ICC. -- Thomas