From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0079.outbound.protection.outlook.com [104.47.42.79]) by dpdk.org (Postfix) with ESMTP id 8E460A84C for ; Wed, 17 Jan 2018 11:52:57 +0100 (CET) Received: from BN3PR03CA0085.namprd03.prod.outlook.com (10.167.1.173) by CY1PR03MB2362.namprd03.prod.outlook.com (10.166.207.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Wed, 17 Jan 2018 10:52:56 +0000 Received: from BN1BFFO11FD034.protection.gbl (2a01:111:f400:7c10::1:189) by BN3PR03CA0085.outlook.office365.com (2a01:111:e400:7a4d::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.407.7 via Frontend Transport; Wed, 17 Jan 2018 10:52:55 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD034.mail.protection.outlook.com (10.58.144.97) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.345.12 via Frontend Transport; Wed, 17 Jan 2018 10:52:55 +0000 Received: from [10.232.134.49] ([10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w0HAqpXU014239; Wed, 17 Jan 2018 03:52:52 -0700 To: "Gujjar, Abhinandan S" , "De Lara Guarch, Pablo" , "Doherty, Declan" , "Jacob, Jerin" CC: "dev@dpdk.org" , "Vangati, Narender" , "Rao, Nikhil" References: <1516017078-166766-1-git-send-email-abhinandan.gujjar@intel.com> <5612CB344B05EE4F95FC5B729939F780705FED56@PGSMSX102.gar.corp.intel.com> <5612CB344B05EE4F95FC5B729939F780705FEDDD@PGSMSX102.gar.corp.intel.com> <5612CB344B05EE4F95FC5B729939F780705FEF35@PGSMSX102.gar.corp.intel.com> <5612CB344B05EE4F95FC5B729939F78070600131@PGSMSX102.gar.corp.intel.com> <0ed584fb-3524-0a52-44a4-a2b1759ecfff@nxp.com> <5612CB344B05EE4F95FC5B729939F7807060021A@PGSMSX102.gar.corp.intel.com> <1a5be561-5b9c-ae8d-e5a2-d2801973d125@nxp.com> <5612CB344B05EE4F95FC5B729939F780706009F3@PGSMSX102.gar.corp.intel.com> <5612CB344B05EE4F95FC5B729939F78070600B56@PGSMSX102.gar.corp.intel.com> From: Akhil Goyal Message-ID: <41967568-8501-b9da-95bc-6072cfa8a210@nxp.com> Date: Wed, 17 Jan 2018 16:22:50 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <5612CB344B05EE4F95FC5B729939F78070600B56@PGSMSX102.gar.corp.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131606599752394896; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(7966004)(346002)(376002)(39380400002)(396003)(39860400002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(13464003)(199004)(189003)(24454002)(50466002)(77096006)(2950100002)(53546011)(36756003)(64126003)(59450400001)(54906003)(6246003)(58126008)(31696002)(53936002)(97736004)(305945005)(2906002)(110136005)(65806001)(65956001)(229853002)(93886005)(4326008)(85426001)(86362001)(5660300001)(65826007)(104016004)(83506002)(105606002)(230700001)(67846002)(316002)(2486003)(47776003)(8676002)(76176011)(356003)(106466001)(31686004)(81166006)(8936002)(81156014)(68736007)(26005)(23676004)(508600001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2362; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD034; 1:qIMC1RloZUEWdQYbAiP5+dMvsH+teRMAt8LJkwwKoGA2nl9umDiMOXouG+WM9FB7BNL4AuwTTCBg574R8Kv0eXXycwEqOkiqTm43wicm6jQcdC0bDFRYQokpTOhj0uvY X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e9c51cf8-b72c-49b1-a890-08d55d9876cd X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(5600026)(4604075)(2017052603307); SRVR:CY1PR03MB2362; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2362; 3:d2plbzXEIKlPL98OUPxbeH64ItY5yybec9Lo6w7nkNuKXfZ24KBwp0V8Q0Ww7Q1jTLDd0GtBRuAIv+yBNnhtGrBclsHACox/+76ASvjlBRsz08fyi46pAmWB5JVne2br35nc7YKsJSPq9E/hSJk2khkXbmo1TDo9jt3HCruf+7/PMKMGonb21Qk419J9k6jD7JsiQ4daa6BHjsK/7SzthXlRXF4C0dAlHovts0JyrpwsMlyr0ISjHx/En1LakfexhNPxgpwIrgjhaJb7Fo5a7rXFY6Ix5gb+PykOHdme877S/nHJ7DbB8es2KVHdvHT+sfmi3ice+KVCCgAvdlfh/Z0Ghf1QZnos5rWJqMRExxI=; 25:xjT48P5F+I2dV3iPXUpsG5GYgD8r2nmLdJcC29wWR+xy8pO3kPwJrbSAfFrFP7xk6WA5xVbo0fc61X/r7Qzof46uYwKZJHh6mws6YzQVtxeAvIX4SUKrUNHUD5r5j9UKiGLy9NlZn07908+tvZOLUULMynxPB1gfNo3XpxpT4+yg+GX7Ipgq6R4Fwm95x1Y0iceyXHeD/X/ydMnQQRbRTkKUCIlTnw1yZ5DaUe5qs1ASufdrTUQ1BZiL7ZfLe3SMnN5JLcDAH5rVj/7hizGJl/h4Vd68r2RN7KsbiW7DdRn/UzVc3MzlWy/E+OUMbSBW2N4HCAjm7kXCXLoiS2kazA== X-MS-TrafficTypeDiagnostic: CY1PR03MB2362: X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2362; 31:0KJPGqqLwmQj7YesulymSyhwe1FM6zR+KcUXBbiesnB1z3bX0uJ75Tbr0H62v+JKZcDmDMPWAEkk/RW5wYFJOSBeMqEMITMSiTDWkYRDEz/RRbDPTy+JGC3NklVhCUqi5VHL1bDN/+EeS9Ep8jIiRqLdQ35c0arHlLUoXgckAZ+zZxsqz9cBjsJTMdCXZ/HFt8ZwbpqRwho5OSjgDLB7ZuwHPp+5OoL4dOPl3oKjbY4=; 4:CTg4ONpj0XRWc8VF3cf4kbiRXw6YWw/5pXikqID+tINj+7uQUpFSqdcB781VIktzPxesZGP7EFopbGxhBiq0rnI7bLQ+8dnxP4iEpxEK1J6vp1Nfdq5gSyGEVG4ISwvJ1wruku7vQQWN68+B84qV9WQem4jID/ugUTwuEw3nUdWdG8juI/fG1XktrjMUcnK84MQCfWYd1Rtyqbb+N7T6tcwKHPgI2L+c+OBSnwpfCfquNMQVygDqZ5c7w8b1dGI0LmuFsww6USKpw7GAQk22khQR7qGpzkgxvGusultg+/3jfCss7cYMIkXFnAZyie9pGhUnrDURUpmNenZy2lM7FYmD19hyX9fv5I+8t4FWKv0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231023)(944501161)(6055026)(6096035)(20161123556025)(20161123563025)(20161123559100)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(20161123565025)(20161123561025)(201708071742011); SRVR:CY1PR03MB2362; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:CY1PR03MB2362; X-Forefront-PRVS: 0555EC8317 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIyMzYyOzIzOlFsb2dGaHJNeWF2dDRuMHJPeHF0UDduemdO?= =?utf-8?B?OUMzWkVyTFZYOGEvamFScVlsQkVWVGk5RFFhVThJQk0yMHI4dGlmN0ozZ1l4?= =?utf-8?B?akYrTWRtNzlKMWdnMWRtYlNMb0ZqUE0wYjZWWXBtbVoySUo0MzErK1d1QnJt?= =?utf-8?B?T0lWUmloSXhFSDdJbldHQ0V1b2MwS2JCM2Q2SUhTMXg4TjlocEhpM2hmeDZn?= =?utf-8?B?TEJZaDFVWTBPN2ZJS2ZpZHVxbTNibnVxUloxd2R2ZWFuT1ZraWs1eVdicDNS?= =?utf-8?B?TW5TeEwwOWtaY0M0Zm5YTjlldERPSGhzMXZWcEJSeUtqU2RSUmEvMEZaMXJU?= =?utf-8?B?Z3JwdnlTTUZlNTZ5TmM4STJlOU5xK0duS0tpR1B1MXZudCsrN2hSV0IyMFU0?= =?utf-8?B?aVFCZm5RYjdqR09SbUx2d1ZZTmZCeWFPN2dGeHQ2cGdjWXNROTFPYis3bG85?= =?utf-8?B?WjNNSlYwd3J2OGlRdWEwYjFScDhiRnFDTXhmNEMrbTBPZGVYM1E4L3RQRzhP?= =?utf-8?B?RC8xYVp4bHdFUHpINHhTSWJJNHlpMXE3cnJINjN2UWYyTkg4a2MvSVN4Q2kz?= =?utf-8?B?SjloY3BtZTZkaGNhVFZOYjZGeEZRQzRWalk2MzNLcm1sSno1NGFwWVFJalcw?= =?utf-8?B?d2kxS0hmN2ErZ1g3WjhWSkd2UGJkbnQ2SzRYY2ZiaUVhY1lVWlA4WXZpcjRI?= =?utf-8?B?N3c4MU5sWFUwajdOaklzdU9IQVE2WnZWZUVLbTRSUGFaekx5VnhBSzRiVVln?= =?utf-8?B?ZXMrcWMyZmpObktXNlE3R0N2and2MERHU25iVHlOMHhCdVRBWHNCL3V5QUoz?= =?utf-8?B?QW1XM29mN2dOOW00R2JmL3JJYk9aNkw3aG82MGhoMnczMWQ3ck1OSnNwU2V1?= =?utf-8?B?RVFVMlpwQ3daelBYQ21EMC93VFYwUUo0Q05reE1HdC9XNHhadzI1Z2ZZamts?= =?utf-8?B?RFJsd2Nsa2RKSDdBN3lMSmRINUwzNmRCWExzeHp5K3VXWmgzWUZqNXNkQ2VF?= =?utf-8?B?eTlyZElQR2xISWphSUp1dHNWM1lqdjdpbmR2MVFQWUl2anhEdkNFRkY4ZFlh?= =?utf-8?B?Y1R1QW1rUU1CTzFjVDFZMW5xU3hCR2hUNEFLTkdzZ3pMK3hxckoyYWl3Ritj?= =?utf-8?B?OWQ1QjI2ZlU4cko3T0ZUN1BYeHN4cWxmcTlhYWlqWEZid2FJaWh0VmIzWU5F?= =?utf-8?B?NVM2Wnl1aDhrdk5BelFJbDB1bnJlR08rR3lBZ2NDdjN1MHdJdVJ2M0dDOVVi?= =?utf-8?B?QmJPVWlTZ2R6aHBaM25JRnZBVEZuM0lKcmRmcHQ1TlRHYkt1QWxKaWRiZ2dE?= =?utf-8?B?eXF2cy9BN1hsRlJkMGxlcHpCVk9qMVdnZi9hMU5uOVliRlAvdGhaT01TeUhx?= =?utf-8?B?ZDJRMzJodjNkZ1V0V1VWdDFJelVQVzI3b1ZCYjJYRVVVSENNODlSVkdRenlo?= =?utf-8?B?QU42RXFZRkVUaXNIdlpkbkVsMXViZjBQZXh1QU80UWVOTUtKeWduUjJoOFFX?= =?utf-8?B?ZlRtV3VkT1FtaWtacDdiTzRZRnloTktpeC9EdStoRjFTYnJFNVc0OUFJcU53?= =?utf-8?B?UnlxTERhL2FVbkxxM0tBM1NSeEEzRXJNYVM4OXd6NWQ1bjhGR1JEUERFazRo?= =?utf-8?B?am85OEYrOUtURy8wU1AwTUEyc1BrTi85cE9BdjY0UnREWjd4bFFIaHV4Z1E4?= =?utf-8?B?b3dTOXkrU29iTXEweVo5dW4zTHdmNDVEU2FTZjN5b3V6bVlVM1RCcmpoWjJW?= =?utf-8?B?VjVGRkY2bVdyaWgzN1V3T29Ha0h4dXo3djJzQytHaDNDUU1sZC9LQkdxdG9Q?= =?utf-8?B?bjc4YzdZSmc2VDJNVjR3eDJ6NWFMaS92UVA2V2tMczRGTFNvLzlEVzRYK2FD?= =?utf-8?Q?uSvbzBLXFW076rgZKQSYOOl+zv38dwM2?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2362; 6:rJVYzJsU97V3Zxnmx4PkEKBpYzpYmkvo3GgK6TNQUF3q13+t5rMH91Ifl4OJ3cjn7rD5AGtRFLtFKfMQFOWpwnvs26p9MGVSf1NM9ZL8T4Nd7cYeZLoGVIiY9KYWal+z6Zt7e3YCAOzMLum05daWrFrw4t/QBMyAMAr0TqRAiV/CyqEMhrXnO9tEkGFHUnCi6/E9Xv/EtXFZpAge7dSjHASC2VhuZjDNtHLays4K7DZd8Me3LgElPzjJTbN+tO84eUYGmC3tQGmVrN29k/VOSathaQFZ8BwVVcHPf1WwO9P57m56VKTFWojfvXFltHDzladywkk11vU4EWgp5nUSAoG0l1MjQ0VYU+RCSjwcXfI=; 5:qrcbb60VVBUxvET2KtOm/MerOewy7+wW0Ml93/gcW/tqav+68HtZ0D2TPdWw2QHZerO+4NyJFR5nl4DTbP31yyJErTS3HV2nNnVk4UbNLFN/cZZX6QUlRTpJvfvLRB5bek2cA0ktXkXrBeOlz2N26xgGj78Jw6BCvCeChy84ynU=; 24:pEfQ1KKhAVYz6ulBotsspuTJgXnk62yYuls0EAsm4k8EnwgqucTdqdbf0Uv0tt6lAOih/9xhH4xuU9kINsDJ10EYXNW0+VVILc5twsE6EkQ=; 7:A7F2uERty1f4YibDFpko/wo+lwXEtGq1Y4Rh+7snV3INsrHV72Mr/rKvyR83AUsEcqh+vyjTiBfv/5ULY/0HBjyRnQTwJUqWVLR/oVk1jEVOaglUhvdhH4E0yGj+AgTL1DzjPkScl8LYg4VsPac5M/dA6R/wZm3EJCya7QfKVdSyf3uvlKSBiVrFE74Mtb+emOAIQBQyttgmB4YHfMuAECraUWChVFy2p5f/mmlHHJRtZsWhzaKI/sX48ckpv7oa SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2018 10:52:55.0210 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9c51cf8-b72c-49b1-a890-08d55d9876cd X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2362 Subject: Re: [dpdk-dev] [PATCH 1/2] lib/cryptodev: add support to set session private data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 10:52:58 -0000 Hi Abhinandan, On 1/17/2018 3:35 PM, Gujjar, Abhinandan S wrote: > Hi Akhil, > >> -----Original Message----- >> From: De Lara Guarch, Pablo >> Sent: Wednesday, January 17, 2018 3:16 PM >> To: Gujjar, Abhinandan S ; Akhil Goyal >> ; Doherty, Declan ; Jacob, >> Jerin >> Cc: dev@dpdk.org; Vangati, Narender ; Rao, >> Nikhil >> Subject: RE: [PATCH 1/2] lib/cryptodev: add support to set session private data >> >> Hi Abhinandan, >> >>> -----Original Message----- >>> From: Gujjar, Abhinandan S >>> Sent: Wednesday, January 17, 2018 6:35 AM >>> To: Akhil Goyal ; Doherty, Declan >>> ; De Lara Guarch, Pablo >>> ; Jacob, Jerin >>> >>> Cc: dev@dpdk.org; Vangati, Narender ; Rao, >>> Nikhil >>> Subject: RE: [PATCH 1/2] lib/cryptodev: add support to set session >>> private data >>> >>> Hi Akhil, >>> >> >> ... >> >>> I guess, you are suggesting below changes: >>> diff --git a/lib/librte_cryptodev/rte_cryptodev.h >>> b/lib/librte_cryptodev/rte_cryptodev.h >>> index 56958a6..057c39a 100644 >>> --- a/lib/librte_cryptodev/rte_cryptodev.h >>> +++ b/lib/librte_cryptodev/rte_cryptodev.h >>> @@ -892,6 +892,8 @@ struct rte_cryptodev_data { >>> >>> /** Cryptodev symmetric crypto session */ struct >>> rte_cryptodev_sym_session { >>> + uint16_t private_data_offset; >>> + /**< Private data offset */ >>> __extension__ void *sess_private_data[0]; >>> /**< Private session material */ }; I am ok with this. >>> >>> Declan/Pablo, >>> Is this ok? Do you see any impact on performance or anything else has >>> to be considered? >> >> This is breaking ABI, and since there is a zero length array, this latter has to be at >> the end of the structure. >> Therefore, this is not a valid option unless ABI deprecation is announced and >> then it could be merged in the next release. > What is your opinion on this? > Should we consider retaining the enum rte_crypto_op_private_data_type? As per our previous discussion we are anyway pushing crypto adapter to next release, then we do have time for the deprecation notice to be sent. Or you can reserve the first byte of private data (internal to library) in the session to check whether the private data is valid or not. IMO, private data offset in session is a better approach instead of adding one more enum. Others can suggest. -Akhil >> >> Pablo > Abhinandan >