From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5D8785F19 for ; Wed, 7 Mar 2018 11:00:08 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7FB6020DFB; Wed, 7 Mar 2018 05:00:07 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 07 Mar 2018 05:00:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=ETJv4EQXWwfsl9n5cLPHLoM6g1 BxC30p42fLR6bNPjE=; b=eQPoSRkCEyz0q3ENCCiMw2kkIBS1kygVknW1I8QqV5 kosqPCClKncx9cY2nv4m+D24vixoqbtjxPQlDKhmJOnXTOmuh74XgSl78jxCnB1D 1YRjQYaphNt6XLeX3XL71Rv3sodqwIf832HLWhNQT8I1AH6d9dJxPgaQC+kYoOfk g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ETJv4E QXWwfsl9n5cLPHLoM6g1BxC30p42fLR6bNPjE=; b=N6klKVx1wojzACLeMwB6dA SX9VTc9vR6KkJOPHJ7zSVjZ6ZxXjL4Q6tTsuVkHp2XkWaMqYhXsFDQMDwEZNzw0l JBoBc19XMJnqq7cvuBFL8KBgE0gkpAYNGsqXTHHReeubQZI53Ilv5nf82n+G3jAc TWewZpIShnczoZghBBc632A1AWs3BeP7wtPgfr7PYISoy/Pudn5PSLnHMpGE32Xf v6f8XOJEGbYJLRF+lBa0EYecWZR15lDmMEHTDAZpACNZc0bw/ENVhv0rnSYkbQsL gU66AvV7oedjw3S575dYUd+aEvJannwo37Om4a0nyc82WnaFdizjhm0Ua8C2KiDA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D5C197E660; Wed, 7 Mar 2018 05:00:06 -0500 (EST) From: Thomas Monjalon To: "Burakov, Anatoly" , Arnon Warshavsky Cc: bruce.richardson@intel.com, dev@dpdk.org Date: Wed, 07 Mar 2018 10:59:52 +0100 Message-ID: <4197355.YAsZy1EAlL@xps> In-Reply-To: References: <1520360928-9375-1-git-send-email-arnon@qwilt.com> <304114136.g7uiPYdxRp@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: register rte_panic user callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 10:00:08 -0000 07/03/2018 10:05, Burakov, Anatoly: > On 07-Mar-18 8:32 AM, Thomas Monjalon wrote: > > Hi, > > > > 06/03/2018 19:28, Arnon Warshavsky: > >> The use case addressed here is dpdk environment init > >> aborting the process due to panic, > >> preventing the calling process from running its own tear-down actions. > > > > Thank you for working on this long standing issue. > > > >> A preferred, though ABI breaking solution would be > >> to have the environment init always return a value > >> rather than abort upon distress. > > > > Yes, it is the preferred solution. > > We should not use exit (panic & co) inside a library. > > It is important enough to break the API. > > +1, panic exists mostly for historical reasons AFAIK. it's a pity i > didn't think of it at the time of submitting the memory hotplug RFC, > because i now hit the same issue with the v1 - we might panic while > holding a lock, and didn't realize that it was an API break to change > this behavior. > > Can this really go into current release without deprecation notices? If such an exception is done, it must be approved by the technical board. We need to check few criterias: - which functions need to be changed - how the application is impacted - what is the urgency If a panic is removed and the application is not already checking some error code, the execution will continue without considering the error. Some rte_panic could be probably removed without any impact on applications. Some rte_panic could wait for 18.08 with a notice in 18.05. If some rte_panic cannot wait, it must be discussed specifically.