From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id C56DFA04DC;
Mon, 26 Oct 2020 15:39:46 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 6D65429C6;
Mon, 26 Oct 2020 15:39:44 +0100 (CET)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id EE4BB1E2B
for <dev@dpdk.org>; Mon, 26 Oct 2020 15:39:42 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.nyi.internal (Postfix) with ESMTP id 8FF195C016A;
Mon, 26 Oct 2020 10:39:41 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute2.internal (MEProxy); Mon, 26 Oct 2020 10:39:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm2; bh=
6ampaebkN833YNhAROAMT/9WBsufy4ixRvKtzFiSQiQ=; b=Wh0lAav+t6JzYOxS
+0j2nNPO/1Jjdum5PXEw9lavocaaTXvcTXbD3FrQ7UxzUE6VvfZXd/XpAIFCxkHG
xFo+YByn/LQwW/6gT7xuUH3lHOGvHAiqoMUOsN4Af50k1gYWTf3rc0C8xvHCEPsY
Zm84Y5fIDHr4TwZ0Mgu8hbwLIgx44pdSUOPnQt2ik8N58wCxWzll0217KkKug7Rs
EUlIhDJWYvNMYzUp/GxuEAKul5KPgVF5jPeZUHiGS2VO4h8/ZwTt/6zFzWkLgbBb
+9TNWCp7jcVKHiXm7TvGGJbCFUEkZkiWdz/ooIImh0fdkX1UQbue599gvKEtgmRQ
Th5McQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=6ampaebkN833YNhAROAMT/9WBsufy4ixRvKtzFiSQ
iQ=; b=SYuwE7pL10rCGV2SEesrVEiZRbgCWPaNgjNd7QXqghSnKZSkGt5Oo/WEH
hk3JLDZT4nRKlmGtTSNhmXV+0a00ZirDGAz2UHntfNocvNypQ9LHijC+Kk6Hsvh9
luYtqy53DozFxdll418LOdtZwGhjOxNzXyc4mJJEkR7uVxEG+9kqa2HXgKl5Hb7H
Kld39VmxKR6zaffq1zgyIB00KMR5RnJi/bmOhuI7ITLhpX6OfTWfGG71Jblg7bDK
+zAaS3+T8cPQ35gmGkIMUjJGLHxsNoMpUc+LlCzn/gnDIFwwceuPfdIliStJ2Qyj
djrH3vpA951gvRTODG3BbIJTImd+w==
X-ME-Sender: <xms:rN-WX4TYWQ_Epu4zEMAQyZHOyqekz5jFFVHRT2npSECLnoyTviwsrw>
<xme:rN-WX1zkbZv4kh8IDfDXpskL_-HnUkcHoJKgjiNO3D0nN19A9gI7xLus7JWn0_7kH
V-m6Psz75mbxjZXKw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrkeejgdeftdcutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei
iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih
iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho
nhdrnhgvth
X-ME-Proxy: <xmx:rN-WX107JS1uE8YBjSRuVMxKHsCL_5iV8PsFhE2gyxf7ScGZXWb8sQ>
<xmx:rN-WX8BAz1BSLF6MVLusKU5co_oANBt3pM4BOct4vtvr9qLIYVGDvQ>
<xmx:rN-WXxjWrgnnn8paO0fxsuH7dgZsFBUEYPiL4DN3iKxiTJvTqfeMQg>
<xmx:rd-WX8VmvuCoMIrAEQncqN5kqfixOr9ahq5IyKgQmlCfB1mgOaCMkQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id A31B73280063;
Mon, 26 Oct 2020 10:39:39 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Olivier Matz <olivier.matz@6wind.com>, Akhil Goyal <akhil.goyal@nxp.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>
Date: Mon, 26 Oct 2020 15:39:38 +0100
Message-ID: <4199362.2Ip9WNS56G@thomas>
In-Reply-To: <cd66df20-ac89-3e12-0654-9f960e293ed9@oktetlabs.ru>
References: <20201026052105.1561859-1-thomas@monjalon.net>
<2911701.ZJlzt3N5jF@thomas>
<cd66df20-ac89-3e12-0654-9f960e293ed9@oktetlabs.ru>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 04/15] node: switch IPv4 metadata to dynamic
mbuf field
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
26/10/2020 15:34, Andrew Rybchenko:
> On 10/26/20 5:29 PM, Thomas Monjalon wrote:
> > 26/10/2020 11:40, David Marchand:
> >> On Mon, Oct 26, 2020 at 6:21 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >>> + node_mbuf_priv1_dynfield_offset = rte_mbuf_dynfield_register(
> >>> + &node_mbuf_priv1_dynfield_desc);
> >>> + if (node_mbuf_priv1_dynfield_offset < 0)
> >>> + return -1;
> >>
> >> How about return -rte_errno like what is done in setup_lpm()?
> >
> > Yes, looks better
> >
> > [...]
> >>> +static const struct rte_mbuf_dynfield node_mbuf_priv1_dynfield_desc = {
> >>> + .name = "rte_node_dynfield_priv1",
> >>> + .size = sizeof(uint64_t),
> >>> + .align = __alignof__(uint64_t),
> >>
> >> s/uint64_t/struct node_mbuf_priv1/g ?
> >
> > Yes will do
> >
>
> Just to be sure - "struct node_mbuf_priv1 *"
Yes, pointer to node_mbuf_priv1.