From: Ferruh Yigit <ferruh.yigit@intel.com>
To: SteveX Yang <stevex.yang@intel.com>,
dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Cc: bruce.richardson@intel.com, wenzhuo.lu@intel.com,
beilei.xing@intel.com, qiming.yang@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] app/test-pmd: fix meson build failed when used latency stats lib
Date: Wed, 30 Sep 2020 17:25:53 +0100 [thread overview]
Message-ID: <41a7a830-ae0b-7f46-5ad8-aa5d38219578@intel.com> (raw)
In-Reply-To: <20200915020836.18396-1-stevex.yang@intel.com>
On 9/15/2020 3:08 AM, SteveX Yang wrote:
> meson build cannot find the header rte_latencystats.h when build DPDK
> first time or never installed DPDK lib after build via meson/ninja.
>
> Because the corresponding header directory isn't included after enabled
> RTE_LIBRTE_LATENCY_STATS flag.
>
> Add the lib 'latencystats' to deps of meson.build of test-pmd, the
> corresponding header files will be included automatically.
>
> Fixes: 62d3216d6194 ("app/testpmd: add latency statistics calculation")
>
> Signed-off-by: SteveX Yang <stevex.yang@intel.com>
> ---
> v2:
> removed long cflags and added 'latencystats' as a dependency of testpmd
The code has 'RTE_LIBRTE_LATENCY_STATS' which needs to be updated.
But I see Bruce is working on a more generic solution:
https://patches.dpdk.org/project/dpdk/list/?series=12283
I will mark this one as superseded and will wait the Bruce's set for fix.
prev parent reply other threads:[~2020-09-30 16:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 2:20 [dpdk-dev] [PATCH v1] " SteveX Yang
2020-09-10 9:23 ` Bruce Richardson
[not found] ` <DM6PR11MB4362CE65DBD5BA111A43A0FAF9230@DM6PR11MB4362.namprd11.prod.outlook.com>
2020-09-14 8:34 ` Bruce Richardson
2020-09-15 2:08 ` [dpdk-dev] [PATCH v2] " SteveX Yang
2020-09-30 16:25 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41a7a830-ae0b-7f46-5ad8-aa5d38219578@intel.com \
--to=ferruh.yigit@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=stevex.yang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).