From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 494CB4604C; Thu, 16 Jan 2025 10:35:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3588140651; Thu, 16 Jan 2025 10:35:36 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id B9FA04064F for <dev@dpdk.org>; Thu, 16 Jan 2025 10:35:34 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4YYd1n4mswz11SXq; Thu, 16 Jan 2025 17:32:29 +0800 (CST) Received: from dggemv711-chm.china.huawei.com (unknown [10.1.198.66]) by mail.maildlp.com (Postfix) with ESMTPS id 18EE51400CD; Thu, 16 Jan 2025 17:35:33 +0800 (CST) Received: from kwepemn100009.china.huawei.com (7.202.194.112) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 16 Jan 2025 17:35:32 +0800 Received: from [10.67.121.59] (10.67.121.59) by kwepemn100009.china.huawei.com (7.202.194.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 16 Jan 2025 17:35:32 +0800 Message-ID: <41acccf6-ac6f-94ad-8e11-4fc4cd47f221@huawei.com> Date: Thu, 16 Jan 2025 17:35:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v1 2/2] ethdev: fix some APIs can be used in the new event To: Thomas Monjalon <thomas@monjalon.net> CC: <stephen@networkplumber.org>, <liuyonglong@huawei.com>, <dev@dpdk.org> References: <20250115034110.15245-1-lihuisong@huawei.com> <1837683.3VsfAaAtOV@thomas> <4080a156-3031-fbb6-e7b9-fc511c398a87@huawei.com> <2673930.7s5MMGUR32@thomas> From: "lihuisong (C)" <lihuisong@huawei.com> In-Reply-To: <2673930.7s5MMGUR32@thomas> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemn100009.china.huawei.com (7.202.194.112) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 在 2025/1/16 17:09, Thomas Monjalon 写道: > 16/01/2025 07:14, lihuisong (C): >> 在 2025/1/15 19:36, Thomas Monjalon 写道: >>> 15/01/2025 04:41, Huisong Li: >>>> The rte_eth_dev_socket_id() and rte_eth_dev_owner_*() can be used after >>>> allocating an ethdev. So this patch relaxes the conditions for using them. >>> You should be more explicit: >>> "during probing, before it becomes generally available and considered as valid". >> "During probing, before the port becomes generally available, its socket >> id and owner id can be considered as valid." >> How about say it like this? > I prefer when you give the function names, it is more explicit. ok > > > > .