Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 5/8/2018 11:05 AM, Wei Dai wrote:
> This patch check if a input requested offloading is valid or not.
> Any reuqested offloading must be supported in the device capabilities.
> Any offloading is disabled by default if it is not set in the parameter
> dev_conf->[rt]xmode.offloads to rte_eth_dev_configure( ) and
> [rt]x_conf->offloads to rte_eth_[rt]x_queue_setup( ).
> If any offloading is enabled in rte_eth_dev_configure( ) by application,
> it is enabled on all queues no matter whether it is per-queue or
> per-port type and no matter whether it is set or cleared in
> [rt]x_conf->offloads to rte_eth_[rt]x_queue_setup( ).
> If a per-queue offloading hasn't be enabled in rte_eth_dev_configure( ),
> it can be enabled or disabled for individual queue in
> ret_eth_[rt]x_queue_setup( ).
> A new added offloading is the one which hasn't been enabled in
> rte_eth_dev_configure( ) and is reuqested to be enabled in
> rte_eth_[rt]x_queue_setup( ), it must be per-queue type,
> otherwise return error.
> The underlying PMD must be aware that the requested offloadings
> to PMD specific queue_setup( ) function only carries those
> new added offloadings of per-queue type.
> 
> This patch can make above such checking in a common way in rte_ethdev
> layer to avoid same checking in underlying PMD.
> 
> This patch assumes that all PMDs in 18.05-rc2 have already
> converted to offload API defined in 17.11 . It also assumes
> that all PMDs can return correct offloading capabilities
> in rte_eth_dev_infos_get( ).
> 
> In the beginning of [rt]x_queue_setup( ) of underlying PMD,
> add offloads = [rt]xconf->offloads |
> dev->data->dev_conf.[rt]xmode.offloads; to keep same as offload API
> defined in 17.11 to avoid upper application broken due to offload
> API change.
> PMD can use the info that input [rt]xconf->offloads only carry
> the new added per-queue offloads to do some optimization or some
> code change on base of this patch.
> 
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> ---
> v8:
> Revise PMD codes to comply with offload API in v7
> update document
> 
> v7:
> Give the maximum freedom for upper application,
> only minimal checking is performed in ethdev layer.
> Only requested specific pure per-queue offloadings are input
> to underlying PMD.
> 
> v6:
> No need enable an offload in queue_setup( ) if it has already
> been enabled in dev_configure( )
> 
> v5:
> keep offload settings sent to PMD same as those from application
> 
> v4:
> fix a wrong description in git log message.
> 
> v3:
> rework according to dicision of offloading API in community
> 
> v2:
> add offloads checking in rte_eth_dev_configure( ).
> check if a requested offloading is supported.
> ---
>  doc/guides/prog_guide/poll_mode_drv.rst |  26 +++--
>  doc/guides/rel_notes/release_18_05.rst  |   8 ++
>  drivers/net/avf/avf_rxtx.c              |   5 +-
>  drivers/net/bnxt/bnxt_ethdev.c          |  17 ----
>  drivers/net/cxgbe/cxgbe_ethdev.c        |  50 +---------
>  drivers/net/dpaa/dpaa_ethdev.c          |  16 ----
>  drivers/net/dpaa2/dpaa2_ethdev.c        |  16 ----
>  drivers/net/e1000/em_ethdev.c           |  19 ----
>  drivers/net/e1000/em_rxtx.c             |  64 ++-----------
>  drivers/net/e1000/igb_rxtx.c            |  64 ++-----------
>  drivers/net/ena/ena_ethdev.c            |  65 +------------
>  drivers/net/failsafe/failsafe_ops.c     |  81 ----------------
>  drivers/net/fm10k/fm10k_ethdev.c        |  82 ++--------------
>  drivers/net/i40e/i40e_rxtx.c            |  58 ++----------
>  drivers/net/ixgbe/ixgbe_ethdev.c        |  38 --------
>  drivers/net/ixgbe/ixgbe_rxtx.c          |  66 ++-----------
>  drivers/net/mlx4/mlx4_rxq.c             |  43 ++-------
>  drivers/net/mlx4/mlx4_txq.c             |  42 ++------
>  drivers/net/mlx5/mlx5_ethdev.c          |  22 -----
>  drivers/net/mlx5/mlx5_rxq.c             |  50 ++--------
>  drivers/net/mlx5/mlx5_txq.c             |  44 +--------
>  drivers/net/mvpp2/mrvl_ethdev.c         |  97 +------------------
>  drivers/net/nfp/nfp_net.c               | 163 --------------------------------
>  drivers/net/octeontx/octeontx_ethdev.c  |  72 +-------------
>  drivers/net/sfc/sfc_ethdev.c            |   9 +-
>  drivers/net/sfc/sfc_rx.c                |  42 ++------
>  drivers/net/sfc/sfc_rx.h                |   3 +-
>  drivers/net/sfc/sfc_tx.c                |  42 ++------
>  drivers/net/sfc/sfc_tx.h                |   3 +-
>  drivers/net/tap/rte_eth_tap.c           |  88 ++---------------
>  drivers/net/thunderx/nicvf_ethdev.c     |  70 ++------------
>  drivers/net/virtio/virtio_rxtx.c        |   9 +-
>  drivers/net/vmxnet3/vmxnet3_ethdev.c    |  16 ----
>  drivers/net/vmxnet3/vmxnet3_rxtx.c      |   8 +-
>  lib/librte_ethdev/rte_ethdev.c          |  88 +++++++++++++++++
>  35 files changed, 240 insertions(+), 1346 deletions(-)

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>


Hi Wei,

Thanks for this patch. Lets wait one more day for PMD owners to test the patch,
if there is no objection patch targets rc3 which is a few days away.