From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4B9797CEA for <dev@dpdk.org>; Tue, 8 May 2018 14:12:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2018 05:12:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,378,1520924400"; d="scan'208";a="47625061" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.77]) ([10.237.221.77]) by FMSMGA003.fm.intel.com with ESMTP; 08 May 2018 05:12:37 -0700 To: Wei Dai <wei.dai@intel.com>, thomas@monjalon.net, declan.doherty@intel.com, linville@tuxdriver.com, mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, ravi1.kumar@amd.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, jerin.jacob@caviumnetworks.com, maciej.czekaj@caviumnetworks.com, shijith.thotton@cavium.com, ssrinivasan@cavium.com, santosh.shukla@caviumnetworks.com, rahul.lakkireddy@chelsio.com, ohndale@cisco.com, hyonkim@cisco.com, wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, tdu@semihalf.com, dima@marvell.com, nsamsono@marvell.com, jianbo.liu@arm.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, yskoh@mellanox.com, matan@mellanox.com, vido@cesnet.cz, alejandro.lucero@netronome.com, emant.agrawal@nxp.com, shreyansh.jain@nxp.com, hemant.agrawal@nxp.com, harish.patil@cavium.com, rasesh.mody@cavium.com, asesh.mody@cavium.com, shahed.shaikh@cavium.com, arybchenko@solarflare.com, yongwang@vmware.com, maxime.coquelin@redhat.com, mtetsuyah@gmail.com, tiwei.bie@intel.com, allain.legacy@windriver.com, matt.peters@windriver.com, pascal.mazon@6wind.com, bruce.richardson@intel.com, gaetan.rivet@6wind.com, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com Cc: dev@dpdk.org References: <1525442529-12723-1-git-send-email-wei.dai@intel.com> <1525773917-62792-1-git-send-email-wei.dai@intel.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E TS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62 FwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4 jQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB c34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF HmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd fmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1 yC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p msjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg Hiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW ta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu UhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG ZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ zT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU NyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK FYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs tFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC x41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA bLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ qZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3 XphVR5G70mnca1E2vzC77z+XSlTyRA== Message-ID: <41b243de-34e7-5659-a1c3-db5f46e236fa@intel.com> Date: Tue, 8 May 2018 13:12:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1525773917-62792-1-git-send-email-wei.dai@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Tue, 08 May 2018 14:13:42 +0200 Subject: Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 08 May 2018 12:12:52 -0000 On 5/8/2018 11:05 AM, Wei Dai wrote: > This patch check if a input requested offloading is valid or not. > Any reuqested offloading must be supported in the device capabilities. > Any offloading is disabled by default if it is not set in the parameter > dev_conf->[rt]xmode.offloads to rte_eth_dev_configure( ) and > [rt]x_conf->offloads to rte_eth_[rt]x_queue_setup( ). > If any offloading is enabled in rte_eth_dev_configure( ) by application, > it is enabled on all queues no matter whether it is per-queue or > per-port type and no matter whether it is set or cleared in > [rt]x_conf->offloads to rte_eth_[rt]x_queue_setup( ). > If a per-queue offloading hasn't be enabled in rte_eth_dev_configure( ), > it can be enabled or disabled for individual queue in > ret_eth_[rt]x_queue_setup( ). > A new added offloading is the one which hasn't been enabled in > rte_eth_dev_configure( ) and is reuqested to be enabled in > rte_eth_[rt]x_queue_setup( ), it must be per-queue type, > otherwise return error. > The underlying PMD must be aware that the requested offloadings > to PMD specific queue_setup( ) function only carries those > new added offloadings of per-queue type. > > This patch can make above such checking in a common way in rte_ethdev > layer to avoid same checking in underlying PMD. > > This patch assumes that all PMDs in 18.05-rc2 have already > converted to offload API defined in 17.11 . It also assumes > that all PMDs can return correct offloading capabilities > in rte_eth_dev_infos_get( ). > > In the beginning of [rt]x_queue_setup( ) of underlying PMD, > add offloads = [rt]xconf->offloads | > dev->data->dev_conf.[rt]xmode.offloads; to keep same as offload API > defined in 17.11 to avoid upper application broken due to offload > API change. > PMD can use the info that input [rt]xconf->offloads only carry > the new added per-queue offloads to do some optimization or some > code change on base of this patch. > > Signed-off-by: Wei Dai <wei.dai@intel.com> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> > > --- > v8: > Revise PMD codes to comply with offload API in v7 > update document > > v7: > Give the maximum freedom for upper application, > only minimal checking is performed in ethdev layer. > Only requested specific pure per-queue offloadings are input > to underlying PMD. > > v6: > No need enable an offload in queue_setup( ) if it has already > been enabled in dev_configure( ) > > v5: > keep offload settings sent to PMD same as those from application > > v4: > fix a wrong description in git log message. > > v3: > rework according to dicision of offloading API in community > > v2: > add offloads checking in rte_eth_dev_configure( ). > check if a requested offloading is supported. > --- > doc/guides/prog_guide/poll_mode_drv.rst | 26 +++-- > doc/guides/rel_notes/release_18_05.rst | 8 ++ > drivers/net/avf/avf_rxtx.c | 5 +- > drivers/net/bnxt/bnxt_ethdev.c | 17 ---- > drivers/net/cxgbe/cxgbe_ethdev.c | 50 +--------- > drivers/net/dpaa/dpaa_ethdev.c | 16 ---- > drivers/net/dpaa2/dpaa2_ethdev.c | 16 ---- > drivers/net/e1000/em_ethdev.c | 19 ---- > drivers/net/e1000/em_rxtx.c | 64 ++----------- > drivers/net/e1000/igb_rxtx.c | 64 ++----------- > drivers/net/ena/ena_ethdev.c | 65 +------------ > drivers/net/failsafe/failsafe_ops.c | 81 ---------------- > drivers/net/fm10k/fm10k_ethdev.c | 82 ++-------------- > drivers/net/i40e/i40e_rxtx.c | 58 ++---------- > drivers/net/ixgbe/ixgbe_ethdev.c | 38 -------- > drivers/net/ixgbe/ixgbe_rxtx.c | 66 ++----------- > drivers/net/mlx4/mlx4_rxq.c | 43 ++------- > drivers/net/mlx4/mlx4_txq.c | 42 ++------ > drivers/net/mlx5/mlx5_ethdev.c | 22 ----- > drivers/net/mlx5/mlx5_rxq.c | 50 ++-------- > drivers/net/mlx5/mlx5_txq.c | 44 +-------- > drivers/net/mvpp2/mrvl_ethdev.c | 97 +------------------ > drivers/net/nfp/nfp_net.c | 163 -------------------------------- > drivers/net/octeontx/octeontx_ethdev.c | 72 +------------- > drivers/net/sfc/sfc_ethdev.c | 9 +- > drivers/net/sfc/sfc_rx.c | 42 ++------ > drivers/net/sfc/sfc_rx.h | 3 +- > drivers/net/sfc/sfc_tx.c | 42 ++------ > drivers/net/sfc/sfc_tx.h | 3 +- > drivers/net/tap/rte_eth_tap.c | 88 ++--------------- > drivers/net/thunderx/nicvf_ethdev.c | 70 ++------------ > drivers/net/virtio/virtio_rxtx.c | 9 +- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 16 ---- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 8 +- > lib/librte_ethdev/rte_ethdev.c | 88 +++++++++++++++++ > 35 files changed, 240 insertions(+), 1346 deletions(-) Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Hi Wei, Thanks for this patch. Lets wait one more day for PMD owners to test the patch, if there is no objection patch targets rc3 which is a few days away.