From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Xiaoyu Min <jackmin@mellanox.com>,
Jasvinder Singh <jasvinder.singh@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cc: dev@dpdk.org, Dekel Peled <dekelp@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH 5/5] net/softnic: update headers size calculation
Date: Mon, 16 Nov 2020 16:27:19 +0000 [thread overview]
Message-ID: <41f0fbac-59e5-bddb-3e4d-744da727bd7c@intel.com> (raw)
In-Reply-To: <0bbc7b578dc8ad9348e802e2553de977805f80db.1605493464.git.jackmin@nvidia.com>
On 11/16/2020 7:55 AM, Xiaoyu Min wrote:
> From: Dekel Peled <dekelp@nvidia.com>
>
> The rte_flow_item_eth and rte_flow_item_vlan items were updated in [1].
> The rte_flow_item_ipv6 item was updated in [2].
> The structs now contain additional metadata following the header data.
> The size to use for match should be the header data size only, and
> not the size of the whole struct.
>
> This patch replaces the rte_flow_item_* with the corresponding rte_*_hdr.
>
> [1]:commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN
> items")
>
> [2]: commit ad976bd40d28 ("ethdev: add extensions attributes to IPv6 item")
>
> Signed-off-by: Dekel Peled <dekelp@nvidia.com>
> ---
> drivers/net/softnic/rte_eth_softnic_flow.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/softnic/rte_eth_softnic_flow.c b/drivers/net/softnic/rte_eth_softnic_flow.c
> index f05ff092fa..7925bad1c0 100644
> --- a/drivers/net/softnic/rte_eth_softnic_flow.c
> +++ b/drivers/net/softnic/rte_eth_softnic_flow.c
> @@ -169,22 +169,22 @@ flow_item_is_proto(enum rte_flow_item_type type,
>
> case RTE_FLOW_ITEM_TYPE_ETH:
> *mask = &rte_flow_item_eth_mask;
> - *size = sizeof(struct rte_flow_item_eth);
> + *size = sizeof(struct rte_ether_hdr);
> return 1; /* TRUE */
>
> case RTE_FLOW_ITEM_TYPE_VLAN:
> *mask = &rte_flow_item_vlan_mask;
> - *size = sizeof(struct rte_flow_item_vlan);
> + *size = sizeof(struct rte_vlan_hdr);
> return 1;
>
> case RTE_FLOW_ITEM_TYPE_IPV4:
> *mask = &rte_flow_item_ipv4_mask;
> - *size = sizeof(struct rte_flow_item_ipv4);
> + *size = sizeof(struct rte_ipv4_hdr);
> return 1;
>
> case RTE_FLOW_ITEM_TYPE_IPV6:
> *mask = &rte_flow_item_ipv6_mask;
> - *size = sizeof(struct rte_flow_item_ipv6);
> + *size = sizeof(struct rte_ipv6_hdr);
> return 1;
>
As far as I can see the 'flow_item_is_proto' sets the size to be used over
'rte_flow_item_*" types, the original values seems correct to me, am I missing
something.
Can you please elaborate why the change is needed?
next prev parent reply other threads:[~2020-11-16 16:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 7:55 [dpdk-dev] [PATCH 0/5] fix protocol " Xiaoyu Min
2020-11-16 7:55 ` [dpdk-dev] [PATCH 1/5] net/mlx5: fix protocol size for raw encap judgement Xiaoyu Min
2020-11-17 13:25 ` Matan Azrad
2020-11-22 14:21 ` Thomas Monjalon
2020-11-22 15:32 ` Thomas Monjalon
2020-11-22 16:04 ` Matan Azrad
2020-11-23 7:54 ` Ori Kam
2020-11-23 8:12 ` Thomas Monjalon
2020-11-16 7:55 ` [dpdk-dev] [PATCH 2/5] app/flow-perf: fix protocol size for raw encap Xiaoyu Min
2020-11-16 7:55 ` [dpdk-dev] [PATCH 3/5] net/bnxt: fix protocol size for VXLAN encap copy Xiaoyu Min
2020-11-16 16:12 ` Ferruh Yigit
2020-11-18 0:34 ` Ajit Khaparde
2020-11-18 6:37 ` Andrew Rybchenko
2020-11-18 17:44 ` Ajit Khaparde
2020-11-16 7:55 ` [dpdk-dev] [PATCH 4/5] net/iavf: fix protocol size for virtchnl copy Xiaoyu Min
2020-11-16 16:23 ` Ferruh Yigit
2020-11-22 13:28 ` Jack Min
2020-11-22 14:15 ` Thomas Monjalon
2020-11-23 10:02 ` Ferruh Yigit
2020-11-23 10:49 ` Ferruh Yigit
2020-11-24 21:58 ` Thomas Monjalon
2020-11-27 1:17 ` Xing, Beilei
2020-11-16 7:55 ` [dpdk-dev] [PATCH 5/5] net/softnic: update headers size calculation Xiaoyu Min
2020-11-16 16:27 ` Ferruh Yigit [this message]
2020-11-16 19:09 ` Dekel Peled
2020-11-17 10:30 ` Ferruh Yigit
2020-11-17 12:41 ` Dekel Peled
2020-11-17 15:43 ` Singh, Jasvinder
2020-11-18 2:23 ` Zhou, JunX W
2020-11-22 16:11 ` [dpdk-dev] [PATCH 0/5] fix protocol " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41f0fbac-59e5-bddb-3e4d-744da727bd7c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dekelp@nvidia.com \
--cc=dev@dpdk.org \
--cc=jackmin@mellanox.com \
--cc=jasvinder.singh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).