From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 440104325F; Wed, 1 Nov 2023 10:45:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA07940151; Wed, 1 Nov 2023 10:45:01 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id EBB98400EF for <dev@dpdk.org>; Wed, 1 Nov 2023 10:44:59 +0100 (CET) Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4SL28h5xwnz1P7nV for <dev@dpdk.org>; Wed, 1 Nov 2023 17:41:56 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 1 Nov 2023 17:44:57 +0800 Subject: Re: [PATCH v8 00/10] support setting and querying RSS algorithms To: Jie Hai <haijie1@huawei.com>, <dev@dpdk.org> CC: <lihuisong@huawei.com>, <liudongdong3@huawei.com> References: <20230315110033.30143-1-liudongdong3@huawei.com> <20231101074039.3088716-1-haijie1@huawei.com> From: fengchengwen <fengchengwen@huawei.com> Message-ID: <41fe47f6-0adf-31bd-08dc-2861227872ee@huawei.com> Date: Wed, 1 Nov 2023 17:44:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20231101074039.3088716-1-haijie1@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml100024.china.huawei.com (7.185.36.115) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org LGTM Series-acked-by: Chengwen Feng <fengchengwen@huawei.com> On 2023/11/1 15:40, Jie Hai wrote: > This patchset is to support setting and querying RSS algorithms. > For this purpose, field "rss_algo_capa" is added to ``rte_eth_dev_info`` > and field "algorithm" is added to ``rte_eth_rss_conf``. > The drivers should reports their "rss_algo_capa" if they support > updating RSS algorithms. Otherwise, the "rss_algo_capa" is set to > RTE_ETH_HASH_ALGO_CAPA_MASK(DEFAULT). The app configures RSS algorithms > by field "algorithm" and the related API should verify "algorithm" with > "rss_algo_capa". > > -- > v8: > 1. rewrite some comments. > 2. add check for rss_key_len in ethdev level. > 3. add Acked-by: Huisong Li <lihuisong@huawei.com>. > 4. fix log on RSS hash algorithm. > 5. add rte_eth_dev_rss_algo_name to lib/ethdev/version.map. > 6. fix RSS algorithm display on testpmd. > > v7: > 1. fix compile error. > 2. add signed-off-by to patch[4/9]. > v6: > 1. rewrite some comments. > 2. add "rss_algo_capa" for `rte_eth_dev_info``. > 3. add new API to get name of RSS algorithms > > v5: > 1. rewrite some comments. > 2. check RSS algorithm for drivers supporting RSS. > 3. change field "func" of rss_conf to "algorithm". > 4. fix commit log for [PATCH v4 4/7]. > 5. add Acked-by Reshma Pattan. > 6. add symmetric_toeplitz_sort for showing. > 7. change "hf" to "hash function" for showing. > > v4: > 1. recomment some definitions related to RSS. > 2. allocate static memory for rss_key instead of dynamic. > 3. use array of strings to get the name of rss algorithm. > 4. add display of rss algorithm with testpmd. > > v3: > 1. fix commit log for PATCH [1/5]. > 2. make RSS ABI changes description to start the actual text at the margin. > 3. move defnition of enum rte_eth_hash_function to rte_ethdev.h. > 4. fix some comment codes. > > v2: > 1. return error if "func" is invalid. > 2. modify the comments of the "func" field. > 3. modify commit log of patch [3/5]. > 4. use malloc instead of rte_malloc. > 5. adjust display format of RSS info. > 6. remove the string display of rss_hf. > > Huisong Li (1): > net/hns3: support setting and querying RSS hash function > > Jie Hai (9): > ethdev: overwrite some comment related to RSS > lib/ethdev: check RSS key length > ethdev: support setting and querying RSS algorithm > net/hns3: report RSS hash algorithms capability > app/proc-info: fix never show RSS info > app/proc-info: adjust the display format of RSS info > ethdev: add API to get RSS algorithm names > app/proc-info: support querying RSS hash algorithm > app/testpmd: add RSS hash algorithms display > > app/proc-info/main.c | 24 +++++--- > app/test-pmd/cmdline.c | 29 +++++++-- > app/test-pmd/config.c | 29 ++++----- > app/test-pmd/testpmd.h | 2 +- > doc/guides/rel_notes/release_23_11.rst | 9 +++ > drivers/net/hns3/hns3_common.c | 4 ++ > drivers/net/hns3/hns3_rss.c | 47 ++++++++------- > lib/ethdev/rte_ethdev.c | 82 ++++++++++++++++++++++++++ > lib/ethdev/rte_ethdev.h | 79 ++++++++++++++++++++----- > lib/ethdev/rte_flow.c | 1 - > lib/ethdev/rte_flow.h | 25 +------- > lib/ethdev/version.map | 1 + > 12 files changed, 239 insertions(+), 93 deletions(-) >