From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: anatoly.burakov@intel.com
Cc: dev@dpdk.org, Nirranjan Kirubaharan <nirranjan@chelsio.com>,
Felix Marti <felix@chelsio.com>,
Kumar Sanghvi <kumaras@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size
Date: Tue, 30 Jun 2015 23:12:52 +0200 [thread overview]
Message-ID: <4201419.gIoUKGuTjB@xps13> (raw)
In-Reply-To: <2eeeff646a329cca169033f541de3e96cec3a27a.1435067129.git.rahul.lakkireddy@chelsio.com>
Hi Anatoly,
Please could you review this fix to allow Chelsio using VFIO?
Thanks
2015-06-23 20:30, Rahul Lakkireddy:
> When using vfio, the probe fails over Chelsio T5 adapters after
> commit-id 90a1633b2 (eal/linux: allow to map BARs with MSI-X tables).
>
> While debugging further, found that the BAR region offset and size read from
> vfio are u64, but are assigned to uint32_t variables. This results in the u64
> value getting truncated to 0 and passing wrong offset and size to mmap for
> subsequent BAR regions (i.e. trying to overwrite previously allocated BAR 0
> region).
>
> The fix is to use these region offset and size directly rather than assigning
> to uint32_t variables.
>
> Fixes: 90a1633b2347 ("eal/linux: allow to map BARs with MSI-X tables")
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>
next prev parent reply other threads:[~2015-06-30 21:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 14:16 [dpdk-dev] [PATCH] " Rahul Lakkireddy
2015-06-17 12:09 ` Thomas Monjalon
2015-06-18 14:23 ` Rahul Lakkireddy
2015-06-23 15:00 ` [dpdk-dev] [PATCH v2] " Rahul Lakkireddy
2015-06-30 21:12 ` Thomas Monjalon [this message]
2015-07-01 8:34 ` Alejandro Lucero
2015-07-01 10:00 ` Burakov, Anatoly
2015-07-06 15:45 ` Alejandro Lucero
2015-07-07 7:56 ` Rahul Lakkireddy
2015-07-07 9:08 ` Burakov, Anatoly
2015-07-07 10:40 ` Rahul Lakkireddy
2015-07-07 10:50 ` Burakov, Anatoly
2015-07-10 9:54 ` Rahul Lakkireddy
2015-07-10 17:27 ` Alejandro Lucero
2015-07-13 8:51 ` [dpdk-dev] [PATCH v3] " Rahul Lakkireddy
2015-07-14 8:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4201419.gIoUKGuTjB@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=felix@chelsio.com \
--cc=kumaras@chelsio.com \
--cc=nirranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).