From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 20543A00C2;
	Thu, 10 Feb 2022 12:39:27 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A6CDE40140;
	Thu, 10 Feb 2022 12:39:26 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id A43954013F
 for <dev@dpdk.org>; Thu, 10 Feb 2022 12:39:25 +0100 (CET)
Received: from [192.168.1.126] (unknown [188.242.181.57])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 771307D;
 Thu, 10 Feb 2022 14:39:24 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 771307D
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1644493164;
 bh=L9Q/pSOihee+gwpohtaLM44x0I1UcyNAgQm076XQ+sU=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=dQilDAYvkml1mV62k6mIeO1CqPXqcBlG15UvdrU22J+qlJvYBJGAzK1gKQCgJj5XC
 kD5hYYkpJ3AZc1Plt3y2KTxSj8r5xrIILNlrhRQLXAfo5QdUVwxjLEeffi6YsLEyUr
 /iUlpQFRwWgqf8ZfwaE/wg20xA17kB8dRFl07WwQ=
Message-ID: <420e7dbf-856d-674f-bf32-021df572ed63@oktetlabs.ru>
Date: Thu, 10 Feb 2022 14:39:23 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] ethdev: introduce generic dummy packet burst function
Content-Language: en-US
To: =?UTF-8?Q?Morten_Br=c3=b8rup?= <mb@smartsharesystems.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>,
 Shepard Siegel <shepard.siegel@atomicrules.com>,
 Ed Czeck <ed.czeck@atomicrules.com>,
 John Miller <john.miller@atomicrules.com>, Rasesh Mody <rmody@marvell.com>,
 Shahed Shaikh <shshaikh@marvell.com>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>,
 Somnath Kotur <somnath.kotur@broadcom.com>,
 Nithin Dabilpuram <ndabilpuram@marvell.com>,
 Kiran Kumar K <kirankumark@marvell.com>, Sunil Kumar Kori
 <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Sachin Saxena <sachin.saxena@oss.nxp.com>, John Daley <johndale@cisco.com>,
 Hyong Youb Kim <hyonkim@cisco.com>, "Min Hu (Connor)" <humin29@huawei.com>,
 Yisen Zhuang <yisen.zhuang@huawei.com>, Lijun Ou <oulijun@huawei.com>,
 Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko
 <viacheslavo@nvidia.com>, Gagandeep Singh <g.singh@nxp.com>,
 Devendra Singh Rawat <dsinghrawat@marvell.com>,
 Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Ciara Loftus <ciara.loftus@intel.com>
References: <20220208194437.426143-1-ferruh.yigit@intel.com>
 <98CBD80474FA8B44BF855DF32C47DC35D86E7F@smartserver.smartshare.dk>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86E7F@smartserver.smartshare.dk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2/10/22 14:04, Morten Brørup wrote:
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>> Sent: Tuesday, 8 February 2022 20.45
>>
>> Multiple PMDs have dummy/noop Rx/Tx packet burst functions.
>>
>> These dummy functions are very simple, introduce a common function in
>> the ethdev and update drivers to use it instead of each driver having
>> its own functions.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> After briefly considering if the dummy TX should free the burst, I concluded that the current behavior is correct.

Could you share your thoughts, please. I'm wondering as well.

> 
> Good clean-up. :-)
> 
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
>