DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dumitru Ceara <dceara@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Cc: bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/ring: advertise multi segment support.
Date: Mon, 28 Sep 2020 09:31:35 +0200	[thread overview]
Message-ID: <4210e299-3af5-63b2-717c-7495ba38822b@redhat.com> (raw)
In-Reply-To: <40128dc3-e379-6916-67fa-69b4394cac0a@intel.com>

On 9/22/20 4:21 PM, Ferruh Yigit wrote:
> On 9/18/2020 11:36 AM, Dumitru Ceara wrote:
>> Even though ring interfaces don't support any other TX/RX offloads they
>> do support sending multi segment packets and this should be advertised
>> in order to not break applications that use ring interfaces.
>>
> 
> Does ring PMD support sending multi segmented packets?
> 

Yes, sending multi segmented packets works fine with ring PMD.

> As far as I can see ring PMD doesn't know about the mbuf segments.
> 

Right, the PMD doesn't care about the mbuf segments but it implicitly
supports sending multi segmented packets. From what I see it's actually
the case for most of the PMDs, in the sense that most don't even check
the DEV_TX_OFFLOAD_MULTI_SEGS flag and if the application sends multi
segment packets they are just accepted.

However, the fact that the ring PMD doesn't advertise this implicit
support forces applications that use ring PMD to have a special case for
handling ring interfaces. If the ring PMD would advertise
DEV_TX_OFFLOAD_MULTI_SEGS this would allow upper layers to be oblivious
to the type of underlying interface.

Thanks,
Dumitru


  reply	other threads:[~2020-09-28  7:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 10:36 Dumitru Ceara
2020-09-22 14:21 ` Ferruh Yigit
2020-09-28  7:31   ` Dumitru Ceara [this message]
2020-09-28 10:25     ` Ferruh Yigit
2020-09-28 11:00       ` Ananyev, Konstantin
2020-09-28 12:42         ` Ferruh Yigit
2020-09-28 13:10           ` Ananyev, Konstantin
2020-09-28 13:26             ` Ferruh Yigit
2020-09-28 13:58               ` Dumitru Ceara
2020-09-28 15:02                 ` Ferruh Yigit
2020-09-28 11:01       ` Bruce Richardson
2020-09-28 12:45         ` Ferruh Yigit
2020-09-28 18:47 ` [dpdk-dev] [PATCH v2] net/ring: advertise multi segment TX and scatter RX Dumitru Ceara
2020-09-29  8:37   ` Bruce Richardson
2020-09-30 17:04     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4210e299-3af5-63b2-717c-7495ba38822b@redhat.com \
    --to=dceara@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).