DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] net/i40e: always re-program promiscuous mode on VF interface
@ 2019-11-19 13:45 Eelco Chaudron
  2019-12-04 15:18 ` Eelco Chaudron
  2019-12-18  1:23 ` Zhang, Xiao
  0 siblings, 2 replies; 6+ messages in thread
From: Eelco Chaudron @ 2019-11-19 13:45 UTC (permalink / raw)
  To: beilei.xing, qi.z.zhang; +Cc: xiao.zhang, dev

During a kernel PF reset, this event is propagated to the VF.
The DPDK VF PMD will execute the reset task before the PF is done
with his. This results in the admin queue message not being responded
to leaving the port in "promiscuous" mode.

This patch makes sure the promiscuous mode is configured independently
of the current admin state.

Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
---
v1-v2:
  In the earlier patch, we would force the vf->promisc_unicast_enabled
  state to false after a reset. Based on the review comments it was
  prefered to not take the current state into account when programming.

  v1 patch was called: net/i40e: force promiscuous state after VF reset

 drivers/net/i40e/i40e_ethdev_vf.c |   16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 5dba092..43f7ab5 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2162,10 +2162,6 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
 	struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 	int ret;
 
-	/* If enabled, just return */
-	if (vf->promisc_unicast_enabled)
-		return 0;
-
 	ret = i40evf_config_promisc(dev, 1, vf->promisc_multicast_enabled);
 	if (ret == 0)
 		vf->promisc_unicast_enabled = TRUE;
@@ -2181,10 +2177,6 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
 	struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 	int ret;
 
-	/* If disabled, just return */
-	if (!vf->promisc_unicast_enabled)
-		return 0;
-
 	ret = i40evf_config_promisc(dev, 0, vf->promisc_multicast_enabled);
 	if (ret == 0)
 		vf->promisc_unicast_enabled = FALSE;
@@ -2200,10 +2192,6 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
 	struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 	int ret;
 
-	/* If enabled, just return */
-	if (vf->promisc_multicast_enabled)
-		return 0;
-
 	ret = i40evf_config_promisc(dev, vf->promisc_unicast_enabled, 1);
 	if (ret == 0)
 		vf->promisc_multicast_enabled = TRUE;
@@ -2219,10 +2207,6 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
 	struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 	int ret;
 
-	/* If enabled, just return */
-	if (!vf->promisc_multicast_enabled)
-		return 0;
-
 	ret = i40evf_config_promisc(dev, vf->promisc_unicast_enabled, 0);
 	if (ret == 0)
 		vf->promisc_multicast_enabled = FALSE;


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v2] net/i40e: always re-program promiscuous mode on VF interface
  2019-11-19 13:45 [dpdk-dev] [PATCH v2] net/i40e: always re-program promiscuous mode on VF interface Eelco Chaudron
@ 2019-12-04 15:18 ` Eelco Chaudron
  2019-12-17 13:50   ` Eelco Chaudron
  2019-12-18  1:23 ` Zhang, Xiao
  1 sibling, 1 reply; 6+ messages in thread
From: Eelco Chaudron @ 2019-12-04 15:18 UTC (permalink / raw)
  To: beilei.xing, qi.z.zhang; +Cc: xiao.zhang, dev

Any update on this patch?


On 19 Nov 2019, at 14:45, Eelco Chaudron wrote:

> During a kernel PF reset, this event is propagated to the VF.
> The DPDK VF PMD will execute the reset task before the PF is done
> with his. This results in the admin queue message not being responded
> to leaving the port in "promiscuous" mode.
>
> This patch makes sure the promiscuous mode is configured independently
> of the current admin state.
>
> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
> ---
> v1-v2:
>   In the earlier patch, we would force the vf->promisc_unicast_enabled
>   state to false after a reset. Based on the review comments it was
>   prefered to not take the current state into account when 
> programming.
>
>   v1 patch was called: net/i40e: force promiscuous state after VF 
> reset
>
>  drivers/net/i40e/i40e_ethdev_vf.c |   16 ----------------
>  1 file changed, 16 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c 
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index 5dba092..43f7ab5 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -2162,10 +2162,6 @@ static int eth_i40evf_pci_remove(struct 
> rte_pci_device *pci_dev)
>  	struct i40e_vf *vf = 
> I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
>  	int ret;
>
> -	/* If enabled, just return */
> -	if (vf->promisc_unicast_enabled)
> -		return 0;
> -
>  	ret = i40evf_config_promisc(dev, 1, vf->promisc_multicast_enabled);
>  	if (ret == 0)
>  		vf->promisc_unicast_enabled = TRUE;
> @@ -2181,10 +2177,6 @@ static int eth_i40evf_pci_remove(struct 
> rte_pci_device *pci_dev)
>  	struct i40e_vf *vf = 
> I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
>  	int ret;
>
> -	/* If disabled, just return */
> -	if (!vf->promisc_unicast_enabled)
> -		return 0;
> -
>  	ret = i40evf_config_promisc(dev, 0, vf->promisc_multicast_enabled);
>  	if (ret == 0)
>  		vf->promisc_unicast_enabled = FALSE;
> @@ -2200,10 +2192,6 @@ static int eth_i40evf_pci_remove(struct 
> rte_pci_device *pci_dev)
>  	struct i40e_vf *vf = 
> I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
>  	int ret;
>
> -	/* If enabled, just return */
> -	if (vf->promisc_multicast_enabled)
> -		return 0;
> -
>  	ret = i40evf_config_promisc(dev, vf->promisc_unicast_enabled, 1);
>  	if (ret == 0)
>  		vf->promisc_multicast_enabled = TRUE;
> @@ -2219,10 +2207,6 @@ static int eth_i40evf_pci_remove(struct 
> rte_pci_device *pci_dev)
>  	struct i40e_vf *vf = 
> I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
>  	int ret;
>
> -	/* If enabled, just return */
> -	if (!vf->promisc_multicast_enabled)
> -		return 0;
> -
>  	ret = i40evf_config_promisc(dev, vf->promisc_unicast_enabled, 0);
>  	if (ret == 0)
>  		vf->promisc_multicast_enabled = FALSE;


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v2] net/i40e: always re-program promiscuous mode on VF interface
  2019-12-04 15:18 ` Eelco Chaudron
@ 2019-12-17 13:50   ` Eelco Chaudron
  0 siblings, 0 replies; 6+ messages in thread
From: Eelco Chaudron @ 2019-12-17 13:50 UTC (permalink / raw)
  To: beilei.xing, qi.z.zhang, xiao.zhang; +Cc: dev

Trying again?

On 4 Dec 2019, at 16:18, Eelco Chaudron wrote:

> Any update on this patch?
>
>
> On 19 Nov 2019, at 14:45, Eelco Chaudron wrote:
>
>> During a kernel PF reset, this event is propagated to the VF.
>> The DPDK VF PMD will execute the reset task before the PF is done
>> with his. This results in the admin queue message not being responded
>> to leaving the port in "promiscuous" mode.
>>
>> This patch makes sure the promiscuous mode is configured 
>> independently
>> of the current admin state.
>>
>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>> ---
>> v1-v2:
>>   In the earlier patch, we would force the 
>> vf->promisc_unicast_enabled
>>   state to false after a reset. Based on the review comments it was
>>   prefered to not take the current state into account when 
>> programming.
>>
>>   v1 patch was called: net/i40e: force promiscuous state after VF 
>> reset
>>
>>  drivers/net/i40e/i40e_ethdev_vf.c |   16 ----------------
>>  1 file changed, 16 deletions(-)
>>
>> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c 
>> b/drivers/net/i40e/i40e_ethdev_vf.c
>> index 5dba092..43f7ab5 100644
>> --- a/drivers/net/i40e/i40e_ethdev_vf.c
>> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
>> @@ -2162,10 +2162,6 @@ static int eth_i40evf_pci_remove(struct 
>> rte_pci_device *pci_dev)
>>  	struct i40e_vf *vf = 
>> I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
>>  	int ret;
>>
>> -	/* If enabled, just return */
>> -	if (vf->promisc_unicast_enabled)
>> -		return 0;
>> -
>>  	ret = i40evf_config_promisc(dev, 1, vf->promisc_multicast_enabled);
>>  	if (ret == 0)
>>  		vf->promisc_unicast_enabled = TRUE;
>> @@ -2181,10 +2177,6 @@ static int eth_i40evf_pci_remove(struct 
>> rte_pci_device *pci_dev)
>>  	struct i40e_vf *vf = 
>> I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
>>  	int ret;
>>
>> -	/* If disabled, just return */
>> -	if (!vf->promisc_unicast_enabled)
>> -		return 0;
>> -
>>  	ret = i40evf_config_promisc(dev, 0, vf->promisc_multicast_enabled);
>>  	if (ret == 0)
>>  		vf->promisc_unicast_enabled = FALSE;
>> @@ -2200,10 +2192,6 @@ static int eth_i40evf_pci_remove(struct 
>> rte_pci_device *pci_dev)
>>  	struct i40e_vf *vf = 
>> I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
>>  	int ret;
>>
>> -	/* If enabled, just return */
>> -	if (vf->promisc_multicast_enabled)
>> -		return 0;
>> -
>>  	ret = i40evf_config_promisc(dev, vf->promisc_unicast_enabled, 1);
>>  	if (ret == 0)
>>  		vf->promisc_multicast_enabled = TRUE;
>> @@ -2219,10 +2207,6 @@ static int eth_i40evf_pci_remove(struct 
>> rte_pci_device *pci_dev)
>>  	struct i40e_vf *vf = 
>> I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
>>  	int ret;
>>
>> -	/* If enabled, just return */
>> -	if (!vf->promisc_multicast_enabled)
>> -		return 0;
>> -
>>  	ret = i40evf_config_promisc(dev, vf->promisc_unicast_enabled, 0);
>>  	if (ret == 0)
>>  		vf->promisc_multicast_enabled = FALSE;


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v2] net/i40e: always re-program promiscuous mode on VF interface
  2019-11-19 13:45 [dpdk-dev] [PATCH v2] net/i40e: always re-program promiscuous mode on VF interface Eelco Chaudron
  2019-12-04 15:18 ` Eelco Chaudron
@ 2019-12-18  1:23 ` Zhang, Xiao
  2019-12-18  2:57   ` Ye Xiaolong
  1 sibling, 1 reply; 6+ messages in thread
From: Zhang, Xiao @ 2019-12-18  1:23 UTC (permalink / raw)
  To: Eelco Chaudron; +Cc: dev, Xing, Beilei, Zhang, Qi Z


> -----Original Message-----
> From: Eelco Chaudron [mailto:echaudro@redhat.com]
> Sent: Tuesday, November 19, 2019 9:45 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: Zhang, Xiao <xiao.zhang@intel.com>; dev@dpdk.org
> Subject: [PATCH v2] net/i40e: always re-program promiscuous mode on VF
> interface
> 
> During a kernel PF reset, this event is propagated to the VF.
> The DPDK VF PMD will execute the reset task before the PF is done with his. This
> results in the admin queue message not being responded to leaving the port in
> "promiscuous" mode.
> 
> This patch makes sure the promiscuous mode is configured independently of the
> current admin state.
> 
> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>

Reviewed-by: Xiao Zhang <xiao.zhang@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v2] net/i40e: always re-program promiscuous mode on VF interface
  2019-12-18  1:23 ` Zhang, Xiao
@ 2019-12-18  2:57   ` Ye Xiaolong
  2019-12-18  8:33     ` Eelco Chaudron
  0 siblings, 1 reply; 6+ messages in thread
From: Ye Xiaolong @ 2019-12-18  2:57 UTC (permalink / raw)
  To: Zhang, Xiao; +Cc: Eelco Chaudron, dev, Xing, Beilei, Zhang, Qi Z

On 12/18, Zhang, Xiao wrote:
>
>> -----Original Message-----
>> From: Eelco Chaudron [mailto:echaudro@redhat.com]
>> Sent: Tuesday, November 19, 2019 9:45 PM
>> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
>> Cc: Zhang, Xiao <xiao.zhang@intel.com>; dev@dpdk.org
>> Subject: [PATCH v2] net/i40e: always re-program promiscuous mode on VF
>> interface
>> 
>> During a kernel PF reset, this event is propagated to the VF.
>> The DPDK VF PMD will execute the reset task before the PF is done with his. This
>> results in the admin queue message not being responded to leaving the port in
>> "promiscuous" mode.
>> 
>> This patch makes sure the promiscuous mode is configured independently of the
>> current admin state.
>> 
>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>
>Reviewed-by: Xiao Zhang <xiao.zhang@intel.com>

Applied to dpdk-next-net-intel, Thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v2] net/i40e: always re-program promiscuous mode on VF interface
  2019-12-18  2:57   ` Ye Xiaolong
@ 2019-12-18  8:33     ` Eelco Chaudron
  0 siblings, 0 replies; 6+ messages in thread
From: Eelco Chaudron @ 2019-12-18  8:33 UTC (permalink / raw)
  To: Ye Xiaolong; +Cc: Zhang, Xiao, dev, Xing, Beilei, Zhang, Qi Z

Thanks!



On 18 Dec 2019, at 3:57, Ye Xiaolong wrote:

> On 12/18, Zhang, Xiao wrote:
>>
>>> -----Original Message-----
>>> From: Eelco Chaudron [mailto:echaudro@redhat.com]
>>> Sent: Tuesday, November 19, 2019 9:45 PM
>>> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z 
>>> <qi.z.zhang@intel.com>
>>> Cc: Zhang, Xiao <xiao.zhang@intel.com>; dev@dpdk.org
>>> Subject: [PATCH v2] net/i40e: always re-program promiscuous mode on 
>>> VF
>>> interface
>>>
>>> During a kernel PF reset, this event is propagated to the VF.
>>> The DPDK VF PMD will execute the reset task before the PF is done 
>>> with his. This
>>> results in the admin queue message not being responded to leaving 
>>> the port in
>>> "promiscuous" mode.
>>>
>>> This patch makes sure the promiscuous mode is configured 
>>> independently of the
>>> current admin state.
>>>
>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>>
>> Reviewed-by: Xiao Zhang <xiao.zhang@intel.com>
>
> Applied to dpdk-next-net-intel, Thanks.


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-12-18  8:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19 13:45 [dpdk-dev] [PATCH v2] net/i40e: always re-program promiscuous mode on VF interface Eelco Chaudron
2019-12-04 15:18 ` Eelco Chaudron
2019-12-17 13:50   ` Eelco Chaudron
2019-12-18  1:23 ` Zhang, Xiao
2019-12-18  2:57   ` Ye Xiaolong
2019-12-18  8:33     ` Eelco Chaudron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).