From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id BF28858CE for ; Sun, 9 Jul 2017 12:17:44 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0A8092079F; Sun, 9 Jul 2017 06:17:44 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sun, 09 Jul 2017 06:17:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=sq9vHEIV4+X3/jb 1yPIWR7NjG5JUYtcbiMBUjKNG95o=; b=S9Uo2fdGu0hOlO6TzCChnZPmefzQguz Tnf+T5sQlANlMfrK/cjm/0CarnPw5LuQxene8PGfNytEdpD98YFBo/ta8Taw8dj5 ETLy/SHrcipC9jUOjXfRsfhmpXW98vy+QpzGkM3jL/b5ePxI0azhDQu/weECj9HQ F2GRDp2Dfuu8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=sq9vHEIV4+X3/jb1yPIWR7NjG5JUYtcbiMBUjKNG95o=; b=KzeAyirc rXelSUc6PY5R82ZaBd0iNbYJzpKgJ00rZf4nj3JJ8dml09TH50yh35/tiWRVo34r Jx2jTgx76yhvwHfV47xUbtAohQPnttNohxCFavGLdQrsszTknHw59h/z/B3c4WgN 2suJBeacCZLu/bBo3QZhaEyqo/HE8Uczy92/f/chfZ8zHUPVTSekV3/GnvD7Zxas CrdNzNhDVxYRS3kvPv9Hzjv1BX08S+WmvChuA8z/+d68JuN7dnzk276dU6wcztZo w05pd7ktWo9vDj31lOgM1PH/NDJcQc20VCNgfvi9NVNGLkwmNZL869RbXwCTYbKA mF3JtRVYWYK0/g== X-ME-Sender: X-Sasl-enc: sdIa7dpaSI4UZz9uo1RkOSd/pzSA6NRop8R1VBVWk+Fb 1499595463 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B21F024996; Sun, 9 Jul 2017 06:17:43 -0400 (EDT) From: Thomas Monjalon To: Jan Blunck Cc: dev@dpdk.org, Gaetan Rivet , Stephen Hemminger , Bruce Richardson Date: Sun, 09 Jul 2017 12:17:42 +0200 Message-ID: <4219460.8ez8IeSCfv@xps> In-Reply-To: References: <3893726.oUZ9cfT8R6@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 00/17] Generic devargs parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Jul 2017 10:17:45 -0000 09/07/2017 10:37, Jan Blunck: > On Sat, Jul 8, 2017 at 6:28 PM, Thomas Monjalon wrote: > > 07/07/2017 02:04, Gaetan Rivet: > >> In this patchset, the representation of devices in rte_devargs is made generic > >> to remove some dependencies of the EAL on specific buses implementations. > >> Following the device types being characterized by their bus, the DEVTYPE > >> flags are updated not to reference virtual / PCI devices anymore. > > [...] > >> Gaetan Rivet (16): > >> net/bonding: properly reference PCI header > >> net/bnxt: properly reference PCI header > >> net/mlx5: properly reference PCI header > >> net/e1000: properly reference PCI header > >> net/ixgbe: properly reference PCI header > >> net/sfc: properly reference PCI header > >> app/testpmd: properly reference PCI header > >> test: properly reference PCI header > >> dev: device kernel module is a device attribute > >> bus: introduce bus scan policies > >> devargs: parse bus policies > >> devargs: generic device representation > >> net/virtio: do not reference device type > >> devargs: generic device types > >> devargs: introduce cleaner parsing helper > >> eal: change whitelist / blacklist command line doc > >> > >> Thomas Monjalon (1): > >> examples/ethtool: properly reference PCI header > > > > Series applied, except last patch (17), as explained before. Thanks > > > > I wonder why you complain about not having enough reviewers if you > anyway ignoring their feedback! I am not ignoring your feedback at all. There are 2 things in this series: 1/ decouple devargs and PCI/vdev 2/ couple devargs policies to rte_bus I agree that we should not have policies in rte_bus (2). However it is the only patches we have for now to achieve (1), which is a required step to move PCI and vdev as real bus drivers. As explained in the following email, I prefer progressing on (1) and rework (2) in 17.11: http://dpdk.org/ml/archives/dev/2017-July/070203.html What do you think of my proposal, adding a callback in probe? > I pointed out multiple times that parsing a device name to deduce the > bus is not the right thing to do. Yes, so we need to change the parameter syntax to make the bus name explicit and mandatory. We need a deprecation notice. > This series also tightly couples rte_devargs to rte_bus. > It adds hidden functionality to have > blacklist/whitelist mode for all busses and even sticks that > functionality on the wrong object (devargs). Yes, as said above, we must rework it in 17.11.