DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 00/13] net/sfc: fix device reconfigure
Date: Fri, 31 Mar 2017 16:31:43 +0100	[thread overview]
Message-ID: <4219af0c-aec0-c1fa-9cba-cae62c0e52eb@intel.com> (raw)
In-Reply-To: <1490955743-9868-1-git-send-email-arybchenko@solarflare.com>

On 3/31/2017 11:22 AM, Andrew Rybchenko wrote:
> When I implemented initial version of the driver I had incorrect
> understanding of the required state transition to reconfigure
> device. It was assumed that close is required before reconfigure.
> Looking at description in rte_ethdev.h, rte_eth_dev_close()
> description and rte_eth_dev_configure() implementation I see that
> I was wrong.
> 
> If reconfigure attempt is done without the patch series, testpmd
> crashes on segmentation fault. The patch series fixes it. So,
> technically it is a bug fix, but unfortunately pretty big.
> 
> The patch series should be applied after [1] (patch [2]).
> 
> Testing the patch requires [3] (patch [4]). Intel compilation of
> the patch fails since it is applied to dpdk.git tree instead of
> dpdk-next-net.git.
> 
> [1] http://dpdk.org/ml/archives/dev/2017-March/062155.html
> [2] http://dpdk.org/dev/patchwork/patch/22758/
> [3] http://dpdk.org/ml/archives/dev/2017-March/062157.html
> [4] http://dpdk.org/dev/patchwork/patch/22756/
> 
> Andrew Rybchenko (13):
>   net/sfc: clarify interrupts support function names
>   net/sfc: bind EvQ DMA space to EvQ type and type-local index
>   net/sfc: remove unused max entries from EvQ info
>   net/sfc: move EvQ entries to the EvQ control structure
>   net/sfc: remove flags from EvQ info
>   net/sfc: remove EvQ info array to simplify reconfigure
>   net/sfc: move event support init to attach stage
>   net/sfc: initialize port data on attach
>   net/sfc: clarify Rx subsystem configure/close function names
>   net/sfc: clarify Tx subsystem configure/close function names
>   net/sfc: support changing the number of receive queues
>   net/sfc: support changing the number of transmit queues
>   net/sfc: fix device reconfigure

Series applied to dpdk-next-net/master, thanks.

      parent reply	other threads:[~2017-03-31 15:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31 10:22 Andrew Rybchenko
2017-03-31 10:22 ` [dpdk-dev] [PATCH 01/13] net/sfc: clarify interrupts support function names Andrew Rybchenko
2017-03-31 10:22 ` [dpdk-dev] [PATCH 02/13] net/sfc: bind EvQ DMA space to EvQ type and type-local index Andrew Rybchenko
2017-03-31 10:22 ` [dpdk-dev] [PATCH 03/13] net/sfc: remove unused max entries from EvQ info Andrew Rybchenko
2017-03-31 10:22 ` [dpdk-dev] [PATCH 04/13] net/sfc: move EvQ entries to the EvQ control structure Andrew Rybchenko
2017-03-31 10:22 ` [dpdk-dev] [PATCH 05/13] net/sfc: remove flags from EvQ info Andrew Rybchenko
2017-03-31 10:22 ` [dpdk-dev] [PATCH 06/13] net/sfc: remove EvQ info array to simplify reconfigure Andrew Rybchenko
2017-03-31 10:22 ` [dpdk-dev] [PATCH 07/13] net/sfc: move event support init to attach stage Andrew Rybchenko
2017-03-31 10:22 ` [dpdk-dev] [PATCH 08/13] net/sfc: initialize port data on attach Andrew Rybchenko
2017-03-31 10:22 ` [dpdk-dev] [PATCH 09/13] net/sfc: clarify Rx subsystem configure/close function names Andrew Rybchenko
2017-03-31 10:22 ` [dpdk-dev] [PATCH 10/13] net/sfc: clarify Tx " Andrew Rybchenko
2017-03-31 10:22 ` [dpdk-dev] [PATCH 11/13] net/sfc: support changing the number of receive queues Andrew Rybchenko
2017-03-31 10:22 ` [dpdk-dev] [PATCH 12/13] net/sfc: support changing the number of transmit queues Andrew Rybchenko
2017-03-31 10:22 ` [dpdk-dev] [PATCH 13/13] net/sfc: fix device reconfigure Andrew Rybchenko
2017-03-31 15:31 ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4219af0c-aec0-c1fa-9cba-cae62c0e52eb@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).