From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id D4BCC2BA4 for ; Fri, 31 Mar 2017 17:31:46 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 31 Mar 2017 08:31:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,252,1486454400"; d="scan'208";a="83149870" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga006.fm.intel.com with ESMTP; 31 Mar 2017 08:31:43 -0700 To: Andrew Rybchenko , dev@dpdk.org References: <1490955743-9868-1-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: <4219af0c-aec0-c1fa-9cba-cae62c0e52eb@intel.com> Date: Fri, 31 Mar 2017 16:31:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1490955743-9868-1-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 00/13] net/sfc: fix device reconfigure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 15:31:47 -0000 On 3/31/2017 11:22 AM, Andrew Rybchenko wrote: > When I implemented initial version of the driver I had incorrect > understanding of the required state transition to reconfigure > device. It was assumed that close is required before reconfigure. > Looking at description in rte_ethdev.h, rte_eth_dev_close() > description and rte_eth_dev_configure() implementation I see that > I was wrong. > > If reconfigure attempt is done without the patch series, testpmd > crashes on segmentation fault. The patch series fixes it. So, > technically it is a bug fix, but unfortunately pretty big. > > The patch series should be applied after [1] (patch [2]). > > Testing the patch requires [3] (patch [4]). Intel compilation of > the patch fails since it is applied to dpdk.git tree instead of > dpdk-next-net.git. > > [1] http://dpdk.org/ml/archives/dev/2017-March/062155.html > [2] http://dpdk.org/dev/patchwork/patch/22758/ > [3] http://dpdk.org/ml/archives/dev/2017-March/062157.html > [4] http://dpdk.org/dev/patchwork/patch/22756/ > > Andrew Rybchenko (13): > net/sfc: clarify interrupts support function names > net/sfc: bind EvQ DMA space to EvQ type and type-local index > net/sfc: remove unused max entries from EvQ info > net/sfc: move EvQ entries to the EvQ control structure > net/sfc: remove flags from EvQ info > net/sfc: remove EvQ info array to simplify reconfigure > net/sfc: move event support init to attach stage > net/sfc: initialize port data on attach > net/sfc: clarify Rx subsystem configure/close function names > net/sfc: clarify Tx subsystem configure/close function names > net/sfc: support changing the number of receive queues > net/sfc: support changing the number of transmit queues > net/sfc: fix device reconfigure Series applied to dpdk-next-net/master, thanks.