From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 2912CFEB for ; Wed, 31 Oct 2018 00:12:26 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id A33E5F55; Tue, 30 Oct 2018 19:12:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 30 Oct 2018 19:12:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=t9piDfKfuE8U/aVrBL1BW+klYL7OvFcQyzPpvB2081k=; b=Q9pc5foZLbzo ARVRGKaQzxyAKGLgcImbxrlZdBuXMBRZqL04L9O46IpaM9Liix2IKW62bxlm5n4f DN3t+n4mb8OFkAUcw2nm1qr/SBmkfVu7c++1decDVfqvDJ8nZGX0PrHkWSO4gdq8 YSChEEphhZeTp7R9fr13ZDqpYtvT1ig= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=t9piDfKfuE8U/aVrBL1BW+klYL7OvFcQyzPpvB208 1k=; b=lSy4MIp2PnkKzSNnonAsit0l/VsdUgryXdwOUgPvH1hxypFt12kIePfBK pN8qDd8cWO1a7cAaC/r38XkoMNUZu3BDYVwaecmU0DTWn2g9D4vOY50oB5X/RrJl XrhzPXUxFJRlzXxcehnbGxSzbAJvBOXLrOpLBkwn7zoaJtGGVvzXog5xih2Lvwo6 TI7RSYL6OS7b5uURc/hcYEjI3DXBCMGV4VuBJ4s7CzXf9JhH4SPcph5vkPyBcM95 pL9adMOPN5JBOCpnfPPd0MIuydgfhlkNAvxf1F1bAeJJNSdiV8QJmT1QIRxqn2gM 7w1q36cLT6SeofalTzyAPS8hwLjpg== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4ADB0102DD; Tue, 30 Oct 2018 19:12:22 -0400 (EDT) From: Thomas Monjalon To: Cody Doucette Cc: "Ananyev, Konstantin" , dev@dpdk.org, Gaetan Rivet , Olivier Matz , "Dumitrescu, Cristian" , Michel Machado , "Fu, Qiaobin" , Neil Horman Date: Wed, 31 Oct 2018 00:12:27 +0100 Message-ID: <4226978.aJZGOXQQx2@xps> In-Reply-To: References: <20180727135243.147744-1-doucette@bu.edu> <9635910.y5ZcffoGi6@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 23:12:26 -0000 30/10/2018 19:09, Cody Doucette: > OK, I will send three separate patches plus a cover letter. > > I seem to be having trouble with checkpatch complaining that new symbols > are not inserted into the EXPERIMENTAL section of the .map file: > > ERROR: symbol break is added in a section other than the EXPERIMENTAL > section of the version map > ERROR: symbol const is added in a section other than the EXPERIMENTAL > section of the version map > ERROR: symbol &frag_hdr_buf) is added in a section other than the > EXPERIMENTAL section of the version map > INFO: symbol frag_hdr is being removed, ensure that it has gone > through the deprecation process > INFO: symbol is added but patch has insuficient context to determine > the section name please ensure the version is EXPERIMENTAL > ERROR: symbol offset, is added in a section other than the > EXPERIMENTAL section of the version map > ERROR: symbol offset is added in a section other than the EXPERIMENTAL > section of the version map > ERROR: symbol return is added in a section other than the EXPERIMENTAL > section of the version map > ERROR: symbol return is added in a section other than the EXPERIMENTAL > section of the version map > INFO: symbol is added but patch has insuficient context to determine > the section name please ensure the version is EXPERIMENTAL > ERROR: symbol sizeof(*frag_hdr), is added in a section other than the > EXPERIMENTAL section of the version map > ERROR: symbol size_t is added in a section other than the EXPERIMENTAL > section of the version map > ERROR: symbol struct is added in a section other than the EXPERIMENTAL > section of the version map > INFO: symbol struct is being removed, ensure that it has gone through > the deprecation process > ERROR: symbol struct is added in a section other than the EXPERIMENTAL > section of the version map > ERROR: symbol uint8_t is added in a section other than the > EXPERIMENTAL section of the version map > > Even when moving the new symbol into the EXPERIMENTAL version and > recreating the patch, checkpatch still issues the same errors. > > Can I leave the .map file as it is in v3? If not, any suggestions on what > checkpatch is looking for me to do here? Don't worry, it is a bug in the script. +Cc Neil who already looked at this issue. > On Tue, Oct 30, 2018 at 10:36 AM Thomas Monjalon > wrote: > > > 30/10/2018 10:46, Ananyev, Konstantin: > > > Hi Thomas, > > > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > 28/10/2018 21:54, Cody Doucette: > > > > > On Sun, Oct 28, 2018 at 6:22 AM Thomas Monjalon > > wrote: > > > > > > 27/07/2018 15:52, Cody Doucette: > > > > > > > Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any > > > > > > > other IPv6 extension headers when finding the fragment header. > > > > > > > > > > > > > > According to RFC 8200, there is no guarantee that the IPv6 > > > > > > > Fragment extension header will come before any other extension > > > > > > > header, even though it is recommended. > > > > > > > > > > > > > > Signed-off-by: Cody Doucette > > > > > > > Signed-off-by: Qiaobin Fu > > > > > > > Reviewed-by: Michel Machado > > > > > > > --- > > > > > > > v3: > > > > > > > * Removed compilation flag D_XOPEN_SOURCE=700 from the > > > > > > > failsafe driver to allow compilation on freebsd. > > > > > > > > > > > > How failsafe is related to ip_frag? > > > > > > > > > > > > > > > > > > > v2: > > > > > > > * Moved IPv6 extension header definitions to lib_net. > > > > > > > > > > > > > > drivers/net/failsafe/Makefile | 1 - > > > > > > > drivers/net/failsafe/meson.build | 1 - > > > > > > > examples/ip_reassembly/main.c | 6 ++-- > > > > > > > lib/librte_ip_frag/rte_ip_frag.h | 23 ++++++------- > > > > > > > lib/librte_ip_frag/rte_ip_frag_version.map | 1 + > > > > > > > lib/librte_ip_frag/rte_ipv6_fragmentation.c | 38 > > +++++++++++++++++++++ > > > > > > > lib/librte_ip_frag/rte_ipv6_reassembly.c | 4 +-- > > > > > > > lib/librte_net/rte_ip.h | 27 +++++++++++++++ > > > > > > > lib/librte_port/rte_port_ras.c | 6 ++-- > > > > > > > > > > > > Changes in failsafe, rte_net and rte_port look like garbage. > > > > > > > > > > > > Anyway, the ip_frag part requires some review. > > > > > > +Cc Konstantin, the maintainer. > > > > > > > > > > Garbage in what sense? I would be happy to amend with a little more > > > > > information. > > > > > > > > > > The changes to failsafe and rte_net were from previous reviews from > > > > > Konstantin: > > > > > > > > > > https://mails.dpdk.org/archives/dev/2018-June/106023.html > > > > > > > > > > https://mails.dpdk.org/archives/dev/2018-July/108701.html > > > > > > > > After a better look, the change in rte_port is fine. > > > > > > > > But the changes in failsafe and rte_net would be better in their own > > patch. > > > > You can have 3 patches in a patchset (with a cover letter to explain > > the > > > > global idea). > > > > Then, failsafe and rte_net changes must be reviewed by their > > maintainers. > > > > > > > > > > The patch looks good to me. > > > About failsafe changes - the reason for that was that failsafe driver > > didn't build > > > properly with the proposed changes. > > > Gaetan was ok to remove that extra compiler flag: > > > https://mails.dpdk.org/archives/dev/2018-July/108826.html > > > > OK. Please send the failsafe patch as the first of the series. > > Thanks > > > > > > >