From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0054.outbound.protection.outlook.com [104.47.37.54]) by dpdk.org (Postfix) with ESMTP id 08EB84BE1 for ; Mon, 18 Sep 2017 13:36:21 +0200 (CEST) Received: from BN3PR03CA0109.namprd03.prod.outlook.com (10.174.66.27) by DM5PR03MB2697.namprd03.prod.outlook.com (10.168.197.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Mon, 18 Sep 2017 11:36:19 +0000 Received: from BN1AFFO11FD028.protection.gbl (2a01:111:f400:7c10::105) by BN3PR03CA0109.outlook.office365.com (2603:10b6:400:4::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.8 via Frontend Transport; Mon, 18 Sep 2017 11:36:19 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD028.mail.protection.outlook.com (10.58.52.88) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.35.14 via Frontend Transport; Mon, 18 Sep 2017 11:36:19 +0000 Received: from [10.232.133.65] (B10814-12.ap.freescale.net [10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8IBaGjn002506; Mon, 18 Sep 2017 04:36:17 -0700 To: Shreyansh Jain , References: <20170812102220.27773-1-shreyansh.jain@nxp.com> CC: , From: Hemant Agrawal Message-ID: <422ce0c6-7868-b601-2fe9-e361497d7b14@nxp.com> Date: Mon, 18 Sep 2017 17:06:15 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170812102220.27773-1-shreyansh.jain@nxp.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131502081797015453; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(39860400002)(346002)(376002)(2980300002)(1110001)(1109001)(339900001)(199003)(377454003)(189002)(24454002)(83506001)(77096006)(8676002)(4326008)(23746002)(6246003)(2950100002)(50466002)(54356999)(76176999)(50986999)(47776003)(65806001)(36756003)(2906002)(305945005)(65956001)(31686004)(97736004)(65826007)(229853002)(105606002)(104016004)(58126008)(85426001)(106466001)(31696002)(356003)(33646002)(5660300001)(498600001)(8936002)(64126003)(53546010)(54906002)(230700001)(189998001)(68736007)(81166006)(86362001)(8656003)(81156014)(316002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB2697; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD028; 1:JNBoIUwy4j3EOBOSW0LvMNkKdMXWMYzAD4JPtZrDTUBayrsoFlOEpSdvhzJlYyFtXD7etE8iJKqrL09GYHwImZnEFqkOC+OIHgL+ChmJoZ+i5efHyQtssjYc04qrH+JX X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2595f74a-4569-4632-3c95-08d4fe897b20 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR03MB2697; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2697; 3:vtZyXk4K8kbpxtjLa4G4PeyFdCqcblt9PTmnAIPZzQGEu52E6CCmGUeuU/9r5vcAOJUM4vojorj0BGH32H+WELBvhDe/WUYNiPa3sTn7W92JKHHeHicNnwwE7Kg3XhdnQ5Wf5KT4HV72wlTKzSI3EYTfyWwM6IfbyQtqXkFyEOs9KpRg8DOH6Dmim+vf9FdKnV5iXYVqTh+lHeWey+LpQjMMfsOGbhY9D2ypKG6LZ9LKGVCMY7wKpjJ0y6rPUmkOkWbgwUPA3MgMQa+aRuAubC++KJlBBH4u1IbSFFKaI2q5/CmL3WI2h0oPojTBXqO9i+7/GQKtJ7XsRDtLYaxVi1/Aef1IutilNGs9v9hkLo4=; 25:HGig8Mk9Lv42pdRrpY/ahkiPHffd8niWR73Ut7SH+oombRGIyGuJNe8MKb9yc576HIwHYSvHo2VoADLkE128+hFeBy5B6W/Nr4S8xpdcUwR/tITUUqS9rPmp5R8zFr3XviltchbSUSIS9wbyz4ZaIq3Li7K+UZZbybdqRhObsmE06B3Hx7HEaBAI7Dnc8a/jFTw115kYEJvyMsgXnnwqzgfaFfVLhWPjD/1XZwxeRdET/zaxOTOzAP9ZI46RWdaP2Pg5Os47IhMeJfz4f+qKTKnwdliJOLxBuG7IuME8/c7oQfxTnsKf0jfm+56DMR2k2mo00uDDv34NiX9FT2Y8bA== X-MS-TrafficTypeDiagnostic: DM5PR03MB2697: X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2697; 31:kdV3yP9mungHodWwels7z70+hB1Iw0TrdKVB7Gre/dSUUVgVTRotUMc2Pu4qRYYt6pHp7F3fTzQWSqIxL55XKznmCvQ7negfQCSmjA5v0/kLYn6XPsOg7/gJ/cblbzGiFxbaIl3Ms2Zl7BclOT9JX5MV6L8Da52QIFF/0s62klFTKFM1sf/pTnkudO+LGJG9VED6Q8688FGJSVYvgfsbKvFj6qyDH518wNdFuwzfYFA=; 4:OPP7nmjwSDuDy4Y0hIeBnmCcGobE6SEGqJBRNIbSTd3fvFAytBJHNEv2agE3YdvNXdzTVtyJPC6a3sVd33FA1sHVydz8l8Il3/bqH0xHxBCODQRC6eUkvyeitvvq5Mr/PkYO+pQfvSAJFosRwTBPAG9IR3fICiWIhOWrCLE8zvpYdhh5RTOy5D+s6IILwnP1C4bXGRx0T+R2y2n5zxz/v7ovwsTDL0GLvYk4/zEcE4Hu5gdg9xp5+Ibe6PbW8JF+nvjo5EPclGhJNM0IkUkiZjHwFwdfiyTnXbnlH6vXDOQ= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6096035)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123559100)(20161123565025)(20161123556025)(20161123561025)(20161123563025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR03MB2697; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR03MB2697; X-Forefront-PRVS: 04347F8039 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM5PR03MB2697; 23:oVy5IbGDQ8BX/nCwEwQTwnSIPbSp0BKjdEM9K?= =?Windows-1252?Q?RDqTgPYJyGVQ28ElrXQdeW42x1pKQBfbci7WlvJu2Pkupr9j1LJWEtT8?= =?Windows-1252?Q?y4ez6xVOwld5hPj0dNjX2/hjUtnrVh4hs6NjeXxZyO0SBI2ZXB+zfSan?= =?Windows-1252?Q?AEU/W/2bNZQ57pxqP2Vcjbx41VTZCAeczrlz8pcV1vx+6BYtC702e9xk?= =?Windows-1252?Q?ikECDhgIvLd69hUYZndC8Z5InKjFQdd7lESjv3n5uj7WeO+OY6b+pKGV?= =?Windows-1252?Q?AiXMpXQCRdj/Qg8F10QA8QJKeh+ximmxUXm3BtqR5WWk5G8DW52+Vddg?= =?Windows-1252?Q?7tu5zsGPvJonZr8g52KpZBvKprjZHnUoo5efyLGsVWJcSniLhr+vMgPf?= =?Windows-1252?Q?+NPSNloOSLR/F16YdfNF7PL4u0V8C39tSrF7RvYNwSFWw9EmqOxlOIr4?= =?Windows-1252?Q?cG/cXzgsAc9sXv5dJDWpcGMBQKuTYUvfusEFrB7dq8sQGitDMvWjfBqK?= =?Windows-1252?Q?zkZEDlYNXOS3izKYUmsKxrc3Qw6UFZ1LVW9XqymU7+YIj0ZfHGaNnDiX?= =?Windows-1252?Q?M7aM+wQSGwX2Y2Izt6TEpd8gwfHRZYW1OM5z6+UdqiEGy/tM0K+YDZq5?= =?Windows-1252?Q?eCTwY4p3z11OGdjGevCn34HZLSaTc13VrErNV7TxwTEekvtamrl/6zIu?= =?Windows-1252?Q?lZluJJnt0tk+NFhpomzzyt5rqtEeouB9/zJjhwY0bp3Mvw2B/6LYV1ol?= =?Windows-1252?Q?XpEEBkyBy0DKRdReMOtCKMcTAwXl780kFlq8QltOx7mI+aKe4S6Ht+c8?= =?Windows-1252?Q?WAzKpYl/qtFcFa/O5J5gkzX5rdUYR02fGkc0hgIu6dKHATc4QhzZHGBM?= =?Windows-1252?Q?1KXksYefyZtfyyTAtcugOaaW+aRfn1pWha6MQIGEm3xCxKlEPc2xIakc?= =?Windows-1252?Q?x+ZGI5fJusJ91QYqcN1JXxbN/qftY9Pj1gD0JfcaySFY1bhlLiah0XS0?= =?Windows-1252?Q?8jiaQiLr4dJMlgl3S/L3jPTkapD3of93vzqNN/1KZPnCsjVXHCfL/LLZ?= =?Windows-1252?Q?PBN263qLR8noEdJmbLBt3xvxQMBR8vQjGYFZ2fnBVRpHlJwqAlxuaNfA?= =?Windows-1252?Q?0wWZF+QIUjhFQQAw/kolVrJvo/db8R4IORZ22Ffwmvb9T+3sxu/rgZoy?= =?Windows-1252?Q?DJMK8zu69L6NwCSOU1c6tBHYFp5eKowtDaHC34/O2R3VyfD/2/dn+fQh?= =?Windows-1252?Q?XzDG6kNn+1uMo09kiHdXVB9O3NTIYRMIypTiNcW0gWxrxlU9wvDKV69O?= =?Windows-1252?Q?Mcw7BgCw9dBWOdIh/Lb4hEI7qTMY27OjDpZj4wKFWbFDwVB2pD9HxzHJ?= =?Windows-1252?Q?Jbsw4da87Cm5zdLXpcu3whczZFPAgIkZPuAq5i/z1MG/nUiyN1QpS5lG?= =?Windows-1252?Q?HxwAxW2jfA4W4fyCl/GziyRARJ3pZ0VZiJHkPvZFw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2697; 6:2Tksx/8qS7+S4SP9HNR/6gr6XbF9XkjvqhE6kEpo4+tEAXSu+b1LllwNSHsg20X+771VriBkSr3KuU80Qbb0WMqXkMb+XSdsZspMBPLslOIuyO1xE+34dEGBGoN05Lu4UDJYZBpYv5OOYIcQyQMWQ3bTIZqLA/sf0NfI7rYWLSlmMAf5LEb71L289VAYggOBfApdGcpi7x7QjIcshZtzgb7rOb9L1G85sbMH4vjQb7Zk5luBkfyIr7c/eGNbmsOyldCIy9oYnOUKUjx9Dby3R2cuVokWEycYj55adLT1/VGbtPZ9Zs8lKtZ99h/6csoxSebMNP5JJj+qbXNxOsIoQw==; 5:eJuUuZJirypZL+fXn3XOXIoezYm+mc+oZi1TSOgFz+QuJE2Tqax1EcJkX5Om6NX2qESgC+2cZabUHPNM93PX1bbQ70q22ahTGXYxWwEjqNtTb/zLrbJAnqpw+E06xFfP3PkcvFm5gzdpPWF9778/2g==; 24:iaQMo/iLa+4Id2CThavY4T7aYftatOQqSp7/r/bZQ6uQWM5xK+w3eL4P9UPRI+i/CB8Cqfhl7JsTAvuc4Rh26p0u4x8n7uAnVD3VZbmQLjg=; 7:uBuXuA8rWPGCVIErjCbClTX9NUHfvxosFvwgc2km9C3LaOnxUtuPXXFOiktMr3pZPSYX6+BE9y69DcP7h2cKxREAdjO0ZlCMn4fphMoODJquxKRUrmpPYSDCexKus2vWyFrmwv2mTxh5jH+vvSX+417yLaj9FVI3gTV9R0/tjHrCz9YUIFkIsd5o+q8vai190tL52vbX3eGyKmUSIwB6R1JrX6suOOYm3pFev4kyDJs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2017 11:36:19.4051 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2697 Subject: Re: [dpdk-dev] [PATCH] eal: bus scan and probe never fail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 11:36:21 -0000 Tested-by: Hemant Agrawal On 8/12/2017 3:52 PM, Shreyansh Jain wrote: > Bus scan is responsible for finding devices over *all* buses. > Some of these buses might not be able to scan but that should > not prevent other buses to be scanned. > > Same is the case for probing. It is possible that some devices which > were scanned didn't have a specific driver. That should not prevent > other buses from being probed. > > Signed-off-by: Shreyansh Jain > > --- > Until now, this decision was left onto author of bus specific scan and > probe function. But, that is incorrect. > --- > lib/librte_eal/common/eal_common_bus.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c > index 08bec2d..58e1084 100644 > --- a/lib/librte_eal/common/eal_common_bus.c > +++ b/lib/librte_eal/common/eal_common_bus.c > @@ -73,11 +73,9 @@ rte_bus_scan(void) > > TAILQ_FOREACH(bus, &rte_bus_list, next) { > ret = bus->scan(); > - if (ret) { > + if (ret) > RTE_LOG(ERR, EAL, "Scan for (%s) bus failed.\n", > bus->name); > - return ret; > - } > } > > return 0; > @@ -97,20 +95,16 @@ rte_bus_probe(void) > } > > ret = bus->probe(); > - if (ret) { > + if (ret) > RTE_LOG(ERR, EAL, "Bus (%s) probe failed.\n", > bus->name); > - return ret; > - } > } > > if (vbus) { > ret = vbus->probe(); > - if (ret) { > + if (ret) > RTE_LOG(ERR, EAL, "Bus (%s) probe failed.\n", > vbus->name); > - return ret; > - } > } > > return 0; >