DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] Building current 1.8.1-rc1 with clang
@ 2014-09-29 21:50 Wiles, Roger Keith
  2014-09-30  9:34 ` Bruce Richardson
  2014-09-30  9:40 ` [dpdk-dev] [PATCH] ixgbe: Fix clang compilation issue Bruce Richardson
  0 siblings, 2 replies; 7+ messages in thread
From: Wiles, Roger Keith @ 2014-09-29 21:50 UTC (permalink / raw)
  To: <dev@dpdk.org>

I just pulled the current repo and stated a build with ‘make install T=x86_64-native-linuxapp-clang’ which produced the following error. I do not think I am allowed to modify this file, correct? If that is the case then someone will have to update the original source. If you want me to submit a patch I can, but I do not think I fully understand what needs to be done. 

>From what I can tell the line:
	dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0);
needs to be:
	dma_addr0 = _mm_setzero_si128();

== Build lib/librte_pmd_ixgbe
  CC ixgbe_common.o
  CC ixgbe_82598.o
  CC ixgbe_82599.o
  CC ixgbe_x540.o
  CC ixgbe_phy.o
  CC ixgbe_api.o
  CC ixgbe_vf.o
  CC ixgbe_dcb.o
  CC ixgbe_dcb_82599.o
  CC ixgbe_dcb_82598.o
  CC ixgbe_mbx.o
  CC ixgbe_rxtx.o
  CC ixgbe_ethdev.o
  CC ixgbe_fdir.o
  CC ixgbe_pf.o
  CC ixgbe_rxtx_vec.o
/home/keithw/projects/dpdk-code/org-dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:67:30: error: variable 'dma_addr0' is uninitialized
      when used here [-Werror,-Wuninitialized]
                        dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0);
                                                  ^~~~~~~~~
/home/keithw/projects/dpdk-code/org-dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:57:2: note: variable 'dma_addr0' is declared here
        __m128i dma_addr0, dma_addr1;
        ^
1 error generated.
make[5]: *** [ixgbe_rxtx_vec.o] Error 1
make[4]: *** [librte_pmd_ixgbe] Error 2
make[3]: *** [lib] Error 2
make[2]: *** [all] Error 2
make[1]: *** [x86_64-native-linuxapp-clang_install] Error 2
make: *** [install] Error 2

Thanks
++Keith

Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH] ixgbe: Fix clang compilation issue
@ 2014-10-22 10:54 Bruce Richardson
  2014-10-22 10:55 ` Richardson, Bruce
  0 siblings, 1 reply; 7+ messages in thread
From: Bruce Richardson @ 2014-10-22 10:54 UTC (permalink / raw)
  To: dev

Issue reported by Keith Wiles.
Clang fails with an error about a variable being used uninitialized:

  CC ixgbe_rxtx_vec.o
/home/keithw/projects/dpdk-code/org-dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:67:30:
error: variable 'dma_addr0' is uninitialized
      when used here [-Werror,-Wuninitialized]
                        dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0);
                                                  ^~~~~~~~~

This error can be fixed by replacing the call to xor which
takes two parameters, by a call to setzero, which does not take any.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
index 457f267..2236250 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
@@ -64,7 +64,7 @@ ixgbe_rxq_rearm(struct igb_rx_queue *rxq)
 				 RTE_IXGBE_RXQ_REARM_THRESH) < 0) {
 		if (rxq->rxrearm_nb + RTE_IXGBE_RXQ_REARM_THRESH >=
 		    rxq->nb_rx_desc) {
-			dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0);
+			dma_addr0 = _mm_setzero_si128();
 			for (i = 0; i < RTE_IXGBE_DESCS_PER_LOOP; i++) {
 				rxep[i].mbuf = &rxq->fake_mbuf;
 				_mm_store_si128((__m128i *)&rxdp[i].read,
-- 
1.9.3

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-10-22 10:47 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-29 21:50 [dpdk-dev] Building current 1.8.1-rc1 with clang Wiles, Roger Keith
2014-09-30  9:34 ` Bruce Richardson
2014-09-30  9:40 ` [dpdk-dev] [PATCH] ixgbe: Fix clang compilation issue Bruce Richardson
2014-09-30 13:46   ` Wiles, Roger Keith
2014-09-30 17:14     ` Thomas Monjalon
2014-10-22 10:54 Bruce Richardson
2014-10-22 10:55 ` Richardson, Bruce

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).