* [dpdk-dev] [PATCH] app/test: fix uninitialized port configuration
@ 2018-07-31 14:16 Radu Nicolau
2018-08-01 9:56 ` Iremonger, Bernard
0 siblings, 1 reply; 3+ messages in thread
From: Radu Nicolau @ 2018-07-31 14:16 UTC (permalink / raw)
To: dev; +Cc: olivier.matz, Radu Nicolau, stable
test_pmd_ring_pair_create_attach() uses an uninitialized
struct rte_eth_conf object
Fixes: 51f567129c94 ("app/test: add pmd_ring")
Cc: stable@dpdk.org
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
test/test/test_pmd_ring.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/test/test/test_pmd_ring.c b/test/test/test_pmd_ring.c
index 2196201..19d7d20 100644
--- a/test/test/test_pmd_ring.c
+++ b/test/test/test_pmd_ring.c
@@ -218,6 +218,8 @@ test_pmd_ring_pair_create_attach(int portd, int porte)
struct rte_mbuf buf, *pbuf = &buf;
struct rte_eth_conf null_conf;
+ memset(&null_conf, 0, sizeof(struct rte_eth_conf));
+
if ((rte_eth_dev_configure(portd, 1, 1, &null_conf) < 0)
|| (rte_eth_dev_configure(porte, 1, 1, &null_conf) < 0)) {
printf("Configure failed for port\n");
--
2.7.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/test: fix uninitialized port configuration
2018-07-31 14:16 [dpdk-dev] [PATCH] app/test: fix uninitialized port configuration Radu Nicolau
@ 2018-08-01 9:56 ` Iremonger, Bernard
2018-08-01 14:09 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Iremonger, Bernard @ 2018-08-01 9:56 UTC (permalink / raw)
To: Nicolau, Radu, dev; +Cc: olivier.matz, Nicolau, Radu, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Radu Nicolau
> Sent: Tuesday, July 31, 2018 3:16 PM
> To: dev@dpdk.org
> Cc: olivier.matz@6wind.com; Nicolau, Radu <radu.nicolau@intel.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] app/test: fix uninitialized port configuration
>
> test_pmd_ring_pair_create_attach() uses an uninitialized struct rte_eth_conf
> object
>
> Fixes: 51f567129c94 ("app/test: add pmd_ring")
> Cc: stable@dpdk.org
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix uninitialized port configuration
2018-08-01 9:56 ` Iremonger, Bernard
@ 2018-08-01 14:09 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-08-01 14:09 UTC (permalink / raw)
To: Nicolau, Radu; +Cc: stable, Iremonger, Bernard, dev, olivier.matz
> > test_pmd_ring_pair_create_attach() uses an uninitialized struct rte_eth_conf
> > object
> >
> > Fixes: 51f567129c94 ("app/test: add pmd_ring")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-01 14:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-31 14:16 [dpdk-dev] [PATCH] app/test: fix uninitialized port configuration Radu Nicolau
2018-08-01 9:56 ` Iremonger, Bernard
2018-08-01 14:09 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).