From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) by dpdk.org (Postfix) with ESMTP id 9D79ECB90 for ; Wed, 15 Jun 2016 18:14:00 +0200 (CEST) Received: by mail-lf0-f51.google.com with SMTP id q132so19163603lfe.3 for ; Wed, 15 Jun 2016 09:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=l+GdctFcQqrXo1fXeJizG/DkEyxU1Ukh6kxB3u/nA8Q=; b=D68zR8s2SF8BGMxWb/BKo964B7Jw/XK4rCsXa+v4sJuK4S3lXdhtUUKW2yUxiHCj5D 4OwD+vNXOQpFIhVw68GexzXPeaZPel00tBkGL7hwUO+zJGGt//KjjDhxdPiwjAh18HVd +4aZjsE0Lrz/Qnz4Wna+yOSqycC2hGB0WnTsSo/je7LQJ8h2Vo+7SVtzIxQEziES/8Ky n/LP9Z6FrUQKLiqdO6t7y1HV6UJnLoEnrVC3TWyf5J74gOEBp/kVwwLokDcJiA5VJ5Mp M3WBqbUFaVZuXv5Kez3bo6nsotBDz4nKhMuio9kjo0cTKByazDxvZ0S/k3rjrhnjlqbk 7TXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=l+GdctFcQqrXo1fXeJizG/DkEyxU1Ukh6kxB3u/nA8Q=; b=bBHgHQgcZ7ta8lGMlZaabkGCMxkkroKAWHTrEI++sJiEm5hJ4lwLronsb6LULllWo4 FEjDgyfoZskzmDZtHjP3RIyUTf1uM7ATC68sYsD2s+xLaPx780XRE8bCxEYDGF/xbanU 6dAIPPXWWb5FDpYF9of8z8JVyLD5X2lD47nXJoYkatez/ZqoBE3rnZ4FzW/Kb8e4MkYj zmx4VzD5olnmIFLQ6su0FqE8Qab/gU9ncTpB43sCide+9ruES3KCQ4wz7BJh+ndqKvNF sZ0Yj8rxbUGF+x9F7lljnXs+UwocoEuJ1BRQoxkeoYYwaLaTgeXtuhLuFw7D5blqBwYN kyvQ== X-Gm-Message-State: ALyK8tL6fgdJWqaYMo97J2TxbMPgS3I+pBLzCW9PY+lcKbNGYdPaXcf79D1zm84uvebD6uRN X-Received: by 10.28.167.136 with SMTP id q130mr11325337wme.62.1466007239654; Wed, 15 Jun 2016 09:13:59 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id q63sm742149wma.0.2016.06.15.09.13.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jun 2016 09:13:58 -0700 (PDT) From: Thomas Monjalon To: Olivier Matz , Yuanhan Liu Cc: David Marchand , dev@dpdk.org, Chao Zhu , "Xie, Huawei" , Panu Matilainen Date: Wed, 15 Jun 2016 18:13:57 +0200 Message-ID: <4237718.8Pd8NFPdGz@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <574BFDB4.9030109@6wind.com> References: <1463143859-3105-1-git-send-email-olivier.matz@6wind.com> <20160524051552.GQ5641@yliu-dev.sh.intel.com> <574BFDB4.9030109@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Subject: Re: [dpdk-dev] [PATCH v2 5/7] eal/linux: mmap ioports on ppc64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2016 16:14:00 -0000 2016-05-30 10:45, Olivier Matz: > On 05/24/2016 07:15 AM, Yuanhan Liu wrote: > > On Mon, May 23, 2016 at 03:40:58PM +0200, Olivier Matz wrote: > >> For reference, here is the report of the ABI checker for EAL: > >> > >> [=E2=88=92] struct rte_pci_ioport (2) > >> > >> 1 Field len has been added to this type. > >> 1) This field will not be initialized by old clients. > >> 2) Size of the inclusive type has been changed. > >> NOTE: this field should be accessed only from the new librar= y > >> functions, otherwise it may result in crash or incorrect beh= avior > >> of applications. > >> 2 Size of this type has been changed from 16 bytes to 24 bytes. =09= > >> The fields or parameters of such data type may be incorrectly > >> initialized or accessed by old client applications. > >> > >> [=E2=88=92] affected symbols (4) > >> rte_eal_pci_ioport_map ( struct rte_pci_device* dev, int bar, > >> struct rte_pci_ioport* p ) @@ DPDK_16.04 > >> 3rd parameter 'p' (pointer) has base type 'struct rte_pci_ioport'= . > >> rte_eal_pci_ioport_read ( struct rte_pci_ioport* p, void* data, > >> size_t len, off_t offset ) @@ DPDK_16.04 > >> 1st parameter 'p' (pointer) has base type 'struct rte_pci_ioport'= . > >> rte_eal_pci_ioport_unmap ( struct rte_pci_ioport* p ) @@ DPDK_16.= 04 > >> 1st parameter 'p' (pointer) has base type 'struct rte_pci_ioport'= . > >> rte_eal_pci_ioport_write ( struct rte_pci_ioport* p, void const* = data, > >> size_t len, off_t offset ) @@ DPDK_16.04 > >> 1st parameter 'p' (pointer) has base type 'struct rte_pci_ioport'= . > >> > >> > >> My understanding of the comment for this structure is that it's > >> internal to EAL: > >=20 > > I'm not quite sure that is enough. Cc'ed Panu, the guru on ABI stuf= f, > > hopefully he could shed some light on it. > >=20 > >> /** > >> * A structure used to access io resources for a pci device. > >> * rte_pci_ioport is arch, os, driver specific, and should not be = used > >> outside > >> * of pci ioport api. > >> */ > >> struct rte_pci_ioport { > >> ... > >> } > >> > >> So I'd say it's ok to have it integrated for 16.07. > >=20 > > I'll let Thomas to decide it :) >=20 > Panu or Thomas, do you have any comment on this? The user of this struct is virtio. The ABI policy does not apply to drivers: =09- A means Application =09- external drivers must be rebuilt for each new release Thus no problem here.