From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id E724FB4F0
 for <dev@dpdk.org>; Fri, 13 Feb 2015 17:07:28 +0100 (CET)
Received: by mail-wg0-f54.google.com with SMTP id y19so17484464wgg.13
 for <dev@dpdk.org>; Fri, 13 Feb 2015 08:07:28 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=qvO4S5v4AZA0vq4Ir3+2OX+Z2zI+isK6j2O9jB5PQAs=;
 b=ToW9TVqikYWOFcnV3H9mAZSCvDczDU2GA241Sh5jlnK8tK/49T825sJsxzkJXWcJgr
 tVgLe+Om1+/6h28I2b9MCpdc0mEjmjpedBLLOoc1nRi4iJxoeIPtdTKanRlQ4/5Muapb
 89vONtgzNBR1ayNEqvWBbuQwVCaRKzLmL6iz4FZcXE6IpO5xMeGZ5wp6tipfSH2oifGz
 9h74Ys8BEWrj3gqc1HxePLWTy8cpuENrtMuzFBhUuExxivXIRQcsgD7i9o6aHt4fDuiD
 2b/AlILUJ+S7aDmx+nR9ZWmQlTRSx/HSOGfyrX8nHS8RDB9pFZIv0rGBxy9Or09DWVg3
 VKZQ==
X-Gm-Message-State: ALoCoQk23mvKR30vIBcu8Oxum7Y3bM9FzjqxXGvSNgCkk0nNtOUhJXVyiRUxFKHvGh/4PJSGZqJ0
X-Received: by 10.180.96.37 with SMTP id dp5mr8044760wib.64.1423843648738;
 Fri, 13 Feb 2015 08:07:28 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id bf8sm1651995wjb.37.2015.02.13.08.07.27
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 13 Feb 2015 08:07:27 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: John McNamara <john.mcnamara@intel.com>
Date: Fri, 13 Feb 2015 17:06:57 +0100
Message-ID: <4241109.JKBOKelqd6@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <1423841989-9090-2-git-send-email-john.mcnamara@intel.com>
References: <1419266844-4848-1-git-send-email-bruce.richardson@intel.com>
 <1423841989-9090-1-git-send-email-john.mcnamara@intel.com>
 <1423841989-9090-2-git-send-email-john.mcnamara@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: rename callbacks field to
	intr_cbs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Feb 2015 16:07:29 -0000

2015-02-13 15:39, John McNamara:
> From: Richardson, Bruce <bruce.richardson@intel.com>
> 
> The callbacks member of the rte_eth_dev structure has been renamed
> to intr_cbs to make it clear that it refers to callbacks from NIC
> interrupts. This then allows us to add other types of callbacks to
> the structure without ambiguity.

Yes, good.
Actually this callback is used only for link status interrupt, right?
In the patchset for interrupt mode, new callbacks are used, right?
Should we name this callback more precisely?