From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C860A04B8; Tue, 5 May 2020 11:15:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 49C5E1D58F; Tue, 5 May 2020 11:15:27 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 4165F1D508 for ; Tue, 5 May 2020 11:15:26 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 70A6E491; Tue, 5 May 2020 05:15:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 05 May 2020 05:15:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= Yww4f/vcsKSju7+ps35PfFbaEiqUhQt8xzHIbmi2MXU=; b=EXVvdqKRYyMBSXTk CFJc9WVu0raxpeXiu2ECniXs4WWEs9r8H7b055qUFvkRkeEsNWo7DyckwJpKJX2o +nL9A1BYCCuNUdiDxUleSUSsLi6GwT7Q9a95bxeSFPz+NZSNljgqqu22INMbk3ly Xtt3muXmd5/CMZbqK5LrlOAU/J02ib+DGpUAICMqfSRsrpEsiwyXpnCm1509Mxun Qit1y7ltunbi6H38rdZl9R1yeXvZW/7nPmezyOI2p846YXbngF2AftZ7PvNzde1p C8fa8k7lY3y48RhN3lX1gQfjdyCzRj4AdR0YPkgHZuVC6Qqj5TXCXf2tjWXbR24p 1F9IOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Yww4f/vcsKSju7+ps35PfFbaEiqUhQt8xzHIbmi2M XU=; b=sP2u5XYwqm37SXDYepI2bT2bPq0Xaj+aXJDUiHDAz3ZL1ts9BbWhwbi5l +KbOEQYKMqgtBnIAuUiklT2vKi6gZu6O701hSxk0ICH4CIAFviT6HuK40P3iNm2l Txsda84zoNv9f1XjvKGBiKIE7a9kTTQfdmGIjTib3JqGgXa4WC5V5PJtBiC+xrcX piCeoRsvBEyc1lz02Y82Ned2bqsDBrRcx1wslOjVPZyUxnrmbKnzMff1tNxOv97l wDqCD16BfLQCLRXxnc+3elGSsc8a/uWsv8pKJaUcxSmQAA3VL4r4SvVvQ0IPdzMB sS2qLaAeeUa81koA8fzghOwD3/6kQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrjeeigdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5DADC328005D; Tue, 5 May 2020 05:15:22 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob , Rasesh Mody , Ferruh Yigit Cc: dpdk-dev , Jerin Jacob , GR-Everest-DPDK-Dev , Igor Russkikh , Andrew Rybchenko Date: Tue, 05 May 2020 11:15:21 +0200 Message-ID: <4248918.cEBGB3zze1@thomas> In-Reply-To: References: <20200505030943.1091-1-rmody@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] net/qede: restore Tx queue setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/05/2020 10:59, Ferruh Yigit: > On 5/5/2020 7:44 AM, Jerin Jacob wrote: > > On Tue, May 5, 2020 at 8:39 AM Rasesh Mody wrote: > >> > >> Some applications do not explicitly restore Tx queues setup during > >> port re-configuration. This patch adds changes to check for > >> released Tx queues and restore the setup if application doesn't > >> explicitly does that. > > > > +ethdev maintainers. > > > > I think, Ideally, the fix should be in common code if we need to > > support such applications. > > Is this a case application re-configures to increase the number of queues but > doesn't setup new queues? > If so this looks like application error and application should be fixed instead > of recover this in the ethdev. +1