From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B521A0C53; Wed, 3 Nov 2021 11:51:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 927C641134; Wed, 3 Nov 2021 11:51:32 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 18DC1410E5 for ; Wed, 3 Nov 2021 11:51:30 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10156"; a="231321585" X-IronPort-AV: E=Sophos;i="5.87,205,1631602800"; d="scan'208";a="231321585" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 03:51:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,205,1631602800"; d="scan'208";a="599851495" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga004.jf.intel.com with ESMTP; 03 Nov 2021 03:51:29 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 3 Nov 2021 03:51:29 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 3 Nov 2021 03:51:29 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 3 Nov 2021 03:51:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eovu+VrRuL7pfwTeKq7SBB4EHq9IJhINJ1+4zePZn2qNUnJSHutKuXP9hhbVgjd1LVhROwFw0CKoyucAjWVdNzjLOwtNeJeEVCFyoTLbI7lmaMf0Ko8OI8KMdBowkDEcEJWVBbkmZr5PdQUrgldON2G2N3P6Ed8iNXoZM6VK30kv0I4YaXlIaa1ryfLFyGkOlrOLJPQ+0Y60N7o3ca6FfbkzP9meEZ5sfn9yYnNly+O0tPtW4v4oJqjJSbTAFdu09hpgLnAQmg4vBscQBp+yx/M2iXvYNIwZ5aPjss3XaFkHJdD0/4r+nyJN0MNGb1SZ/LBkrt6F/LpOpBuZNDRdCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MuTy1v/Pya26/TazcgRBBPROi5BAzK0vIl41ZJ+/eHQ=; b=b4hGeXYg55eLU2xq3HAzQ4CswyQ0gfnOW3tTSlOvPtByml5IoiDRtOB6uXCPoEvJ+lX1WrZwPUBnU2stg4d7AQCM8j5Uk5/q/uAh45NF895Q6LMfxjd5G9Z/mJ6qswacfsCBK/3xG7dW93AiL4usXdvhlhi0Du4PsTgBww7bCwgs55IvzEoXhos09InUidVZ86GNmqvGBBig7jDstZJ2PPw/C2AHmmIuxGgZPyLGhYsrVivJRdvmexDUV8QG4ox4ItsJMok8AiWsd/OfBf+E05RBCKKmsc2kM7ftiueyP9W2E9t+tSEH3tRlwnwG9daHr3kb/GxY1RCsabdRifiqcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MuTy1v/Pya26/TazcgRBBPROi5BAzK0vIl41ZJ+/eHQ=; b=U1VQgVkv3gRikib6qRfSlDIyOt1u7tzO1CiPfDX5oyNJW2Jb5bv4FE8QZhhJfPIGDolTbtof34E2OUHqPHh1KoE4Kbco6ZSNJHkbQRufR9NUJYTwcQUi/62swIPSmMsEarwlthOkLcy37C/ir4HWHVQ+uDiriM4Tf8q4i7rEJyM= Authentication-Results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) by CO1PR11MB5202.namprd11.prod.outlook.com (2603:10b6:303:95::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Wed, 3 Nov 2021 10:51:28 +0000 Received: from CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::7c6e:d458:33ed:e579]) by CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::7c6e:d458:33ed:e579%8]) with mapi id 15.20.4649.020; Wed, 3 Nov 2021 10:51:28 +0000 To: Akhil Goyal CC: "dev@dpdk.org" , "declan.doherty@intel.com" , "hemant.agrawal@oss.nxp.com" , Hemant Agrawal , "Anoob Joseph" References: <20210903112257.303961-1-radu.nicolau@intel.com> <20211101125815.3219304-1-radu.nicolau@intel.com> <20211101125815.3219304-2-radu.nicolau@intel.com> From: "Nicolau, Radu" Message-ID: <424dc057-add1-ec45-48f1-7e5fee5d8a7e@intel.com> Date: Wed, 3 Nov 2021 10:51:21 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0016.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::28) To CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) MIME-Version: 1.0 Received: from [192.168.1.21] (109.255.186.106) by LO2P265CA0016.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 3 Nov 2021 10:51:26 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a4325c1f-68df-48d1-0e69-08d99eb7e361 X-MS-TrafficTypeDiagnostic: CO1PR11MB5202: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:568; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i+QOASYcUlint+lx9EIYjBveDhSFo101BzPTs107LKLNd0nkIzKLbdT6/HWyL721K1m53fl6dPowJZ7Cc/PNznrqhIkDpzfbuv0jcoD7bM2DFGDe6xxT6mbACqo1qzmtfYlJAQA51jeITpjbFdi9yl4frdqkZR82KCIyQpXiXaALRhLdFpkfHNjwbcJm2rZh4MGRtxRLBDY6k4LBmbdsfJ8GlVXx1nSNlIn34q4895niaZvVkzOIvQ4W+1QfXOSJoRVYkW1zEFhG01unvVQgNXpvxKQnea7f39bbjxaU/tDmUfa3ni4udUKEgenqc8J/QxySHbhOt+uEJM8VJl14xsKewcykziUEq75MGkPZU9jHXeCFOG1Ots9SUju3682ogVR7IalNu2+fVDFAyn2BJGUS0CRjEQfCU9QCkjMModEIErqdVd2JQ3tvgj9j80ccSg+/Ax+Z7+DtEG7htJXa4H4/x4Dao7AXOO6hhF7sXNlm6z2ncBIthU0yNKTAMSFvYjUneUtQp22QEqbOpGUX3V/umeYyw/GSPv58NMde06SmJ2gyiq0a2qQ2Guo0PYZt00/7B7m5U2aZr7hePsKSzKjUlujOEc7jTwbX8tHXgiyBPgg01fTYBrVDmFoRR+aTpjHcsTPK9Tx3gG3eE+a+obca3StBY82suge0tBpjfNvlhQmzBgqjl988aY5F7SLQmBgZTHPuemMDIE8Dpk1AGPY/pamh/5ImFQ/dCyakRBg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(6916009)(31686004)(186003)(956004)(2616005)(86362001)(82960400001)(4744005)(26005)(8936002)(16576012)(6486002)(5660300002)(508600001)(316002)(66556008)(66946007)(36756003)(31696002)(55236004)(54906003)(53546011)(8676002)(38100700002)(4326008)(66476007)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnM1OTcvTCtvZmt0ZWhQZUIyem1RZ2VubXVGeHRNdkhEQVh5TG5qeWJjc3BI?= =?utf-8?B?eEpQdVNydTc2YnlYbHozVHFSem82SXlZNGsrMytmS3dnY1doYmVmWEF0S0J1?= =?utf-8?B?ckljdzhzbXh4ZnBKc2R5WUlUUDFTNXA1TmoyVnQveE5FYk1YN09wYWMvU2RY?= =?utf-8?B?b200QmxvODRnbG9QdjEvL09XTjBFL0VTQVprd3NneFhYWVE5YzRGcHpwdCta?= =?utf-8?B?d1lseUUwRmF0L0Mwc1lFS1FOaDBCTTlPOS9tUE85c2NJOUxnV1VhZWhqc0h4?= =?utf-8?B?bVY3bS9OOWdIczk4YUd5TUNtVW5zcmFxblM5L1lKNUM1aGJSbEp3S2FZZWJD?= =?utf-8?B?dzQ4d0pzRDVDdVNQM0xTeWI0Qis3OXBicW5ZZXlyOW9nR0UwSEtjMm9VK3kx?= =?utf-8?B?TWlSay9RWkJtZVIrbWYwNFRpVkxGbGk5Q3dVdTU5dTk3bnFXS01rOElnZGlx?= =?utf-8?B?WGhIYWFBcDJPTDRnMWlRUWRhQXJhZ2RjQS91cVZ6Z3AxYnZXSVZVcHU4U3p1?= =?utf-8?B?RFhQYnZtajdzNktMUGdHNzRBZlpKSnNpMGtQZUxkR2NuandYSnIrUkpZWTVj?= =?utf-8?B?U0JJSmdqMjJlREhsck9zNUhxcjhxVWwxUkJSOW90ZFF5Z0hJbjFSV0dlb2N0?= =?utf-8?B?WUVoaUpFV1lVdzEvQ0xjbzFjNnJybjExK2hnTE85eFJFSjNJcm1aRnNmb25Z?= =?utf-8?B?ZVI3MERlTElMSjRkem1reXd1UWZqU1A0Ym0vNXFjOGtzRjd6VWs2Und5NTho?= =?utf-8?B?RmZRL2ZUdi9CR29jZ0NrMWM1VytmQ01hRVRWbUI4bWhCUEEyblQ4bnVSWFcz?= =?utf-8?B?Ty9reGgwSVhPdWZxMGFtZm1JOXBhemoxN1VSaFlQUEEvbCs4aFFjNDZncVU3?= =?utf-8?B?c1JpQm54bUtPNWc2eFJsQU1DKzBDMWF6b3FqNVl5K01FNW40ZExLYVNvNllw?= =?utf-8?B?QlJVTjdPK05sUGNYc3ErNDdNZUlmZFhuRWhqYkQ2U0lVZ29WbG05MkhueGRO?= =?utf-8?B?aXBFMnlnNVNsdmQzOXdaV0xBaVoxUXQ3N0tHdzhDemtZc2ZIVy9kU0JCeFpN?= =?utf-8?B?V0NzWFZUbjRlSWV4dHNQR3owSUJLWCttL254SnlVUTBPaHM4VXZ4UDhRMXNj?= =?utf-8?B?TURVSUpiVHNpYkVDeG9xbVc2UTU0OFdqNExXL3NqQkwvbkt5WkhyR1pLbEpn?= =?utf-8?B?cUhRcUR4eHEwYzdoTXBSZ3F2QnRYWDlFdkR1S0MrTUdwU3hKZWFweENVZHpo?= =?utf-8?B?VEh0NnFGbFFoUHFzUW16cXlKeXI1bG9NSjdRN1RXZHZGQURPRnVTcmhJNjdj?= =?utf-8?B?QUpmTTJNWmkxVVBVc1RycXhwTHFDeFdwUkZEeldpeEtBbUtXRGZuOXV2NW9U?= =?utf-8?B?Slp5aCsreG1sL3FpdEtEejhyZ1NoVWMraEZoeCtXTFRMU0x4MXhhejVUWi85?= =?utf-8?B?T3ovTUZCS0d6UFY1Qjd3ZW5USFRuWk5KQ2NoQUprRG1rcnFhZ3lLVjJaMGRW?= =?utf-8?B?RlF6djQwdE1iNWR1U1RIQ0xYSm5CV25mRG05anZnWllGNTlMTENzMjBYeUxS?= =?utf-8?B?MEtYd2JKZlNHOE9ZS00xUk1OcXMzVVlrL1pSTDFJc2ZYQkI1cVpHcTRSdjh1?= =?utf-8?B?RnF2Umdoc25mSitIRmhKMWtiRUZHai9pWTBDR1NsTGpGR1NnOFplMUVQcjFx?= =?utf-8?B?bm9VNDh4K09HN1pVbW90RjNocXpQdUtVaFVnbEFPclJFdVVFdGUvWXBXN21Y?= =?utf-8?B?WmdvTjhwaXhHYWhHSkJtd1FRVjB0ajRCMVpFQTdJYmN0T3hkbGF4S05lMkxO?= =?utf-8?B?L2x5ZkRZdlFLM1dzVUZpMkQ4ZTZaenJXdTIyekVLTjVlZzRiN2xob0Q3RSta?= =?utf-8?B?blFkUHZrdFdTcG9UVFJ4cW5rYmlnTGNRRzVnN1ZKRmdXRTNnc0JGRlZlRGQ4?= =?utf-8?B?RWhnSHBkTU1jdFMzSG1LVGpjcmRNQ0FheDBYN1hqRStZQ2V3cmtDRVBRNzYr?= =?utf-8?B?SEx3WUlPbEpqWEdFcnhaWS9RU0t6dmpuMU1yMUJqR01uejBpeVMxbEw0N1ph?= =?utf-8?B?R3BrdDZTTmpyR25jNkxuSnFnaDF3MzVSOXFRNUQ0dG9aVFZ3bHZyVjZJMGpy?= =?utf-8?B?ZVY0bVp2ODlncHoyZUpLTUI0bUQ3dU5hL0QvckdrMVpseVBoOTNaVEV6NTBn?= =?utf-8?Q?M+f/ptYQisDnmzV5mUfv8jM=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a4325c1f-68df-48d1-0e69-08d99eb7e361 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 10:51:28.3127 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3QuCmxBl/O6HrB8lx8ck+0RfU37ma0uFAysmlqrf0copjTV3kkTsC9hJKXqkwsc7YsJqd3fOitLRHejq6Wl12w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5202 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] [PATCH v6 1/7] examples/ipsec-secgw: add stats interval argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/3/2021 9:23 AM, Akhil Goyal wrote: >> -#if (STATS_INTERVAL > 0) >> struct ipsec_core_statistics { >> uint64_t tx; >> uint64_t rx; >> @@ -94,7 +90,6 @@ struct ipsec_core_statistics { >> } __rte_cache_aligned; >> >> struct ipsec_core_statistics core_statistics[RTE_MAX_LCORE]; >> -#endif /* STATS_INTERVAL */ > Did you check compilation with this patchset? Even CI is reporting compilation issues. > core_statistics need to be declared in .c file. Hi Akhil, I did check on my local dev system and it passed, but I can see the problem. But the issue was not introduced by this patchset, it was only made apparent by removing the #ifdef. It was introduced by this patch: commit 1329602b6c8f20949ebaefb7aa55f7dca6d1b4f4 Author: Anoob Joseph Date:   Wed May 13 23:15:19 2020 +0530     examples/ipsec-secgw: add per-core packet statistics I will send a fix shortly.