From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7936441CB1;
	Thu, 16 Feb 2023 12:28:08 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4F24742BC9;
	Thu, 16 Feb 2023 12:28:08 +0100 (CET)
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])
 by mails.dpdk.org (Postfix) with ESMTP id 87EFD40E0F
 for <dev@dpdk.org>; Thu, 16 Feb 2023 12:28:05 +0100 (CET)
Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.56])
 by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PHXh16NbnzGpX5;
 Thu, 16 Feb 2023 19:26:09 +0800 (CST)
Received: from [10.67.100.224] (10.67.100.224) by
 dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.17; Thu, 16 Feb 2023 19:27:58 +0800
Subject: Re: [PATCH] ethdev: add link speed 400G
To: Thomas Monjalon <thomas@monjalon.net>, <dev@dpdk.org>
CC: Bruce Richardson <bruce.richardson@intel.com>, Jerin Jacob
 <jerinj@marvell.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>, Raslan
 Darawsheh <rasland@nvidia.com>, David Marchand <david.marchand@redhat.com>,
 Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang
 <yuying.zhang@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>, Andrew
 Rybchenko <andrew.rybchenko@oktetlabs.ru>, Maxime Coquelin
 <maxime.coquelin@redhat.com>, Chenbo Xia <chenbo.xia@intel.com>
References: <20230216104350.1639394-1-thomas@monjalon.net>
From: fengchengwen <fengchengwen@huawei.com>
Message-ID: <42504089-306c-2e68-148d-462493b59d8e@huawei.com>
Date: Thu, 16 Feb 2023 19:27:57 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20230216104350.1639394-1-thomas@monjalon.net>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.100.224]
X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To
 dggpeml500024.china.huawei.com (7.185.36.10)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Thomas,

  Higher rates are generally implemented with multiple lanes. The lane configuration is
critical to link negotiation success. The number of lanes configured using the ethtool
is provided [1].

 Currently, the community uses only one u32 bit (link_speed) to indicate a rate, which
is not enough.

 It is recommended that the rate be extended to support the configuration of the number
of lanes. Our team plan to develop it target 23.07 version (have not yet been designed).
Maybe other team already developping it (if have please let me know so that we can reduce
invest).

 Beside, as for this patch, I think we could upstream first.


[1] https://lore.kernel.org/netdev/20201010154119.3537085-1-idosch@idosch.org/T/


On 2023/2/16 18:43, Thomas Monjalon wrote:
> There are some devices supporting 400G speed,
> and it is well standardized in IEEE.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Chengwen Feng <fengchengwen@huawei.com>