From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] fm10k_rxtx.c does not compile
Date: Wed, 18 Feb 2015 18:18:27 +0100 [thread overview]
Message-ID: <4252267.lcD9EdtIU9@xps13> (raw)
In-Reply-To: <D10A2192.13C81%keith.wiles@intel.com>
Hi Keith,
2015-02-18 17:01, Wiles, Keith:
> I just pulled the code and found a unused function error ‘dump_rxd()’
>
> I had to add the ifdef around the function and remove the ifdef inside the function:
>
> #ifdef RTE_LIBRTE_FM10K_DEBUG_RX
> static inline void dump_rxd(union fm10k_rx_desc *rxd)
> {
> RTE_SET_USED(rxd);
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> PMD_RX_LOG(DEBUG, "| GLORT | PKT HDR & TYPE |");
> PMD_RX_LOG(DEBUG, "| 0x%08x | 0x%08x |", rxd->d.glort,
> rxd->d.data);
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> PMD_RX_LOG(DEBUG, "| VLAN & LEN | STATUS |");
> PMD_RX_LOG(DEBUG, "| 0x%08x | 0x%08x |", rxd->d.vlan_len,
> rxd->d.staterr);
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> PMD_RX_LOG(DEBUG, "| RESERVED | RSS_HASH |");
> PMD_RX_LOG(DEBUG, "| 0x%08x | 0x%08x |", 0, rxd->d.rss);
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> PMD_RX_LOG(DEBUG, "| TIME TAG |");
> PMD_RX_LOG(DEBUG, "| 0x%016lx |", rxd->q.timestamp);
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> }
> #endif
>
> Also clang on Ubuntu 14.04 does not like the option:
> CC fm10k_pf.o
> error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option]
Thanks for reporting.
I have no error with GCC 4.9.2.
Please could you try to send a patch?
next prev parent reply other threads:[~2015-02-18 17:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 17:01 Wiles, Keith
2015-02-18 17:18 ` Thomas Monjalon [this message]
2015-02-18 17:29 ` Wiles, Keith
2015-02-18 18:10 ` Jeff Shaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4252267.lcD9EdtIU9@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).