From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 76918A00E6
for <public@inbox.dpdk.org>; Thu, 8 Aug 2019 09:22:45 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 868FF276C;
Thu, 8 Aug 2019 09:22:44 +0200 (CEST)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
[66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 9E4EA2082;
Thu, 8 Aug 2019 09:22:43 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 1C19021EBC;
Thu, 8 Aug 2019 03:22:43 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Thu, 08 Aug 2019 03:22:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=dn81nZMeunSr/LUZTWGGrfzvkxbQJ4MRTN1RQV88Cuo=; b=k11ctBIiIgWs
cegfyBqJXXXqyIVRvrBy/efgwSDV6F23quK86eR82RfmTCgjZ+0oKsvuLdlu8Z76
YUZpX+CL8M7KC0PmvTewm4WrFBBwhvZjp1uMcwv7ofmjHhcoYviixF7BcslNlXwq
KpfeQnXh8TEw4WHU0HjEBbWnLykJJeQ=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm3; bh=dn81nZMeunSr/LUZTWGGrfzvkxbQJ4MRTN1RQV88C
uo=; b=DiFGDFs6dIoSL724Qhjysv7gu7YeTYtgduM5Bi0cBSGJPjQfGZ6Zlw/xF
UfgWZM5BzlsAPjY4DobwpZt9EoTus9bFE35iomNoC0tHWzugjMikgv7TYyGJ20u5
BqKucbhWQzzPHrKmNgAL6BDMfD36MEz8BenBvJZ+FxDxrqEzkjoIkPAMk1VoUFX4
9XpnqrAF2AHLlbBIZssI9Y6pIMKkz7eCSuY8+6aUBfEsMGN8aFPTSJ6bMjA3v0HF
Mr6OjwAOZ0NuaQkp5VDyXZFcxkZolH7k9V1cDoQa+YzT/bIrw5Aoh3IQORYE+Ww9
hYrxgpaMiduXa/omkA1D3OAjPo/Eg==
X-ME-Sender: <xms:ws1LXbO9zBE7YPRuk5zqIfJSbOz4njhzgduGlihqyn3Mpx45qlN5_Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddruddugedgledvucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf
hppeelfedriedrudegledruddugeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm
rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:ws1LXW2r4gALEl8AzjxW5n0dEZyaMcoxy3t7jsB0Xqz6Z5u80jE4PQ>
<xmx:ws1LXeeWi4fcmlT8hEcweDXu_HOo5g89jmKXWHdg3Wop5z_MyUMnbQ>
<xmx:ws1LXShFTAj_IFsirTEfnrs5t6yg0BRP9mdE9fnqeJnKMtDFw3VQKg>
<xmx:w81LXdNloZLt8X3FuauCxBa2p0th6Ax-F1UKMcsZ5bf8wxjqYbu2uA>
Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114])
by mail.messagingengine.com (Postfix) with ESMTPA id AF45380069;
Thu, 8 Aug 2019 03:22:41 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Akhil Goyal <akhil.goyal@nxp.com>
Cc: stable@dpdk.org, Bernard Iremonger <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>
Date: Thu, 08 Aug 2019 09:22:40 +0200
Message-ID: <4252912.OkXEp6FMEK@xps>
In-Reply-To: <VE1PR04MB6639A528C450CB99A79E421BE6D40@VE1PR04MB6639.eurprd04.prod.outlook.com>
References: <1565181012-19553-1-git-send-email-bernard.iremonger@intel.com>
<VE1PR04MB6639A528C450CB99A79E421BE6D40@VE1PR04MB6639.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/ipsec-secgw: fix
unchecked return value
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
07/08/2019 15:39, Akhil Goyal:
>
> >
> > Check the return value of the rte_eth_dev_rss_hash_conf_get function.
> >
> > Coverity issue: 344970
> > Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with inline crypto")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > ---
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
>
> Thomas,
> Could you please take this patch directly to master.
It doesn't look critical at all.
Why do you want this in DPDK 19.08 without enough time for proper validation testing?