From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id DD555A0545;
Tue, 21 Jun 2022 18:21:22 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 821B44069C;
Tue, 21 Jun 2022 18:21:22 +0200 (CEST)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id B25C240151;
Tue, 21 Jun 2022 18:21:20 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
by mailout.nyi.internal (Postfix) with ESMTP id 3BEE95C00CB;
Tue, 21 Jun 2022 12:21:20 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute2.internal (MEProxy); Tue, 21 Jun 2022 12:21:20 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:date:date:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:sender:subject:subject:to:to; s=fm2; t=1655828480; x=
1655914880; bh=4BqCsQuT2Sulz9qY3B9VcVwKBDnN94UBWQt97/FOIg4=; b=O
ha2meXIWxtlGbpugBRP260Vwt52sAAAsHgCf8p5NRCfdsIsip4BcOv1UzDmBt4dm
Kqk8iTgBToJh1OvjWAJ4o7tBr8pN11VaHRhTX5IriKHBaQZB4mW7xBJSfBdx/U36
Y/74HvlKKKOmR5Bl+5csvqN6VX//ADd7+mCEAed0XhhfMkJ1k3v0p9mNLcngcQyH
dUfBdMJGL2GHWyuTaA4lwtXlw7tHM/XZxrI3Ej/L1Y9/4yEWIBZLN/eUKWwOXCix
pqETrjPHOIu/qzTmJX6bhkr0ebBIF7cYI1cz0LI9np8xXbHxVyUWTblaa/KCZEd4
6EF2Kq8CZnjg0OYOE36CQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:date:date:feedback-id:feedback-id:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1655828480; x=
1655914880; bh=4BqCsQuT2Sulz9qY3B9VcVwKBDnN94UBWQt97/FOIg4=; b=d
R77XwXsarBlPZL9DWjXrYY6MWd62351tVgspisgPn8aNAlPm1d7B++67pRS82LvZ
sRumvPw8ZFw8uoHtfPwaMu97bvpasgg4TtqUcIAclqSDJXJJ7q1VOdpPVu9mQtNh
+hvzBkvavV4nu1/9MmnRsHX0nyDGfvFYk65WkBL6LdUrURG15Ljc7Z2ihniwfyFJ
I1ElMC/ncGme0HFpt+BKjgVHI3R3t79t8bvrt0AB0APZeAjXSZWozo2sV+mWwwJu
F1ilrNA0YFvmi3kkEgnQCEGon2KhhZiqGsb313VjLbTVsSNIeMZkmSH8KZYgvO5Y
8HJ98jDy0Eu2biggiVpxQ==
X-ME-Sender: <xms:_--xYlNTEzixQfhFIouMC9QL5CDmaKEwO83OepXTQvTv0hnf6-ojNQ>
<xme:_--xYn8okU9HC9VQ1ass5E1Ds2dLQaVQzyJ8MKGXa2Y_o_ukg1o1nfcDUXihGanAq
Bpru6mI9J-8WQ_0Jw>
X-ME-Received: <xmr:_--xYkSwpLmeAv98UYVnTiNmvyN-ivXpTzdLwroskqe4KekgEv0CZCUvyRQGR4hK2hQD43kMgkBwIVDpfptJZt9bQQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeffedgleelucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei
kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:_--xYhuRD71gBg89iu1innrG7hTmuFmTOq4rWFH-sVf9TVpff5c0Zw>
<xmx:_--xYtfOJudxCkUytNlY_sCxlkJv7YKlzwSHRGFgm_w_t1Xo7Cv6Ew>
<xmx:_--xYt3XderRRp5mw-HWe7eerZ-1g0g81_SBVilyuPDgNYBQ5RgegQ>
<xmx:APCxYlQzmPBneBCMvhBz_F3O6hbRiATLfyzct4bF_fBt3VtBiIVRow>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
21 Jun 2022 12:21:18 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, stable@dpdk.org, "Liu,
Yongxin" <yongxin.liu@windriver.com>, "stable@dpdk.org" <stable@dpdk.org>,
"Laatz, Kevin" <kevin.laatz@intel.com>,
Chengwen Feng <fengchengwen@huawei.com>, "Walsh,
Conor" <conor.walsh@intel.com>
Subject: Re: [PATCH] dma/idxd: fix AVX2 code in non-datapath functions
Date: Tue, 21 Jun 2022 18:21:16 +0200
Message-ID: <4253453.687JKscXgg@thomas>
In-Reply-To: <SA2PR11MB521067C14B9DCE6E23398AEEFFB09@SA2PR11MB5210.namprd11.prod.outlook.com>
References: <20220617105920.354707-1-bruce.richardson@intel.com>
<SA2PR11MB521067C14B9DCE6E23398AEEFFB09@SA2PR11MB5210.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
20/06/2022 11:20, Walsh, Conor:
> > While all systems which will use the idxd driver for hardware will
> > support AVX2, if the driver is present the initialization functions e.g.
> > to register logs, will be called on all systems - irrespective of HW
> > support. This can cause issues if the system running DPDK does not have
> > AVX2, and the compiler has included AVX instructions in the
> > initialization code.
> >
> > To fix this, remove AVX2 instruction set from the whole build of the
> > driver. Instead, we add "target(avx2)" attribute to all datapath
> > functions, so those - and only those functions - will having AVX2
> > instructions in them.
> >
> > Bugzilla ID: 1038
> > Fixes: 3d36a0a1c7de ("dma/idxd: add data path job submission")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: Conor Walsh <conor.walsh@intel.com>
Applied, thanks.