From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54BA2432BA; Mon, 6 Nov 2023 16:32:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED3E8402D5; Mon, 6 Nov 2023 16:32:54 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 11832402C2; Mon, 6 Nov 2023 16:32:54 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7FDC65C01E2; Mon, 6 Nov 2023 10:32:53 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 06 Nov 2023 10:32:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699284773; x=1699371173; bh=gNEncVFn+6+EzahlWChOpDDvw6CBpVW/w6J pr89qGdY=; b=oLW3W+h/XZhpDAoCfsoVgA1pssiJJwl7BSKacn+viuVKC37umZ0 scUAjLE+HJ7EWgRlOh/k8eJzamAkwaDSj9o0V2B3oy6zeQH8MKcexKSVNB4oUa5n 4tIwBr3GiTVDVhi5zn+OIJaiAjIpCxpLvAqWwqAAxC/AxZJCT/tTqxHOlbEGLkqV SlVm8YFbiBgyuhjdVcjYHh4fgXeuQ5UxpPUvUNeBwLAPZG7832Q7cdHMiBNBMIMa FHm4Vj5r9kEFoUqi/CMx3KDrZxXJVWaGZCccwW44CIzJIN0Zr1lYzsoN9d5+wm48 1lBzIRfqKmfSJ10T0aUDddDKMjmuxrQJXUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699284773; x=1699371173; bh=gNEncVFn+6+EzahlWChOpDDvw6CBpVW/w6J pr89qGdY=; b=c+WEKhtEejiN/eQJDOeuCTE6BjFHqofRpZ7Zvf8766X3dmCYCpi BTj42blvCKxOEfuYixPuT63Uo2Lph5yi6BtCcJ9mfpnF/IPzvr0Me8kjHXfmC7Lv Ac+TmEVzm3jrdK8KdFwEV3tEXQFk6GGXjTmGlC2cxyU50YKNXwYK1WAYsPNBnBAu w5YTgDKCZZ5/S6y3HfBeqDboD7ys/FxeI3ade2VJh5IjxY47xhoQBB68MQGN5u+F 9w2lwqTDTNpT9++6dX+zZYt6zgBW5ctrtgrfNHIFpc6ySN1y4Hvoe6IZrEas0obA sXbMyrucicefMIKBzgVsg8rJ+5QsSL/jO5A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddugedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Nov 2023 10:32:51 -0500 (EST) From: Thomas Monjalon To: Srikanth Yalavarthi , Bruce Richardson Cc: dev@dpdk.org, Aaron Conole , Igor Russkikh , David Marchand , dev@dpdk.org, sshankarnara@marvell.com, aprabhu@marvell.com, ptakkar@marvell.com, stable@dpdk.org Subject: Re: [PATCH v5 1/1] build: add libarchive to external deps Date: Mon, 06 Nov 2023 16:32:50 +0100 Message-ID: <4260437.mogB4TqSGs@thomas> In-Reply-To: <1815115.8hzESeGDPO@thomas> References: <20231020170135.18319-1-syalavarthi@marvell.com> <1815115.8hzESeGDPO@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 06/11/2023 16:24, Thomas Monjalon: > 06/11/2023 09:53, Bruce Richardson: > > On Sun, Nov 05, 2023 at 08:12:43PM -0800, Srikanth Yalavarthi wrote: > > > In order to avoid linking with Libs.private, libarchive > > > is not added to ext_deps during the meson setup stage. > > > > > > Since libarchive is not added to ext_deps, cross-compilation > > > or native compilation with libarchive installed in non-standard > > > location fails with errors related to "cannot find -larchive" > > > or "archive.h: No such file or directory". In order to fix the > > > build failures, user is required to define the 'c_args' and > > > 'c_link_args' with '-I' and '-L'. > > > > > > This patch adds libarchive to ext_deps and further would not > > > require setting c_args and c_link_args externally. > > > > > > Fixes: 40edb9c0d36b ("eal: handle compressed firmware") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Srikanth Yalavarthi > > > > Acked-by: Bruce Richardson > > I'm not sure to understand which new failure will happen. > Was there a problem solved in new libarchive packages? BTW applied as it fixes an obvious problem.