DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Matthew Hall <mhall@mhcomputing.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/4] virtio-net.c: incorrect parens around equality check
Date: Tue, 22 Jul 2014 15:14:51 +0200
Message-ID: <42607666.SQuAkzsMo0@xps13> (raw)
In-Reply-To: <1405914461-19335-3-git-send-email-mhall@mhcomputing.net>

Hi Matthew,

I think that patches 1, 3 and 4 need some rework but this one is valid
and has no relation with other ones in the serie. So it can be integrated now.

2014-07-20 20:47, Matthew Hall:
> --- a/examples/vhost/virtio-net.c
> +++ b/examples/vhost/virtio-net.c
> @@ -280,8 +280,8 @@ get_config_ll_entry(struct vhost_device_ctx ctx)
>  
>  	/* Loop through linked list until the device_fh is found. */
>  	while (ll_dev != NULL) {
> -		if ((ll_dev->dev.device_fh == ctx.fh))
> -            return ll_dev;
> +		if (ll_dev->dev.device_fh == ctx.fh)
> +			return ll_dev;
>  		ll_dev = ll_dev->next;
>  	}

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied for version 1.7.1.

Thanks
-- 
Thomas

  reply	other threads:[~2014-07-22 13:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-21  3:47 [dpdk-dev] [PATCH] examples: fix clang compilation issues Matthew Hall
2014-07-21  3:47 ` [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in l3fwd-acl Matthew Hall
2014-07-21 13:44   ` Thomas Monjalon
2014-07-21 16:53     ` Matthew Hall
2014-07-21 17:37   ` Richardson, Bruce
2014-07-21  3:47 ` [dpdk-dev] [PATCH 2/4] virtio-net.c: incorrect parens around equality check Matthew Hall
2014-07-22 13:14   ` Thomas Monjalon [this message]
2014-07-22 19:27     ` Matthew Hall
2014-07-21  3:47 ` [dpdk-dev] [PATCH 3/4] examples/*: -Wno-switch required for weird ioctl() ID's Matthew Hall
2014-07-21 13:45   ` Thomas Monjalon
2014-07-21  3:47 ` [dpdk-dev] [PATCH 4/4] rte.extvars.mk: allow user to override RTE_SDK_BIN Matthew Hall
2014-07-21 14:31   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42607666.SQuAkzsMo0@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=mhall@mhcomputing.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git