From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 50719B36D for ; Tue, 22 Jul 2014 15:13:40 +0200 (CEST) Received: by mail-wi0-f182.google.com with SMTP id d1so384015wiv.15 for ; Tue, 22 Jul 2014 06:14:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=X5LhL0GG4bmaJVzZPerT/0qxeYnlsrvS6wyV8P+1YE8=; b=CbEUkjNz3XAiKGCJWEE9kb3l3GVqNIRxC01EUsAOffhtU+tkqW54e3CNIpygs5N1S+ VjxI3g/0uT2rCMq+V2n286I/313SGjcnqJx9wDrIyeac4jSf9VWrVKFNeneUFocJ+duZ ATFGrwsINjKbxGqs15cUwblgQ6IusOC0Ltx3hT2b8OYxxddXwZuhAUXdWyLklWzILlPk IA5A0lh+iXvdSJ4wUDOV6D+zqmPOj3cbEAH/WdTvrzSDB1otlXXJDpYlVfBCUkfVfxth Fncu1T3Q2H9iza/jYqyNZk8c1l53I5O7yfyLjDnHk1KDs+4veHl+N2eBpRvPCvpZUWur 03ag== X-Gm-Message-State: ALoCoQkqNSqYcVADEyG6elP8Eeg2bYpsqCt323URYLeeWBpaSgGH8jY4r2EqGuI/mOdXyEn6Coyh X-Received: by 10.194.100.34 with SMTP id ev2mr33368197wjb.76.1406034899111; Tue, 22 Jul 2014 06:14:59 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id 19sm972056wjz.3.2014.07.22.06.14.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Jul 2014 06:14:58 -0700 (PDT) From: Thomas Monjalon To: Matthew Hall Date: Tue, 22 Jul 2014 15:14:51 +0200 Message-ID: <42607666.SQuAkzsMo0@xps13> Organization: 6WIND User-Agent: KMail/4.13.2 (Linux/3.15.5-2-ARCH; KDE/4.13.2; x86_64; ; ) In-Reply-To: <1405914461-19335-3-git-send-email-mhall@mhcomputing.net> References: <1405914461-19335-1-git-send-email-mhall@mhcomputing.net> <1405914461-19335-3-git-send-email-mhall@mhcomputing.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/4] virtio-net.c: incorrect parens around equality check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2014 13:13:40 -0000 Hi Matthew, I think that patches 1, 3 and 4 need some rework but this one is valid and has no relation with other ones in the serie. So it can be integrated now. 2014-07-20 20:47, Matthew Hall: > --- a/examples/vhost/virtio-net.c > +++ b/examples/vhost/virtio-net.c > @@ -280,8 +280,8 @@ get_config_ll_entry(struct vhost_device_ctx ctx) > > /* Loop through linked list until the device_fh is found. */ > while (ll_dev != NULL) { > - if ((ll_dev->dev.device_fh == ctx.fh)) > - return ll_dev; > + if (ll_dev->dev.device_fh == ctx.fh) > + return ll_dev; > ll_dev = ll_dev->next; > } Acked-by: Thomas Monjalon Applied for version 1.7.1. Thanks -- Thomas