DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Pekka Riikonen <priikone@iki.fi>
Cc: dev@dpdk.org, Chenbo Xia <chenbox@nvidia.com>,
	Nipun Gupta <nipun.gupta@amd.com>
Subject: Re: [PATCH] bus/pci: fix automatic interrupt type selection
Date: Fri, 27 Jun 2025 22:08:54 +0200	[thread overview]
Message-ID: <4268105.sGnKIMrFRI@thomas> (raw)
In-Reply-To: <cdbd9d284dd174f99601f032ca6ee8fa@iki.fi>

27/06/2025 21:33, Pekka Riikonen:
> On 2025-06-27 19:00, Thomas Monjalon wrote:
> > 20/06/2025 13:47, priikone@iki.fi:
> >> Check if kernel returns 0 interrupt vectors and try another interrupt
> >> type in that case.  Failing to check the vector count can select an
> >> interrupt type that's unusable.
> >> 
> >> Signed-off-by: Pekka Riikonen <priikone@iki.fi>
> > 
> > Please could you be explicit about the use case you are trying to fix?
> 
> This particular case was with e1000em that only supported INTx, but the 
> function selected MSI-X simply because it's the first one attempted, 
> even though it got 0 vectors.  Enabling interrupts then failed.  If the 
> function had checked the vector count it would have correctly selected 
> INTx.  Now, my setup might have been quite old but it doesn't change 
> that it selected wrong interrupt type.

OK thank you, it helps for the review, and could be added to the commit log.

Adding PCI bus maintainers for review.



      reply	other threads:[~2025-06-27 20:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-20 11:47 priikone
2025-06-27 16:00 ` Thomas Monjalon
2025-06-27 19:33   ` Pekka Riikonen
2025-06-27 20:08     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4268105.sGnKIMrFRI@thomas \
    --to=thomas@monjalon.net \
    --cc=chenbox@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=nipun.gupta@amd.com \
    --cc=priikone@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).