From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AC2A46A75; Fri, 27 Jun 2025 22:09:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E1A84026D; Fri, 27 Jun 2025 22:09:00 +0200 (CEST) Received: from fout-a1-smtp.messagingengine.com (fout-a1-smtp.messagingengine.com [103.168.172.144]) by mails.dpdk.org (Postfix) with ESMTP id 3DE7B400EF for ; Fri, 27 Jun 2025 22:08:59 +0200 (CEST) Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfout.phl.internal (Postfix) with ESMTP id 96DC9EC027C; Fri, 27 Jun 2025 16:08:58 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Fri, 27 Jun 2025 16:08:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1751054938; x=1751141338; bh=CDQmZM8LBB5WLg9AFKO03tZIZqevVAed+R7FqcBxcKk=; b= R2jVWsZBZLnYQ43nx/9n44JDKnvjZpuQ96tstKLsQGzjMSo4eQzV6/QPMMyAb72i co0A+CiBgo/sdBwmrncpSt4GFUBphBq9x3IpxBUuWbQ0Khex8C/W7b7OAqaDcOVf ywYnG3ZOhPqFMY74ufTuXEMxcVHvlyHXLNupB4NXVA9VBqSVKlhdO/vXRoYu78M6 enMGaJHA9/OSE1TZ29E8iqR9PYVK3rg1mNE/YnbP+K0d4SvmUC75sFx481JNvl+V yoDwxtXkWIPgxA2H59CvT3rU0bT9n7svh4v41HkQ59zTLlSt1kAOUKIR6VhIOP7D w806G71S3uQCSLxHblleVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1751054938; x= 1751141338; bh=CDQmZM8LBB5WLg9AFKO03tZIZqevVAed+R7FqcBxcKk=; b=W k/65sBXWNkY3GJeO4HnDmfEomdOb2I0antGjBuZ2hE5XoccitF4dtHbuPnNZIg9M ehJjVX5ikhRlv6hHmaVSxCGFpl0Lsh9f07PgaBMwl6Q3FIwnsI5S3RknUm8DTg3+ xDqEINiXkWhBLdRk3cBGbBWkMQc2T7F+1hIEgkatU9pplOu8MgHcEU9r6vWXjfOk JoCRF7gSTEtHvgWgz1j5iWvlyyNm4XQ2q+WVX1cBF7lHY5bOeah1NScQShKgAUOI qQy8102N7z4xqT6KPTfIeoRxHUEIv23t6rjG90uitctofpwB+QjRZDmmsx2ZvdH+ cbVH4SAMelsZHc2NehMnA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdefleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepvfhhohhmrghsucfo ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtffrrg htthgvrhhnpeejudevheeiveduuddtveffgfdtgeekueevjeffjeegtdeggeekgfdvuefg feekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhnsggprhgtphhtthhopeegpdhmohgu vgepshhmthhpohhuthdprhgtphhtthhopehprhhiihhkohhnvgesihhkihdrfhhipdhrtg hpthhtohepuggvvhesughpughkrdhorhhgpdhrtghpthhtoheptghhvghnsghogiesnhhv ihguihgrrdgtohhmpdhrtghpthhtohepnhhiphhunhdrghhuphhtrgesrghmugdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 27 Jun 2025 16:08:57 -0400 (EDT) From: Thomas Monjalon To: Pekka Riikonen Cc: dev@dpdk.org, Chenbo Xia , Nipun Gupta Subject: Re: [PATCH] bus/pci: fix automatic interrupt type selection Date: Fri, 27 Jun 2025 22:08:54 +0200 Message-ID: <4268105.sGnKIMrFRI@thomas> In-Reply-To: References: <8f5b22d3bedef793bf489c230b52b145@iki.fi> <7218036.9CP3fYhb5E@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 27/06/2025 21:33, Pekka Riikonen: > On 2025-06-27 19:00, Thomas Monjalon wrote: > > 20/06/2025 13:47, priikone@iki.fi: > >> Check if kernel returns 0 interrupt vectors and try another interrupt > >> type in that case. Failing to check the vector count can select an > >> interrupt type that's unusable. > >> > >> Signed-off-by: Pekka Riikonen > > > > Please could you be explicit about the use case you are trying to fix? > > This particular case was with e1000em that only supported INTx, but the > function selected MSI-X simply because it's the first one attempted, > even though it got 0 vectors. Enabling interrupts then failed. If the > function had checked the vector count it would have correctly selected > INTx. Now, my setup might have been quite old but it doesn't change > that it selected wrong interrupt type. OK thank you, it helps for the review, and could be added to the commit log. Adding PCI bus maintainers for review.