DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Trahe, Fiona" <fiona.trahe@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>
Cc: Ray Kinsella <mdr@ashroe.eu>, "dev@dpdk.org" <dev@dpdk.org>,
	"Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
Subject: Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function
Date: Thu, 16 Apr 2020 12:01:01 +0200	[thread overview]
Message-ID: <4271918.xgJ6IN8ObU@thomas> (raw)
In-Reply-To: <20200416095124.GA1691@bricha3-MOBL.ger.corp.intel.com>

16/04/2020 11:51, Bruce Richardson:
> On Wed, Apr 15, 2020 at 06:24:19PM +0100, Trahe, Fiona wrote:
> > 5a. If in 20.05 we add a version of a fn which breaks ABI 20.0, what should the name of the original function be? fn_v20, or fn_v20.0
> 
> In technical terms it really doesn't matter, it's just a name that will be
> looked up in a table. I don't think we strictly enforce the naming, so
> whatever is clearest is best. I'd suggest the former.

Each release can have a new ABI.
The same function can have a different version in 20.02, 20.05 and 20.08.
If you name it fn_v20 in 20.05, what will be the name for the new version
in 20.08? I suggest using the release number when versioning a function.



  reply	other threads:[~2020-04-16 10:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18 20:41 Arek Kusztal
2020-04-14 12:13 ` Akhil Goyal
2020-04-14 13:03   ` Thomas Monjalon
2020-04-14 13:52     ` Trahe, Fiona
2020-04-14 13:54 ` Ray Kinsella
2020-04-14 18:27   ` Trahe, Fiona
2020-04-15 17:24     ` Trahe, Fiona
2020-04-16  9:51       ` Bruce Richardson
2020-04-16 10:01         ` Thomas Monjalon [this message]
2020-04-17  7:24           ` Ray Kinsella
2020-04-17  9:31             ` Bruce Richardson
2020-04-17  9:42               ` Ray Kinsella
2020-04-17 10:17                 ` Thomas Monjalon
2020-04-17 10:33                   ` Ray Kinsella
2020-04-17 11:46                     ` Trahe, Fiona
2020-04-17 16:01                       ` Ray Kinsella
2020-04-20 16:59                       ` Trahe, Fiona
2020-04-20 17:31                         ` Ray Kinsella
2020-04-20 17:37                           ` Thomas Monjalon
2020-04-21  6:01                             ` Ray Kinsella
2020-04-21  9:36                               ` Thomas Monjalon
2020-04-22  8:21                                 ` Ray Kinsella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4271918.xgJ6IN8ObU@thomas \
    --to=thomas@monjalon.net \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=mdr@ashroe.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).