From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0E95A04B1; Thu, 5 Nov 2020 08:12:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7C579594B; Thu, 5 Nov 2020 08:12:52 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 20659592C for ; Thu, 5 Nov 2020 08:12:50 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id DD7859F0; Thu, 5 Nov 2020 02:12:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 05 Nov 2020 02:12:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= XGtQQDBuGOrBpYA0nDe4FjMPuvP6hnT2IxeAqIm8A9A=; b=eJvoX1XNZHPpNMfn vGwsA/zfHtNIump7WD0tXzDiVhu3stwkw6W9T1FTiWJ12kdQkDp7kAAv1WGeeJR9 C1XWEkN1z/Eyc2oklhwxNsD6U1ROXLSE2xfjBHqYmaiw/umVc4PktdjMayXVq11r FUchaKXPinqkjZ2e5/XEj63Dww7/iyG8ubJ07ot7BSZsyA3XXwdyNDhTUsFo+dEv wOsUdBbkRiR6j8xFkcGlZzDHk8mXE7o6kBdKNRZtpixa015WtA85QMGHRNff4Jox teAIgU/sTeDwgid+0ZDJlAYp0jyCWmBiEh9uClJqT6cvSa3ZaoZRBgHF+d76AfCB f123KA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=XGtQQDBuGOrBpYA0nDe4FjMPuvP6hnT2IxeAqIm8A 9A=; b=lxkQcZ04k7DS+Z9M036YAkixMuN2ACMyXXkq36qK/4mxj43zthJ9/2YA0 KrqqfM7P5yttCWeZxskQI6XCNcajf4nAQ9mry5Qfr8la3k52Mur3VM7BLbLNT+pP WEyafhGF9+J4jCZOxBZHDkVfpWkLAFr9cvx8yHhkBety5/XMkvQvWvFo1kca4bYn l0YP7KVqE6LF5WVbyVcEWxaYnT4pegG4l7pJZWPqpNIr+mG4Pmw8p4Ho3hXHAxbl HXXVZMIGvyLg1UFFuyu9wA3VfekPVEu4d544mKYmOLx6BrAMU80YgHeMcl0p6N39 Gyz7IymCF3BelBhXc6DN+B6kGY3NA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtiedguddthecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtqh ertddttdejnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepgedtveduffevkefgve efheefieeigfdvieeljefgueegheetgeeigfduudfggfdvnecuffhomhgrihhnpehtrhgr vhhishdqtghirdgtohhmpdgsohhothhlihhnrdgtohhmnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 101E63060057; Thu, 5 Nov 2020 02:12:43 -0500 (EST) From: Thomas Monjalon To: David Christensen Cc: dev@dpdk.org, anatoly.burakov@intel.com, david.marchand@redhat.com Date: Thu, 05 Nov 2020 08:12:41 +0100 Message-ID: <4279961.Ez0r9NPIs3@thomas> In-Reply-To: <19f7c0b2-9179-5587-c0c8-e9f417cfc64f@linux.vnet.ibm.com> References: <20201015172305.105717-1-drc@linux.vnet.ibm.com> <1866859.44BVCP9YqW@thomas> <19f7c0b2-9179-5587-c0c8-e9f417cfc64f@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 1/1] vfio: modify spapr iommu support to use static window sizing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/11/2020 23:25, David Christensen: > On 11/4/20 1:02 PM, Thomas Monjalon wrote: > > 04/11/2020 22:00, David Christensen: > >> > >> On 11/4/20 11:43 AM, Thomas Monjalon wrote: > >>>> Signed-off-by: David Christensen > >>>> Acked-by: Anatoly Burakov > >>>> --- > >>>> -#ifdef VFIO_IOMMU_SPAPR_INFO_DDW > >>>> - /* try possible page_shift and levels for workaround */ > >>>> + /* if at first we don't succeed, try more levels */ > >>>> uint32_t levels; > >>>> =20 > >>>> - for (levels =3D create->levels + 1; > >>>> + for (levels =3D create.levels + 1; > >>>> ret && levels <=3D info.ddw.levels; levels++) { > >>> > >>> There is a compilation failure with ppc64le-power8-linux-gcc: > >>> error: =E2=80=98struct vfio_iommu_spapr_tce_info=E2=80=99 has no memb= er named =E2=80=98ddw=E2=80=99 > >> > >> How did you find that error? It builds locally for me on a POWER syst= em > >> with Meson/gcc and there were no build failures on Travis > >> (https://travis-ci.com/github/drchristensen/dpdk/builds/198047029) when > >> I checked it against AMD64/ARM systems. The code is PPC specific but = it > >> will build on all architectures (there are no IFDEFs around it). > >=20 > > Remember, I cross-build with test-meson-builds.sh > > Is it an issue of my toolchain? >=20 > What distro/gcc version are you using? I'll try it locally on an x86. I am using powerpc64le-power8--glibc--stable-2018.11-1 from https://toolchains.bootlin.com/releases_powerpc64le-power8.html