From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 724705A32
 for <dev@dpdk.org>; Fri, 23 Oct 2015 18:35:32 +0200 (CEST)
Received: by wicfx6 with SMTP id fx6so38841532wic.1
 for <dev@dpdk.org>; Fri, 23 Oct 2015 09:35:29 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=dyJlqI+b7/DCC+HYIfdtHF1EUfl9+ylB7Odqq/krZJM=;
 b=hydkGADR8TOARkSG4Rv049iq9S5b5gFVqFyOxyGKv06hBCkOF00LqrExWCll/nRQlr
 WrufDwZjHt68J5HS0CEA5SnMf8ODQzNeI5cOZAAs407ipfQ2QH86y1DOWP1q+xLtaF1i
 +kKPgSv/rPRrjfir+W4YDu/S0u6XmRUmieL1SFgVMQ77xalcPosb+FvMmiy5TV0gfT5U
 pApwxNHoJ/+zrNTOB8LYvwt18xnQSZYFwhh+tVUvCoZW+VlvoBV+DzO11fUSKQnj/TpC
 dz1A6Tga/EdltUGSyTkaZ2mRSvvYcU8v+JvvR08ewhyPJ9IZa0JdZh6aozZNb29ouqIp
 +hfQ==
X-Gm-Message-State: ALoCoQkgVuXaqjbeG08iadi1h64LUtLDxg53AhI0S/6QCekINTcC2i7xJGuwMyssdTGZEq9iFUD3
X-Received: by 10.195.12.39 with SMTP id en7mr5579519wjd.126.1445618129271;
 Fri, 23 Oct 2015 09:35:29 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id xt1sm23456508wjb.32.2015.10.23.09.35.28
 (version=TLSv1/SSLv3 cipher=OTHER);
 Fri, 23 Oct 2015 09:35:28 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 23 Oct 2015 18:34:23 +0200
Message-ID: <4288301.N0F7Gaqfh8@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <20151023090325.3a83fa0c@xeon-e3>
References: <1445615606-3885-1-git-send-email-thomas.monjalon@6wind.com>
 <1445615606-3885-2-git-send-email-thomas.monjalon@6wind.com>
 <20151023090325.3a83fa0c@xeon-e3>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] scripts: add checkpatch wrapper
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Oct 2015 16:35:32 -0000

2015-10-23 09:03, Stephen Hemminger:
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> > +options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\
> > +VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,PREFER_KERNEL_TYPES,\
> > +SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
> > +NEW_TYPEDEFS,COMPLEX_MACRO,COMPARISON_TO_NULL"
> 
> Please keep some of these:
>   PARENTHESIS_ALIGNMENT

It is not written in the DPDK coding rules that
"Alignment should match open parenthesis"

>   LINUX_VERSION_CODE

It is used for out-of-tree modules.

>   COMPLEX_MACRO

I don't remember why I've ignored this one:
"Macros with complex values should be enclosed in parentheses"

> All of these are indications of problems in code.

I don't think so for the DPDK case, except COMPLEX_MACRO.
Thanks for catching.