From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f182.google.com (mail-we0-f182.google.com
 [74.125.82.182]) by dpdk.org (Postfix) with ESMTP id 9FE0AB118
 for <dev@dpdk.org>; Fri, 27 Jun 2014 02:56:34 +0200 (CEST)
Received: by mail-we0-f182.google.com with SMTP id q59so4382824wes.41
 for <dev@dpdk.org>; Thu, 26 Jun 2014 17:56:53 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=be0NzRcUNGAD7e19LVk/nG+/E9Vn0Km80aRM5E+8coM=;
 b=bxEs3c2ehdw51jFBWutPG21SujFXf7VY+WoBt4joGxEETrrPaKwoVtNPZpm7x3h0ss
 JRUR+rQKU4njIQSkrME7a+BNFsjAh1+a+wTgo6rlxMp1OKRG1MPHEV+Hl/ZYRJu+3o0W
 K9AaIyqTLGJeFsyRHzZ0ZrytJbDtHNTBdlbxYA/5ZeJGRFsZF2wGLXY96MJAgZmHZyVr
 5TX+O9m7z/PeiS6cKxp+MehsZqpucn2gUKrSgqvftjcyGX4G6GgLI46lo6BdeXEyEJ3P
 jzch9uu2/5iF4OoJjhxHIV9ZRcZkf2J90fgqb05QDaA2mi2NzCmqyFIkwwqOMRFgimes
 Y6Aw==
X-Gm-Message-State: ALoCoQl3YFKZHZuMz8tI0CgELV1s2M2aLN0DY5LVp+ySjTWaX1mZ1ltm0IpxIeGx8GS3dOEtKD9q
X-Received: by 10.180.92.65 with SMTP id ck1mr5521498wib.48.1403830613806;
 Thu, 26 Jun 2014 17:56:53 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id lo18sm30338035wic.1.2014.06.26.17.56.52
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 26 Jun 2014 17:56:52 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Aaron Campbell <aaron@arbor.net>
Date: Fri, 27 Jun 2014 02:56:48 +0200
Message-ID: <4288998.3pALjXkCDh@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; )
In-Reply-To: <1403794474-17695-1-git-send-email-aaron@arbor.net>
References: <1403794474-17695-1-git-send-email-aaron@arbor.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: fix invalid memory read as reported by
	valgrind
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Jun 2014 00:56:34 -0000

2014-06-26 10:54, Aaron Campbell:
> ==29880== Invalid read of size 1
> ==29880==    at 0x56FF9A5: cpu_socket_id (eal_lcore.c:101)
> ==29880==    by 0x56FFAE9: rte_eal_cpu_init (eal_lcore.c:168)
> ==29880==    by 0x56F944A: rte_eal_init (eal.c:975)
> 
> The problem is that endptr points to memory allocated underneath the DIR
> handle, which has already been freed.  So move the closedir() call lower.
> 
> Signed-off-by: Aaron Campbell <aaron@arbor.net>

Good catch!

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied for version 1.7.0.

Thanks
-- 
Thomas