From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m13-151.163.com (m13-151.163.com [220.181.13.151]) by dpdk.org (Postfix) with ESMTP id 2E9635F1F for ; Wed, 14 Mar 2018 01:35:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:MIME-Version:Message-ID; bh=AlZGv nSMZDz9EUfgFc58DTU8wpVGuO8QyuEZ+OcVolI=; b=DXb4Rbogj7jSwSls1GUbE zzU+3uHoY8gZb6UlVyCFvjCsw6Z4A3D2IU6dQ5XmVi/5sdL36JKuyJEdqEPxM8bu VJh38NVw3OBesYH0ue0g9aS2SBr5fiGfC6/Kda2VV5/2Tb73kPQcBhi/j4F/mke2 k8s5aJQY7ZMrwDCHV94+ao= Received: from chaoys155$163.com ( [113.87.162.218] ) by ajax-webmail-wmsvr151 (Coremail) ; Wed, 14 Mar 2018 08:35:45 +0800 (CST) X-Originating-IP: [113.87.162.218] Date: Wed, 14 Mar 2018 08:35:45 +0800 (CST) From: cys To: "Ferruh Yigit" Cc: dev X-Priority: 3 X-Mailer: Coremail Webmail Server Version SP_ntes V3.5 build 20160729(86883.8884) Copyright (c) 2002-2018 www.mailtech.cn 163com In-Reply-To: <60b8909c-b28d-eec4-110e-4c02c32cb087@intel.com> References: <528c4b67.fc.1620aaef223.Coremail.chaoys155@163.com> <60b8909c-b28d-eec4-110e-4c02c32cb087@intel.com> MIME-Version: 1.0 Message-ID: <428fa651.2c.16221ef2eaa.Coremail.chaoys155@163.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: l8GowAA3NKhibqhanDepAA--.18155W X-CM-SenderInfo: 5fkd05jvrvkqqrwthudrp/xtbBdQ4JqFaDvtr90QABsG X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] kni: continuous memory restriction ? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 00:35:50 -0000 VGhhbmtzIGZvciB5b3VyIHJlcGx5LgpXaXRoIHlvdXIgc29sdXRpb24gYSksIEkgZ3Vlc3MgJ3Np bmdsZSBtZW1wb29sJyBtZWFuIGEgbWVtcG9vbCBmaXQgaW4gb25lIG1lbXNlZyAoY29udGludW91 cyBtZW1vcnkpLgpXaGF0IGFib3V0IGEgbWVtcG9vbCBhY3Jvc3MgbWFueSBtZW1zZWdzID8gSSdt IGFmcmFpZCBpdCdzIHN0aWxsIG5vdCBzYWZlLgoKSnVzdCBsaWtlIHRoaXMgb25lOgotLS0tLS0t LS0tLS0tLSBNRU1QT09MIC0tLS0tLS0tLS0tLS0tLS0KbWVtcG9vbCA8bWJ1Zl9wb29sWzBdPkAw eDdmZjllNDgzM2QwMAogIGZsYWdzPTEwCiAgcG9vbD0weDdmZjlmYmZmZmUwMAogIHBoeXNfYWRk cj0weGM0ZmMzM2QwMAogIG5iX21lbV9jaHVua3M9OTEKICBzaXplPTUyNDI4OAogIHBvcHVsYXRl ZF9zaXplPTUyNDI4OAogIGhlYWRlcl9zaXplPTY0CiAgZWx0X3NpemU9MjQzMgogIHRyYWlsZXJf c2l6ZT0wCiAgdG90YWxfb2JqX3NpemU9MjQ5NgogIHByaXZhdGVfZGF0YV9zaXplPTY0CiAgYXZn IGJ5dGVzL29iamVjdD0yNDk2LjIzMzY0MwoKClpvbmUgMDogbmFtZTo8cnRlX2V0aF9kZXZfZGF0 YT4sIHBoeXM6MHhjNGZkYjdmNDAsIGxlbjoweDM0MDAwLCB2aXJ0OjB4N2ZmOWU0OWI3ZjQwLCBz b2NrZXRfaWQ6MCwgZmxhZ3M6MApab25lIDE6IG5hbWU6PE1QX21idWZfcG9vbFswXT4sIHBoeXM6 MHhjNGZjMzNkMDAsIGxlbjoweDE4MjEwMCwgdmlydDoweDdmZjllNDgzM2QwMCwgc29ja2V0X2lk OjAsIGZsYWdzOjAKWm9uZSAyOiBuYW1lOjxNUF9tYnVmX3Bvb2xbMF1fMD4sIHBoeXM6MHhiMjIw MDAwODAsIGxlbjoweDE2ZmZmZjQwLCB2aXJ0OjB4N2ZmYTNhODAwMDgwLCBzb2NrZXRfaWQ6MCwg ZmxhZ3M6MApab25lIDM6IG5hbWU6PFJHX01QX21idWZfcG9vbFswXT4sIHBoeXM6MHhjMTk5ZmZl MDAsIGxlbjoweDgwMDE4MCwgdmlydDoweDdmZjlmYmZmZmUwMCwgc29ja2V0X2lkOjAsIGZsYWdz OjAKWm9uZSA0OiBuYW1lOjxNUF9tYnVmX3Bvb2xbMF1fMT4sIHBoeXM6MHhjMjljMDAwODAsIGxl bjoweDc3ZmZmNDAsIHZpcnQ6MHg3ZmY5ZTU4MDAwODAsIHNvY2tldF9pZDowLCBmbGFnczowClpv bmUgNTogbmFtZTo8TVBfbWJ1Zl9wb29sWzBdXzI+LCBwaHlzOjB4YzIyYzAwMDgwLCBsZW46MHg2 N2ZmZjQwLCB2aXJ0OjB4N2ZmOWVkMjAwMDgwLCBzb2NrZXRfaWQ6MCwgZmxhZ3M6MApab25lIDY6 IG5hbWU6PE1QX21idWZfcG9vbFswXV8zPiwgcGh5czoweGMxZGMwMDA4MCwgbGVuOjB4M2JmZmY0 MCwgdmlydDoweDdmZjlmNDgwMDA4MCwgc29ja2V0X2lkOjAsIGZsYWdzOjAKWm9uZSA3OiBuYW1l OjxNUF9tYnVmX3Bvb2xbMF1fND4sIHBoeXM6MHhjMWJjMDAwODAsIGxlbjoweDFiZmZmNDAsIHZp cnQ6MHg3ZmY5Zjg2MDAwODAsIHNvY2tldF9pZDowLCBmbGFnczowClpvbmUgODogbmFtZTo8TVBf bWJ1Zl9wb29sWzBdXzU+LCBwaHlzOjB4YmY0NjAwMDgwLCBsZW46MHhmZmZmNDAsIHZpcnQ6MHg3 ZmZhMWVhMDAwODAsIHNvY2tldF9pZDowLCBmbGFnczowClpvbmUgOTogbmFtZTo8TVBfbWJ1Zl9w b29sWzBdXzY+LCBwaHlzOjB4YzBlMDAwMDgwLCBsZW46MHhkZmZmNDAsIHZpcnQ6MHg3ZmZhMDY0 MDAwODAsIHNvY2tldF9pZDowLCBmbGFnczowClpvbmUgMTA6IG5hbWU6PE1QX21idWZfcG9vbFsw XV83PiwgcGh5czoweGJlMDYwMDA4MCwgbGVuOjB4ZGZmZjQwLCB2aXJ0OjB4N2ZmYTMyMDAwMDgw LCBzb2NrZXRfaWQ6MCwgZmxhZ3M6MApab25lIDExOiBuYW1lOjxNUF9tYnVmX3Bvb2xbMF1fOD4s IHBoeXM6MHhjMTgwMDAwODAsIGxlbjoweGJmZmY0MCwgdmlydDoweDdmZjlmZDAwMDA4MCwgc29j a2V0X2lkOjAsIGZsYWdzOjAKWm9uZSAxMjogbmFtZTo8TVBfbWJ1Zl9wb29sWzBdXzk+LCBwaHlz OjB4NjUwMDAwODAsIGxlbjoweGJmZmY0MCwgdmlydDoweDdmZmE1NGUwMDA4MCwgc29ja2V0X2lk OjAsIGZsYWdzOjAKWm9uZSAxMzogbmFtZTo8TVBfbWJ1Zl9wb29sWzBdXzEwPiwgcGh5czoweGMx MmEwMDA4MCwgbGVuOjB4N2ZmZjQwLCB2aXJ0OjB4N2ZmYTAyMjAwMDgwLCBzb2NrZXRfaWQ6MCwg ZmxhZ3M6MApab25lIDE0OiBuYW1lOjxNUF9tYnVmX3Bvb2xbMF1fMTE+LCBwaHlzOjB4YzBkNjAw MDgwLCBsZW46MHg3ZmZmNDAsIHZpcnQ6MHg3ZmZhMDc0MDAwODAsIHNvY2tldF9pZDowLCBmbGFn czowClpvbmUgMTU6IG5hbWU6PE1QX21idWZfcG9vbFswXV8xMj4sIHBoeXM6MHhjMDY2MDAwODAs IGxlbjoweDdmZmY0MCwgdmlydDoweDdmZmEwZGUwMDA4MCwgc29ja2V0X2lkOjAsIGZsYWdzOjAK Ci4uLgoKCuWcqDIwMTjlubQwM+aciDEzIDIy5pe2NTfliIYsICJGZXJydWggWWlnaXQiPGZlcnJ1 aC55aWdpdEBpbnRlbC5jb20+5YaZ6YGTOgoKT24gMy85LzIwMTggMTI6MTQgUE0sIGN5cyB3cm90 ZToKPiBDb21taXQgODQ1MTI2OWU2ZDdiYTc1MDE3MjNmZTJlZmQwIHNhaWQgInJlbW92ZSBjb250 aW51b3VzIG1lbW9yeSByZXN0cmljdGlvbiI7Cj4gaHR0cDovL2RwZGsub3JnL2Jyb3dzZS9kcGRr L2NvbW1pdC9saWIvbGlicnRlX2VhbC9saW51eGFwcC9rbmkva25pX25ldC5jP2lkPTg0NTEyNjll NmQ3YmE3NTAxNzIzZmUyZWZkMDU3NDUwMTAyOTViYWMKPiBGb3IgY2hhaW5lZCBtYnVmcyhuYl9z ZWdzID4gMSksIGZ1bmN0aW9uIHZhMnBhIHVzZSB0aGUgb2Zmc2V0IG9mIHByZXZpb3VzIG1idWYK PiB0byBjYWxjdWxhdGUgcGh5c2ljYWwgYWRkcmVzcyBvZiBuZXh0IG1idWYuCj4gU28gYW55d2hl cmUgZ3VhcmFudGUgdGhhdCBhbGwgbWJ1ZnMgaGF2ZSB0aGUgc2FtZSBvZmZzZXQgKGJ1Zl9hZGRy IC0gYnVmX3BoeXNhZGRyKSA/Cj4gT3IgaGF2ZSBJIG1pc3VuZGVyc3Rvb2QgY2hhaW5lZCBtYnVm cz8KCkhpLAoKWW91ciBkZXNjcmlwdGlvbiBpcyBjb3JyZWN0LCBLTkkgY2hhaW5lZCBtYnVmcyBp cyBicm9rZW4gaWYgY2hhaW5lZCBtYnVmcyBhcmUKZnJvbSBkaWZmZXJlbnQgbWVtcG9vbHMuCgpU d28gY29tbWl0cyBzZWVtcyBpbnZvbHZlZCwgaW4gdGltZSBvcmRlcjoKWzFdIGQ4OWE1OGRmZTkw YiAoImtuaTogc3VwcG9ydCBjaGFpbmVkIG1idWZzIikKWzJdIDg0NTEyNjllNmQ3YiAoImtuaTog cmVtb3ZlIGNvbnRpbnVvdXMgbWVtb3J5IHJlc3RyaWN0aW9uIikKCldpdGggY3VycmVudCBpbXBs ZW1lbnRhdGlvbiwga2VybmVsIG5lZWRzIHRvIGtub3cgcGh5c2ljYWwgYWRkcmVzcyBvZiB0aGUg bWJ1Zgp0byBiZSBhYmxlIHRvIGFjY2VzcyBpdC4KRm9yIGNoYWluZWQgbWJ1ZnMsIGZpcnN0IG1i dWYgaXMgT0sgYnV0IGZvciByZXN0IGtlcm5lbCBzaWRlIGdldHMgdGhlIHZpcnR1YWwKYWRkcmVz cyBvZiB0aGUgbWJ1ZiBhbmQgdGhpcyBvbmx5IHdvcmtzIGlmIGFsbCBjaGFpbmVkIG1idWZzIGFy ZSBmcm9tIHNhbWUgbWVtcG9vbC4KCkkgZG9uJ3QgaGF2ZSBhbnkgZ29vZCBzb2x1dGlvbiBpbmRl ZWQsIGJ1dCBpdCBpcyBwb3NzaWJsZSB0bzoKYSkgSWYgeW91IGFyZSB1c2luZyBjaGFpbmVkIG1i dWZzLCBrZWVwIG9sZCBsaW1pdGF0aW9uIG9mIHVzaW5nIHNpbmdlIG1lbXBvb2wKYikgU2VyaWFs aXplIGNoYWluZWQgbWJ1ZnMgZm9yIEtOSSBpbiB1c2Vyc3BhY2UK >From ferruh.yigit@intel.com Wed Mar 14 01:56:29 2018 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 6F18C6D45 for ; Wed, 14 Mar 2018 01:56:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2018 17:56:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,466,1515484800"; d="scan'208";a="211319185" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.17.220]) ([10.252.17.220]) by fmsmga005.fm.intel.com with ESMTP; 13 Mar 2018 17:56:26 -0700 To: Hyong Youb Kim Cc: "Ananyev, Konstantin" , John Daley , "dev@dpdk.org" , Wenzhuo Lu References: <20180306014634.28398-2-johndale@cisco.com> <20180308024702.25974-1-johndale@cisco.com> <20180308024702.25974-4-johndale@cisco.com> <2601191342CEEE43887BDE71AB97725890F22461@irsmsx105.ger.corp.intel.com> <20180310003743.GA18664@HYONKIM-FTCPE.cisco.com> From: Ferruh Yigit Message-ID: Date: Wed, 14 Mar 2018 00:56:24 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180310003743.GA18664@HYONKIM-FTCPE.cisco.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 03/10] net/enic: heed the requested max Rx packet size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 00:56:30 -0000 On 3/10/2018 12:37 AM, Hyong Youb Kim wrote: > On Fri, Mar 09, 2018 at 03:57:46PM +0000, Ferruh Yigit wrote: >> On 3/9/2018 3:51 PM, Ananyev, Konstantin wrote: > [...] >>>> Is this work based on an application that uses max_rx_pkt_len and to make PMD >>>> compatible with that application? If so we can continue with patch, but if the >>>> patch is to implement DPDK properly I suggest postponing this until >>>> max_rx_pkt_len clarified. >>>> >>>> [1] >>>> https://dpdk.org/ml/archives/dev/2018-March/092178.html >>> >>> I think there are quite a lot apps these days that might rely on setting MTU via >>> rxmode.max_rx_pkt_len. >>> I think we need to support them till we (ever) deprecate rxmode.max_rx_pkt_len. >> >> Right. I was trying to save effort in case something changes related >> max_rx_pkt_len, but since it is not clear yet, will continue with this patch. >> >>> Konstantin >>> > > testpmd has a command to change max_rx_pkt_len, a few DTS test cases > rely on this feature to see if packets of certain sizes get dropped, > and so on. We worked on this patch to support these cases. > > I prefer using only MTU, to follow the convention of most (all?) > OSes. Though, this feature (max_rx_pkt_len) seems to come straight > from an Intel 82599 feature. In its datasheet, see "8.2.3.22.13 Max > Frame Size -- MAXFRS". Like to understand use cases for that, if > anyone can share. ixgbe driver updates MAXFRS register in ixgbe_dev_mtu_set(), so mtu seems can replace max_rx_pkt_len. MAXFRS is for rx only, from datasheet description of it: "This value has no effect on transmit frames; it is the responsibility of software to limit the size of transmit frames" This may be the reason a new variable has been created for rx_frames, to differentiate it from mtu. Not sure if max rx and tx size can be different values for ixgbe. > > -Hyong >