From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99269A0C41; Wed, 23 Jun 2021 16:13:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E9B440141; Wed, 23 Jun 2021 16:13:24 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id CA61C4003F; Wed, 23 Jun 2021 16:13:22 +0200 (CEST) IronPort-SDR: 0k8K9W9aUeUyjJGk68kCBiHVTPQ0PC/0uRpAUjzeuXuYrvIzFp7E7sfvhoBHsmBEE0ID9DP5VV 9v6cg+oVnHQQ== X-IronPort-AV: E=McAfee;i="6200,9189,10024"; a="205442346" X-IronPort-AV: E=Sophos;i="5.83,294,1616482800"; d="scan'208";a="205442346" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2021 07:13:21 -0700 IronPort-SDR: Kw7NckPYCgMqKT2lOlvVFJCIqFqWmexQASUOCQseMmNpbo5QehBBtZA4+3sHynHlJ40qeh2HSo SHSwmnbkJEDw== X-IronPort-AV: E=Sophos;i="5.83,294,1616482800"; d="scan'208";a="556981768" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.252.18.52]) ([10.252.18.52]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2021 07:13:20 -0700 To: Richael Zhuang , dev@dpdk.org Cc: yux.jiang@intel.com, stable@dpdk.org References: <20210512035709.37755-2-richael.zhuang@arm.com> <20210623035541.50543-1-richael.zhuang@arm.com> <20210623035541.50543-3-richael.zhuang@arm.com> From: David Hunt Message-ID: <42a2e45b-2b06-debb-92e8-f95a8356f8a3@intel.com> Date: Wed, 23 Jun 2021 15:13:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210623035541.50543-3-richael.zhuang@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v4 2/2] test/power: round cpuinfo cur freq only when using CPPC cpufreq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Richael, On 23/6/2021 4:55 AM, Richael Zhuang wrote: > On arm platform, the value in "/sys/.../cpuinfo_cur_freq" may not > be exactly the same as what was set when using CPPC cpufreq driver. > For other cpufreq driver, no need to round it currently, or else > this check will fail with turbo enabled. For example, with acpi_cpufreq, > cpuinfo_cur_freq can be 2401000 which is equal to freqs[0].It should > not be rounded to 2400000. > > Fixes: 606a234c6d360 ("test/power: round CPU frequency to check") > Cc: richael.zhuang@arm.com > Cc: stable@dpdk.org > > Signed-off-by: Richael Zhuang > --- > app/test/test_power_cpufreq.c | 23 ++++++++++++++--------- > 1 file changed, 14 insertions(+), 9 deletions(-) --snip-- Makes sense. Reviewed-by: David Hunt