From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 270EFA0540; Mon, 13 Jul 2020 16:54:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE4201D8DB; Mon, 13 Jul 2020 16:54:36 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5F2ED1D6BF for ; Mon, 13 Jul 2020 16:54:35 +0200 (CEST) IronPort-SDR: OZVaRAINZK8cQEMldzri+QJXAwy3zfMsUjJmdv8q6EQHpzaXpDvmH75P+Iiih4oZtXaHIh/GAp kFEzigNU/ALg== X-IronPort-AV: E=McAfee;i="6000,8403,9681"; a="150080048" X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="150080048" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 07:54:33 -0700 IronPort-SDR: u7PjFkWEAY6/FNR7HbpIGNzm2fBaObOml/GTBXYDOC6koWwxx8YBAwgO4Y09PqzWkJ3JiHq61r Em0Hx11pl4/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="269738465" Received: from silpixa00399498.ir.intel.com (HELO silpixa00399498.ger.corp.intel.com) ([10.237.222.52]) by fmsmga008.fm.intel.com with ESMTP; 13 Jul 2020 07:54:29 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: David Hunt , reshma.pattan@intel.com Date: Mon, 13 Jul 2020 15:54:27 +0100 Message-Id: <42bebf7cebd2b635a60b626faf605df6d8a277c1.1594652063.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v2 1/2] power: fix power management env detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Anything coming from sysfs has a newline at the end. Cut it off before comparing the strings. Fixes: 20ab67608a39 ("power: add environment capability probing") Signed-off-by: Anatoly Burakov Acked-by: David Hunt --- lib/librte_power/power_common.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lib/librte_power/power_common.c b/lib/librte_power/power_common.c index 59023d986b..22b016ca9d 100644 --- a/lib/librte_power/power_common.c +++ b/lib/librte_power/power_common.c @@ -15,6 +15,7 @@ int cpufreq_check_scaling_driver(const char *driver_name) { unsigned int lcore_id = 0; /* always check core 0 */ + size_t end_idx; char fullpath[PATH_MAX]; char readbuf[PATH_MAX]; char *s; @@ -39,6 +40,13 @@ cpufreq_check_scaling_driver(const char *driver_name) if (s == NULL) return 0; + /* when read from sysfs, driver name has an extra newline at the end */ + end_idx = strnlen(readbuf, sizeof(readbuf)); + /* prevent underflow if len is zero */ + if (end_idx > 0) + end_idx--; + readbuf[end_idx] = '\0'; + /* does the driver name match? */ if (strncmp(readbuf, driver_name, sizeof(readbuf)) != 0) return 0; -- 2.17.1