DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 3/7] net/txgbe: update link setup process of backplane NICs
Date: Fri, 26 Mar 2021 08:55:50 +0000
Message-ID: <42cec25c-6684-9985-2ec9-f7b1c9b95af1@intel.com> (raw)
In-Reply-To: <00f701d721e4$14d4f600$3e7ee200$@trustnetic.com>

On 3/26/2021 2:02 AM, Jiawen Wu wrote:
> On March 25, 2021 6:20 PM, Ferruh Yigit wrote:
>> On 3/25/2021 5:51 AM, Jiawen Wu wrote:
>>> Add device arguments to support runtime options.
>>> And use these configuration to control the link setup flow, to adapt
>>> to different NIC's construction. Use firmware version to control the
>>> impact of firmware update. And fix some left bugs.
>>>
>>> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
>>
>> <...>
>>
>>> +#define TXGBE_DEBUG_BP
>>> +#ifdef TXGBE_DEBUG_BP
>>> +#define BP_LOG(fmt, ...) \
>>> +		RTE_LOG(CRIT, PMD, "[%lu.%lu]%s(%d): " fmt, \
>>> +			usec_stamp() / 1000000, usec_stamp() % 1000000, \
>>> +			__func__, __LINE__, ## __VA_ARGS__) #else #define
>> BP_LOG(fmt, ...)
>>> +do { } while (0) #endif
>>> +
>>>    #endif /* _TXGBE_LOGS_H_ */
>>>
>>
>> The 'BP_LOG' looks like used for developer debug prints, if so I suggest
>> removing them completely, but if not can you please convert it dynamic logging,
>> or using existing dynamic logs 'txgbe_logtype_init', 'txgbe_logtype_driver'?
>>
>> Thanks,
>> ferruh
> 
> I think it should not be removed, since the user needs to adjust 'ffe' parameters
> according to the logs. I considered converting it to dynamic logging. But when the log
> level is 'debug', it will result in the printing of other logs, which I don't need.
> Should I lower the log level of 'BP_LOG', to avoid the above situation?
> 

You can create a new logtype for it, and it can be controlled without affecting 
other logs, user need to get those logs can enable/disable them in runtime on 
demand, does this work for you?

  reply	other threads:[~2021-03-26  8:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25  5:51 [dpdk-dev] [PATCH v3 0/7] txgbe backplane AN training Jiawen Wu
2021-03-25  5:51 ` [dpdk-dev] [PATCH v3 1/7] net/txgbe: update device ID Jiawen Wu
2021-03-25  5:51 ` [dpdk-dev] [PATCH v3 2/7] net/txgbe: move firmware version get function to base code Jiawen Wu
2021-03-25  5:51 ` [dpdk-dev] [PATCH v3 3/7] net/txgbe: update link setup process of backplane NICs Jiawen Wu
2021-03-25 10:19   ` Ferruh Yigit
2021-03-25 15:59     ` Ferruh Yigit
2021-03-26  2:02     ` Jiawen Wu
2021-03-26  8:55       ` Ferruh Yigit [this message]
2021-03-26  9:19         ` Jiawen Wu
2021-03-25  5:51 ` [dpdk-dev] [PATCH v3 4/7] net/txgbe/base: support to handle backplane AN73 flow Jiawen Wu
2021-03-25  5:51 ` [dpdk-dev] [PATCH v3 5/7] net/txgbe: handle AN interrupt and link update Jiawen Wu
2021-03-25  5:51 ` [dpdk-dev] [PATCH v3 6/7] net/txgbe: add FFE parameters for user debugging Jiawen Wu
2021-03-25  5:51 ` [dpdk-dev] [PATCH v3 7/7] doc: add txgbe backplane update in release notes Jiawen Wu
2021-03-25 16:07   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42cec25c-6684-9985-2ec9-f7b1c9b95af1@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jiawenwu@trustnetic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git