From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5BD5A0A02; Fri, 26 Mar 2021 09:56:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42C2F140D6F; Fri, 26 Mar 2021 09:55:59 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 1997A140D4F for ; Fri, 26 Mar 2021 09:55:57 +0100 (CET) IronPort-SDR: w1A3GjcBUIv6DXxB4SgA8cEHRByfqnTKBS+mdamGvyh41QVZ9ZCheB32erDA1dy3GlPwMx/QpO d1Y34C7gr2tQ== X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="178228764" X-IronPort-AV: E=Sophos;i="5.81,280,1610438400"; d="scan'208";a="178228764" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 01:55:56 -0700 IronPort-SDR: SugZS8TF/9JLulcqrJa/FjbRrcEajfqC9lZY5SdQT6/+sAWnqEr/aFq5TO2PpcORpb8bOFIEQV 4lrmbBuOtoZA== X-IronPort-AV: E=Sophos;i="5.81,280,1610438400"; d="scan'208";a="409804771" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.0.58]) ([10.252.0.58]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 01:55:54 -0700 To: Jiawen Wu , dev@dpdk.org References: <20210325055141.629963-1-jiawenwu@trustnetic.com> <20210325055141.629963-4-jiawenwu@trustnetic.com> <603dc490-6524-aac4-4865-5670d9ecb9ca@intel.com> <00f701d721e4$14d4f600$3e7ee200$@trustnetic.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <42cec25c-6684-9985-2ec9-f7b1c9b95af1@intel.com> Date: Fri, 26 Mar 2021 08:55:50 +0000 MIME-Version: 1.0 In-Reply-To: <00f701d721e4$14d4f600$3e7ee200$@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 3/7] net/txgbe: update link setup process of backplane NICs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/26/2021 2:02 AM, Jiawen Wu wrote: > On March 25, 2021 6:20 PM, Ferruh Yigit wrote: >> On 3/25/2021 5:51 AM, Jiawen Wu wrote: >>> Add device arguments to support runtime options. >>> And use these configuration to control the link setup flow, to adapt >>> to different NIC's construction. Use firmware version to control the >>> impact of firmware update. And fix some left bugs. >>> >>> Signed-off-by: Jiawen Wu >> >> <...> >> >>> +#define TXGBE_DEBUG_BP >>> +#ifdef TXGBE_DEBUG_BP >>> +#define BP_LOG(fmt, ...) \ >>> + RTE_LOG(CRIT, PMD, "[%lu.%lu]%s(%d): " fmt, \ >>> + usec_stamp() / 1000000, usec_stamp() % 1000000, \ >>> + __func__, __LINE__, ## __VA_ARGS__) #else #define >> BP_LOG(fmt, ...) >>> +do { } while (0) #endif >>> + >>> #endif /* _TXGBE_LOGS_H_ */ >>> >> >> The 'BP_LOG' looks like used for developer debug prints, if so I suggest >> removing them completely, but if not can you please convert it dynamic logging, >> or using existing dynamic logs 'txgbe_logtype_init', 'txgbe_logtype_driver'? >> >> Thanks, >> ferruh > > I think it should not be removed, since the user needs to adjust 'ffe' parameters > according to the logs. I considered converting it to dynamic logging. But when the log > level is 'debug', it will result in the printing of other logs, which I don't need. > Should I lower the log level of 'BP_LOG', to avoid the above situation? > You can create a new logtype for it, and it can be controlled without affecting other logs, user need to get those logs can enable/disable them in runtime on demand, does this work for you?