DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
Cc: chas3@att.com
Subject: Re: [dpdk-dev] [PATCH] net/bonding: fix add bonded device itself as its slave
Date: Tue, 20 Apr 2021 02:37:55 +0100	[thread overview]
Message-ID: <42dd6d45-ad3c-c335-5354-89215ab8a6ed@intel.com> (raw)
In-Reply-To: <1618470594-64612-1-git-send-email-humin29@huawei.com>

On 4/15/2021 8:09 AM, Min Hu (Connor) wrote:
> From: Chengchang Tang <tangchengchang@huawei.com>
> 
> Adding the bond device as its own slave should be forbidden. This
> will cause a recursive endless loop in many subsequent operations,
> and eventually lead to coredump.
> 
> This problem was found in testpmd, the related logs are as follows:
> testpmd> create bonded device 1 0
> Created new bonded device net_bonding_testpmd_0 on (port 4).
> testpmd> add bonding slave 4 4
> Segmentation fault (core dumped)
> 
> The call stack is as follows:
> 0x000000000064eb90 in rte_eth_dev_info_get ()
> 0x00000000006df4b4 in bond_ethdev_info ()
> 0x000000000064eb90 in rte_eth_dev_info_get ()
> 0x00000000006df4b4 in bond_ethdev_info ()
> 0x000000000064eb90 in rte_eth_dev_info_get ()
> 0x0000000000564e58 in eth_dev_info_get_print_err ()
> 0x000000000055e8a4 in init_port_config ()
> 0x000000000052730c in cmd_add_bonding_slave_parsed ()
> 0x0000000000646f60 in cmdline_parse ()
> 0x0000000000645e08 in cmdline_valid_buffer ()
> 0x000000000064956c in rdline_char_in ()
> 0x0000000000645ee0 in cmdline_in ()
> 0x00000000006460a4 in cmdline_interact ()
> 0x0000000000531904 in prompt ()
> 0x000000000051cca8 in main ()
> 
> Fixes: 2efb58cbab6e ("bond: new link bonding library")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>

Applied to dpdk-next-net/main, thanks.


      reply	other threads:[~2021-04-20  1:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15  7:09 Min Hu (Connor)
2021-04-20  1:37 ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42dd6d45-ad3c-c335-5354-89215ab8a6ed@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=chas3@att.com \
    --cc=dev@dpdk.org \
    --cc=humin29@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).