From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Yuan Wang <yuanx.wang@intel.com>, chenbo.xia@intel.com, dev@dpdk.org
Cc: jiayu.hu@intel.com, xingguang.he@intel.com,
cheng1.jiang@intel.com, weix.ling@intel.com, stable@dpdk.org
Subject: Re: [PATCH v2] net/vhost: fix deadlock on vring state change
Date: Fri, 1 Jul 2022 15:58:13 +0200 [thread overview]
Message-ID: <42f0ebb1-da76-c565-1db3-bdb34d720da7@redhat.com> (raw)
In-Reply-To: <20220627055125.1541652-1-yuanx.wang@intel.com>
On 6/27/22 07:51, Yuan Wang wrote:
> If vring state changes after pmd starts working, the locked vring
> notifies pmd, thus calling update_queuing_status(), the latter
> will wait for pmd to finish accessing vring, while pmd is also
> waiting for vring to be unlocked, thus causing deadlock.
>
> Actually, update_queuing_status() only needs to wait while
> destroy/stopping the device, but not in other cases.
>
> This patch adds a flag for whether or not to wait to fix this issue.
>
> Fixes: 1ce3c7fe149f ("net/vhost: emulate device start/stop behavior")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
> ---
> V2: rewrite the commit log.
> ---
> drivers/net/vhost/rte_eth_vhost.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
Applied to dpdk-next-virtio/main.
Thanks,
Maxime
prev parent reply other threads:[~2022-07-01 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 14:25 [PATCH] net/vhost: add flag to control wait queuing Yuan Wang
2022-06-02 8:32 ` Ling, WeiX
2022-06-27 5:51 ` [PATCH v2] net/vhost: fix deadlock on vring state change Yuan Wang
2022-07-01 12:31 ` Xia, Chenbo
2022-07-01 13:58 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42f0ebb1-da76-c565-1db3-bdb34d720da7@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=stable@dpdk.org \
--cc=weix.ling@intel.com \
--cc=xingguang.he@intel.com \
--cc=yuanx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).