DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>,
	Pallavi Kadam <pallavi.kadam@intel.com>,
	Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
	Matan Azrad <matan@nvidia.com>,
	Shahaf Shuler <shahafs@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file
Date: Tue, 06 Apr 2021 20:52:52 +0200	[thread overview]
Message-ID: <4303766.JfoNgE5a7G@thomas> (raw)
In-Reply-To: <20210406175910.24450-1-david.marchand@redhat.com>

About the title, it is not a single file but one file per lib/driver.
I think it would better convey the idea by saying "remove .def files".

06/04/2021 19:59, David Marchand:
> Rather than have two files that keeps getting out of sync, let's
> annotate the version.map to generate the Windows export file.
> 
> Note: Existing version.map annotation achieved with:
> $ for dir in lib/librte_eal drivers/common/mlx5; do
>     ./buildtools/map-list-symbol.sh $dir/*.map |
>     while read file version sym; do
>       ! git grep -qw $sym $dir/*.def || continue;
>       sed -i -e "s/$sym;/$sym; # WINDOWS_NO_EXPORT/" $dir/*.map;
>     done;
>   done

This patch keeps the exact same behaviour, right?
There are a lot of symbols in EAL and mlx5 which should
be exported for Windows too, but it is open for future fixes, right?



  reply	other threads:[~2021-04-06 18:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06 16:32 [dpdk-dev] [PATCH] " David Marchand
2021-04-06 16:40 ` David Marchand
2021-04-06 16:50 ` Bruce Richardson
2021-04-06 16:53   ` David Marchand
2021-04-07 20:06   ` Kinsella, Ray
2021-04-06 17:59 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-04-06 18:52   ` Thomas Monjalon [this message]
2021-04-06 20:09     ` David Marchand
2021-04-06 22:39       ` Thomas Monjalon
2021-04-07  8:16       ` David Marchand
2021-04-07  8:53         ` Dmitry Kozlyuk
2021-04-07  8:57           ` Thomas Monjalon
2021-04-07 11:38             ` Tal Shnaiderman
2021-04-08 14:51   ` Thomas Monjalon
2021-04-08 16:11   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4303766.JfoNgE5a7G@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=matan@nvidia.com \
    --cc=mdr@ashroe.eu \
    --cc=navasile@linux.microsoft.com \
    --cc=nhorman@tuxdriver.com \
    --cc=pallavi.kadam@intel.com \
    --cc=shahafs@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).