From: Thomas Monjalon <thomas@monjalon.net>
To: Elena Agostini <eagostini@nvidia.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3] gpudev: manage NULL pointer
Date: Mon, 22 Nov 2021 12:51:46 +0100 [thread overview]
Message-ID: <4322799.Gvt5RlC7if@thomas> (raw)
In-Reply-To: <CH2PR12MB410474F4B3B064D1CF10D50CCD9F9@CH2PR12MB4104.namprd12.prod.outlook.com>
22/11/2021 12:34, Elena Agostini:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 22/11/2021 19:24, eagostini@nvidia.com:
> > > --- a/lib/gpudev/gpudev.c
> > > +++ b/lib/gpudev/gpudev.c
> > > @@ -569,6 +569,9 @@ rte_gpu_mem_free(int16_t dev_id, void *ptr)
> > > {
> > > struct rte_gpu *dev;
> > >
> > > + if (ptr == NULL)
> > > + return 0;
> > > +
> > > dev = gpu_get_by_id(dev_id);
> > > if (dev == NULL) {
> > > GPU_LOG(ERR, "free mem for invalid device ID %d", dev_id);>
>
> > I think we should keep this check first.
>
> Why should gpudev waste more latency in looking for the device if the ptr is NULL?
Freeing with NULL pointer is not in the datapath I think,
probably just a failure cleanup case.
Having the dev_id check first allows to catch more bugs.
Returning 0 without checking the id looks weird to me.
next prev parent reply other threads:[~2021-11-22 11:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 19:28 [PATCH v1] gpudev: return EINVAL if invalid input pointer for free and unregister eagostini
2021-11-18 16:20 ` Stephen Hemminger
2021-11-18 16:22 ` Elena Agostini
2021-11-18 20:19 ` Tyler Retzlaff
2021-11-19 9:34 ` Ferruh Yigit
2021-11-19 9:56 ` Thomas Monjalon
2021-11-24 17:24 ` Tyler Retzlaff
2021-11-24 18:04 ` Bruce Richardson
2021-12-01 21:37 ` Tyler Retzlaff
2021-12-02 7:18 ` Thomas Monjalon
2021-12-02 12:33 ` Morten Brørup
2021-12-02 13:01 ` Ananyev, Konstantin
2021-12-02 13:56 ` Morten Brørup
2021-12-03 10:37 ` Morten Brørup
2021-12-08 17:34 ` Tyler Retzlaff
2021-12-08 18:40 ` Morten Brørup
2021-12-09 19:43 ` Tyler Retzlaff
2021-12-08 17:27 ` Tyler Retzlaff
2021-11-19 10:15 ` Bruce Richardson
2021-11-18 20:33 ` [PATCH v2] gpudev: free and unregister return gracefully if input pointer is NULL eagostini
2021-11-22 18:24 ` [PATCH v3] gpudev: manage NULL pointer eagostini
2021-11-22 11:23 ` Thomas Monjalon
2021-11-22 11:34 ` Elena Agostini
2021-11-22 11:51 ` Thomas Monjalon [this message]
2021-11-22 23:52 ` [PATCH v4] " eagostini
2021-11-22 23:55 ` [PATCH v5] " eagostini
2021-11-22 16:01 ` Thomas Monjalon
2021-11-23 0:15 ` [PATCH v6] " eagostini
2021-11-23 0:42 ` [PATCH v7] " eagostini
2021-11-24 8:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4322799.Gvt5RlC7if@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=eagostini@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).