From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id CFA488D86 for ; Thu, 3 Dec 2015 03:27:50 +0100 (CET) Received: by wmww144 with SMTP id w144so3554259wmw.0 for ; Wed, 02 Dec 2015 18:27:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=89nyLMDdZuwtTNYYpyVPV5RFeBtLjIyG+H0Y4VMRDRY=; b=rpdYb7YGDlclYJS0I6ND4cPjnNFx6kyQsMflHPj93miHJL0+P3d4E+74L2kLnqDVlm e2UvOLYJIMjKDFjnqvufDVRsb0FZzImRbBhmWrokOkI6GkqTNIqVjdS7H0ZQUgbxrS8Q Fdg2v1ksdZT6shWnJSMfRdn5QuOHxSwLiLvKYGeP31ur+CkX1IndhVHtwp36juwk1wgv 7MPCrgS1APapiHj3a0cr+rXMad9ODktMHJdEO4rvyxLh2YeWYmuZ4fbjRJ89fhc3WMxa 4olYwnwxrFKSGdyb0rBD10ghh204c51AMK7iYIWrOJnja0D493i8rLHq2PFMOQtRn5wZ PLTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=89nyLMDdZuwtTNYYpyVPV5RFeBtLjIyG+H0Y4VMRDRY=; b=bGj/mBsnFlUtk7VyZwj0/c+CuMWC3gcNo5aV362Q8V5Q2rASASYqL2Frq8vA0oIeBG KXWqfq74aGtsuSi5CW4i2z5IpmnR2HYpyi+UY2BKf/nEChAZS3JKXXJFqUSVLv1cNRXp mXpjmeQthzGpSArYrf2a89+jGBoNxNHwdHNmdmd4bG3qA/VvsrGy9BInmRN1GKPpyFj9 26mimUdeDatWtXz3aEkZAp6tnqtJ5LCkO9ItP9yXswH2Tu/J6QHQhXvpev5tWWCbvL1o +btcKv4t7XvTxjaifGuOpkslQi6qjCXAm6WhwEQ8ozlsqiGRLnzQoP9WkflD4c5YI8In 07UA== X-Gm-Message-State: ALoCoQkcoM0jwbZ+wPK11SUKbdp8PO1zcFAR92sxvcJzFhWp0JDWtSTHn/FjprVkHs02Qz8GX+YB X-Received: by 10.194.2.168 with SMTP id 8mr9292741wjv.66.1449109670619; Wed, 02 Dec 2015 18:27:50 -0800 (PST) Received: from xps13.localnet ([93.158.46.55]) by smtp.gmail.com with ESMTPSA id u134sm33450954wmd.0.2015.12.02.18.27.49 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 Dec 2015 18:27:49 -0800 (PST) From: Thomas Monjalon To: Stephen Hemminger Date: Thu, 03 Dec 2015 03:26:40 +0100 Message-ID: <4326350.y6KGzOFPTo@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151202180702.784048ca@xeon-e3> References: <5394034.PY3UYPlQag@xps13> <20151202180702.784048ca@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 0/2] Add support for driver directories X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2015 02:27:51 -0000 2015-12-02 18:07, Stephen Hemminger: > On Thu, 12 Nov 2015 16:52:32 +0100 > Thomas Monjalon wrote: > > > > > This mini-series adds support for driver directory concept > > > > based on idea by Thomas Monjalon back in February: > > > > http://dpdk.org/ml/archives/dev/2015-February/013285.html > > > > > > > > In the process FreeBSD also gains plugin support (but untested). > > > > > > > > v4: - introduce error-early behavior for invalid plugin paths > > > > - support directories via the existing -d option instead of adding new > > > > > > > > v3: - merge the first commits > > > > > > > > v2: - move code to eal/common > > > > - add bsd support > > > > > > > > Panu Matilainen (2): > > > > eal: move plugin loading to eal/common > > > > eal: add support for driver directory concept > > > > > > > > > checkpatch complains for some indent problem (Thomas, can you fix this ?), > > > but the rest looks good to me. > > > > > > Acked-by: David Marchand > > > > > > Thanks Panu. > > > > Applied, thanks > > This patch introduces a new issue reported by Coverity. > > The root cause of the problem is that you are checking that it s a directory first with stat > then calling dlopen(). I malicious entity could get between the stat and the dlopen. I think it is a false positive. The aim of loading every files in the directory is out of a security scope IMHO.